Auto merge of rust-lang#98559 - jackh726:remove-reempty, r=oli-obk

bors · bors · commit 42361da5d976 · 2022-09-10T20:54:01.000Z
Remove ReEmpty

r? rust-lang/types
diff --git a/clippy_lints/src/needless_pass_by_value.rs b/clippy_lints/src/needless_pass_by_value.rs
@@ -173,7 +173,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessPassByValue {
                 (
                     preds.iter().any(|t| cx.tcx.is_diagnostic_item(sym::Borrow, t.def_id())),
                     !preds.is_empty() && {
-                        let ty_empty_region = cx.tcx.mk_imm_ref(cx.tcx.lifetimes.re_root_empty, ty);
+                        let ty_empty_region = cx.tcx.mk_imm_ref(cx.tcx.lifetimes.re_erased, ty);
                         preds.iter().all(|t| {
                             let ty_params = t.trait_ref.substs.iter().skip(1).collect::<Vec<_>>();
                             implements_trait(cx, ty_empty_region, t.def_id(), &ty_params)

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessPassByValue {`
`173`	`173`	`(`
`174`	`174`	`preds.iter().any(\|t\| cx.tcx.is_diagnostic_item(sym::Borrow, t.def_id())),`
`175`	`175`	`!preds.is_empty() && {`
`176`		`- let ty_empty_region = cx.tcx.mk_imm_ref(cx.tcx.lifetimes.re_root_empty, ty);`
	`176`	`+ let ty_empty_region = cx.tcx.mk_imm_ref(cx.tcx.lifetimes.re_erased, ty);`
`177`	`177`	`preds.iter().all(\|t\| {`
`178`	`178`	`let ty_params = t.trait_ref.substs.iter().skip(1).collect::<Vec<_>>();`
`179`	`179`	`implements_trait(cx, ty_empty_region, t.def_id(), &ty_params)`