Skip to content

Commit e71d12e

Browse files
committed
adjust version test to be more flexible
1 parent 76dd9ee commit e71d12e

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

commercetools/commercetools-apachehttp-client/src/test/java/com/commercetools/http/apachehttp/SolutionInfoTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ public class SolutionInfoTest {
99
public void version() {
1010
String version = new ApacheHttpClientSolutionInfo().getVersion();
1111

12-
Assertions.assertThat(version).startsWith("5.4.");
12+
Assertions.assertThat(Runtime.Version.parse(version).compareTo(Runtime.Version.parse("5.4.1"))).isGreaterThanOrEqualTo(0);
13+
Assertions.assertThat(version).startsWith("5.");
1314
}
1415
}

commercetools/commercetools-async-http-client/src/test/java/com/commercetools/http/asynchttpclient/SolutionInfoTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public class SolutionInfoTest {
1111
public void version() {
1212
String version = new AsyncHttpClientSolutionInfo().getVersion();
1313

14-
Assertions.assertThat(version).startsWith("2.12.");
14+
Assertions.assertThat(Runtime.Version.parse(version).compareTo(Runtime.Version.parse("2.12.0"))).isGreaterThanOrEqualTo(0);
15+
Assertions.assertThat(version).startsWith("2.");
1516
}
1617
}

commercetools/commercetools-okhttp-client3/src/test/java/com/commercetools/http/okhttp3/SolutionInfoTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ public class SolutionInfoTest {
99
public void version() {
1010
String version = new OkHttpClientSolutionInfo().getVersion();
1111

12-
Assertions.assertThat(version).startsWith("3.14.");
12+
Assertions.assertThat(Runtime.Version.parse(version).compareTo(Runtime.Version.parse("3.14.0"))).isGreaterThanOrEqualTo(0);
13+
Assertions.assertThat(version).startsWith("3.");
1314
}
1415
}

commercetools/commercetools-okhttp-client4/src/test/java/com/commercetools/http/okhttp4/SolutionInfoTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ public class SolutionInfoTest {
99
public void version() {
1010
String version = new OkHttpClientSolutionInfo().getVersion();
1111

12-
Assertions.assertThat(version).startsWith("4.12.");
12+
Assertions.assertThat(Runtime.Version.parse(version).compareTo(Runtime.Version.parse("4.12.0"))).isGreaterThanOrEqualTo(0);
13+
Assertions.assertThat(version).startsWith("4.");
1314
}
1415
}

commercetools/commercetools-reactornetty-client/src/test/java/com/commercetools/http/netty/SolutionInfoTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ public class SolutionInfoTest {
99
public void version() {
1010
String version = new NettyHttpClientSolutionInfo().getVersion();
1111

12-
Assertions.assertThat(version).startsWith("1.2.");
12+
Assertions.assertThat(Runtime.Version.parse(version).compareTo(Runtime.Version.parse("1.2.0"))).isGreaterThanOrEqualTo(0);
13+
Assertions.assertThat(version).startsWith("1.");
1314
}
1415
}

0 commit comments

Comments
 (0)