Skip to content

Commit 2acc6a9

Browse files
committed
use semver loose parsing
1 parent 0bd2ad7 commit 2acc6a9

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

commercetools/commercetools-apachehttp-client/src/test/java/com/commercetools/http/apachehttp/SolutionInfoTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11

22
package com.commercetools.http.apachehttp;
33

4+
import com.fasterxml.jackson.core.Version;
45
import com.vdurmont.semver4j.Semver;
56
import org.assertj.core.api.Assertions;
67
import org.junit.jupiter.api.Test;
@@ -10,7 +11,7 @@ public class SolutionInfoTest {
1011
public void version() {
1112
String version = new ApacheHttpClientSolutionInfo().getVersion();
1213

13-
Assertions.assertThat(new Semver(version).compareTo(new Semver("5.4.1"))).isGreaterThanOrEqualTo(0);
14+
Assertions.assertThat(new Semver(version, Semver.SemverType.LOOSE).compareTo(new Semver("5.4.1"))).isGreaterThanOrEqualTo(0);
1415
Assertions.assertThat(version).startsWith("5.");
1516
}
1617
}

commercetools/commercetools-async-http-client/src/test/java/com/commercetools/http/asynchttpclient/SolutionInfoTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class SolutionInfoTest {
1212
public void version() {
1313
String version = new AsyncHttpClientSolutionInfo().getVersion();
1414

15-
Assertions.assertThat(new Semver(version).compareTo(new Semver("2.12.0"))).isGreaterThanOrEqualTo(0);
15+
Assertions.assertThat(new Semver(version, Semver.SemverType.LOOSE).compareTo(new Semver("2.12.0"))).isGreaterThanOrEqualTo(0);
1616
Assertions.assertThat(version).startsWith("2.");
1717
}
1818
}

commercetools/commercetools-okhttp-client3/src/test/java/com/commercetools/http/okhttp3/SolutionInfoTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public class SolutionInfoTest {
1010
public void version() {
1111
String version = new OkHttpClientSolutionInfo().getVersion();
1212

13-
Assertions.assertThat(new Semver(version).compareTo(new Semver("3.14.0"))).isGreaterThanOrEqualTo(0);
13+
Assertions.assertThat(new Semver(version, Semver.SemverType.LOOSE).compareTo(new Semver("3.14.0"))).isGreaterThanOrEqualTo(0);
1414
Assertions.assertThat(version).startsWith("3.");
1515
}
1616
}

commercetools/commercetools-okhttp-client4/src/test/java/com/commercetools/http/okhttp4/SolutionInfoTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public class SolutionInfoTest {
1010
public void version() {
1111
String version = new OkHttpClientSolutionInfo().getVersion();
1212

13-
Assertions.assertThat(new Semver(version).compareTo(new Semver("4.12.0"))).isGreaterThanOrEqualTo(0);
13+
Assertions.assertThat(new Semver(version, Semver.SemverType.LOOSE).compareTo(new Semver("4.12.0"))).isGreaterThanOrEqualTo(0);
1414
Assertions.assertThat(version).startsWith("4.");
1515
}
1616
}

commercetools/commercetools-reactornetty-client/src/test/java/com/commercetools/http/netty/SolutionInfoTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public class SolutionInfoTest {
1010
public void version() {
1111
String version = new NettyHttpClientSolutionInfo().getVersion();
1212

13-
Assertions.assertThat(new Semver(version).compareTo(new Semver("1.2.0"))).isGreaterThanOrEqualTo(0);
13+
Assertions.assertThat(new Semver(version, Semver.SemverType.LOOSE).compareTo(new Semver("1.2.0"))).isGreaterThanOrEqualTo(0);
1414
Assertions.assertThat(version).startsWith("1.");
1515
}
1616
}

0 commit comments

Comments
 (0)