Skip to content

Commit ca67c38

Browse files
committed
[CM-1580]: Fixed curve logging tests to check logical path of logged assets.
1 parent 9cedd06 commit ca67c38

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

comet-java-client/src/test/java/ml/comet/experiment/impl/ApiExperimentTest.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ public void testLogCurve() throws Exception {
123123

124124
LoggedExperimentAsset asset = assets.get(0);
125125
assertEquals(CURVE.type(), asset.getType(), "wrong asset type");
126+
assertEquals(fileName, asset.getLogicalPath(), "wrong asset path");
126127
assertEquals(0, asset.getMetadata().size(), "no metadata expected");
127128
ExperimentContext assetContext = ((LoggedExperimentAssetImpl) asset).getContext();
128129
assertEquals(SOME_FULL_CONTEXT.getStep(), assetContext.getStep(), "wrong context step");
@@ -144,7 +145,9 @@ public void testLogCurveOverwrite() throws Exception {
144145
List<LoggedExperimentAsset> assets = apiExperiment.getAssetList(CURVE.type());
145146
assertEquals(1, assets.size(), "wrong number of assets returned");
146147

147-
size = assets.get(0).getSize().orElse((long) -1);
148+
LoggedExperimentAsset asset = assets.get(0);
149+
assertEquals(fileName, asset.getLogicalPath(), "wrong asset path");
150+
size = asset.getSize().orElse((long) -1);
148151
assertTrue(size > 0, "wrong asset size");
149152

150153
experimentKey = apiExperiment.getExperimentKey();
@@ -158,6 +161,11 @@ public void testLogCurveOverwrite() throws Exception {
158161
apiExperiment.logCurve(curve, true, SOME_FULL_CONTEXT);
159162

160163
List<LoggedExperimentAsset> assets = apiExperiment.getAssetList(CURVE.type());
164+
if (assets.size() > 1) {
165+
for (LoggedExperimentAsset asset : assets) {
166+
System.out.println(asset.getLogicalPath());
167+
}
168+
}
161169
assertEquals(1, assets.size(), "wrong number of assets returned");
162170

163171
long newSize = assets.get(0).getSize().orElse((long) -1);

comet-java-client/src/test/java/ml/comet/experiment/impl/OnlineExperimentTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -619,6 +619,7 @@ public void testLogAndGetCurve() throws Exception {
619619

620620
LoggedExperimentAsset asset = assets.get(0);
621621
assertEquals(CURVE.type(), asset.getType(), "wrong type");
622+
assertEquals(fileName, asset.getLogicalPath(), "wrong asset path");
622623
assertEquals(0, asset.getMetadata().size(), "no metadata expected");
623624
ExperimentContext assetContext = ((LoggedExperimentAssetImpl) asset).getContext();
624625
assertEquals(SOME_FULL_CONTEXT.getStep(), assetContext.getStep(), "wrong context step");

0 commit comments

Comments
 (0)