[N/A]: Fixed OnlineExperimentTest.testLogAndGetParameter to match current server implementation of returning full parameter name.

Author: yaricom

comet-java-client/src/main/java/ml/comet/experiment/context/ExperimentContext.java

@@ -18,6 +18,15 @@ public final class ExperimentContext {
     ExperimentContext() {
     }
 
+    /**
+     * Creates new instance with specified parameters.
+     *
+     * @param context the current context identifier of the data log operation.
+     */
+    public ExperimentContext(String context) {
+        this.context = context;
+    }
+
     /**
      * Creates new instance with specified parameters.
      *

comet-java-client/src/main/java/ml/comet/experiment/impl/utils/CometUtils.java

@@ -80,14 +80,14 @@ public static <T> void putNotNull(@NonNull Map<T, String> map, @NonNull T key, O
     }
 
     /**
-     * Creates full name of the metric as it is returned by backend.
+     * Creates full name of the metric/parameter as it is returned by backend.
      *
-     * @param name    the short name of the metric
+     * @param name    the short name of the metric/parameter
      * @param context the experiment context associated with metric
      * @return the full name of the metric, which can be prefixed by context ID if present in the
      * provided {@code context} parameter.
      */
-    public static String fullMetricName(@NonNull String name, @NonNull ExperimentContext context) {
+    public static String fullMetricParameterName(@NonNull String name, @NonNull ExperimentContext context) {
         if (StringUtils.isEmpty(context.getContext())) {
             return name;
         } else {

comet-java-client/src/test/java/ml/comet/experiment/impl/OnlineExperimentTest.java

@@ -37,7 +37,7 @@
 import static ml.comet.experiment.impl.asset.AssetType.TEXT_SAMPLE;
 import static ml.comet.experiment.impl.resources.LogMessages.FAILED_REGISTER_EXPERIMENT;
 import static ml.comet.experiment.impl.resources.LogMessages.getString;
-import static ml.comet.experiment.impl.utils.CometUtils.fullMetricName;
+import static ml.comet.experiment.impl.utils.CometUtils.fullMetricParameterName;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
@@ -177,10 +177,10 @@ public void testLogAndGetMetric() {
             awaitForCondition(() -> experiment.getMetrics().size() == 3, "experiment metrics get timeout");
 
             List<Value> metrics = experiment.getMetrics();
-            validateValues(metrics, fullMetricName(ONE_MORE_PARAMETER,
+            validateValues(metrics, fullMetricParameterName(ONE_MORE_PARAMETER,
                     ExperimentContext.builder().withContext(TestUtils.SOME_CONTEXT_ID).build()), ONE_MORE_PARAMETER_VALUE);
-            validateValues(metrics, fullMetricName(SOME_PARAMETER, TestUtils.SOME_FULL_CONTEXT), SOME_PARAMETER_VALUE);
-            validateValues(metrics, fullMetricName(ANOTHER_PARAMETER, SOME_PARTIAL_CONTEXT), ANOTHER_PARAMETER_VALUE);
+            validateValues(metrics, fullMetricParameterName(SOME_PARAMETER, TestUtils.SOME_FULL_CONTEXT), SOME_PARAMETER_VALUE);
+            validateValues(metrics, fullMetricParameterName(ANOTHER_PARAMETER, SOME_PARTIAL_CONTEXT), ANOTHER_PARAMETER_VALUE);
         } catch (Throwable throwable) {
             fail(throwable);
         }
@@ -191,7 +191,7 @@ public void testLogAndGetParameter() {
         try (OnlineExperimentImpl experiment = (OnlineExperimentImpl) createOnlineExperiment()) {
             // Test log parameter with base context's ID set directly to experiment
             //
-            experiment.setContext(TestUtils.SOME_CONTEXT_ID);
+            experiment.setContext(SOME_CONTEXT_ID);
             OnCompleteAction onComplete = new OnCompleteAction();
             experiment.logParameter(
                     ONE_MORE_PARAMETER, ONE_MORE_PARAMETER_VALUE, ExperimentContext.empty(), Optional.of(onComplete));
@@ -201,7 +201,7 @@ public void testLogAndGetParameter() {
             //
             onComplete = new OnCompleteAction();
             experiment.logParameter(
-                    SOME_PARAMETER, SOME_PARAMETER_VALUE, TestUtils.SOME_FULL_CONTEXT, Optional.of(onComplete));
+                    SOME_PARAMETER, SOME_PARAMETER_VALUE, SOME_FULL_CONTEXT, Optional.of(onComplete));
             awaitForCondition(onComplete, "logParameterAsync onComplete timeout");
 
             // Test log parameter with partial context
@@ -215,8 +215,9 @@ public void testLogAndGetParameter() {
             //
             awaitForCondition(() -> experiment.getParameters().size() == 3, "experiment parameters get timeout");
             List<Value> params = experiment.getParameters();
-            validateValues(params, ONE_MORE_PARAMETER, ONE_MORE_PARAMETER_VALUE);
-            validateValues(params, SOME_PARAMETER, SOME_PARAMETER_VALUE);
+            validateValues(params, fullMetricParameterName(ONE_MORE_PARAMETER, new ExperimentContext(SOME_CONTEXT_ID)),
+                    ONE_MORE_PARAMETER_VALUE);
+            validateValues(params, fullMetricParameterName(SOME_PARAMETER, SOME_FULL_CONTEXT), SOME_PARAMETER_VALUE);
             validateValues(params, ANOTHER_PARAMETER, ANOTHER_PARAMETER_VALUE);
 
         } catch (Throwable throwable) {