Skip to content

Commit f644afb

Browse files
authored
feat: replace youtube player to iframe_youtube_place (#73)
1 parent c62a593 commit f644afb

File tree

11 files changed

+82
-239
lines changed

11 files changed

+82
-239
lines changed

client/ios/Podfile.lock

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,13 @@ PODS:
88
- Flutter
99
- OrderedSet (~> 5.0)
1010
- OrderedSet (5.0.0)
11+
- url_launcher (0.0.1):
12+
- Flutter
1113

1214
DEPENDENCIES:
1315
- Flutter (from `Flutter`)
1416
- flutter_inappwebview (from `.symlinks/plugins/flutter_inappwebview/ios`)
17+
- url_launcher (from `.symlinks/plugins/url_launcher/ios`)
1518

1619
SPEC REPOS:
1720
trunk:
@@ -22,11 +25,14 @@ EXTERNAL SOURCES:
2225
:path: Flutter
2326
flutter_inappwebview:
2427
:path: ".symlinks/plugins/flutter_inappwebview/ios"
28+
url_launcher:
29+
:path: ".symlinks/plugins/url_launcher/ios"
2530

2631
SPEC CHECKSUMS:
2732
Flutter: 434fef37c0980e73bb6479ef766c45957d4b510c
2833
flutter_inappwebview: bfd58618f49dc62f2676de690fc6dcda1d6c3721
2934
OrderedSet: aaeb196f7fef5a9edf55d89760da9176ad40b93c
35+
url_launcher: 6fef411d543ceb26efce54b05a0a40bfd74cbbef
3036

3137
PODFILE CHECKSUM: aafe91acc616949ddb318b77800a7f51bffa2a4c
3238

client/lib/test-server.dart

Lines changed: 0 additions & 184 deletions
This file was deleted.

client/lib/utils/formatter.dart

Lines changed: 0 additions & 17 deletions
This file was deleted.

client/lib/widgets/detail/header.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import 'package:flutter/material.dart';
22
import 'package:intl/intl.dart';
33
import 'package:pr12er/protos/pkg/pr12er/messages.pb.dart';
4-
import 'package:pr12er/utils/formatter.dart';
54

65
// ignore: must_be_immutable
76
class HeaderWidget extends StatelessWidget {
@@ -43,12 +42,12 @@ class HeaderWidget extends StatelessWidget {
4342
const SizedBox(width: 8),
4443
const Icon(Icons.remove_red_eye),
4544
const SizedBox(width: 8),
46-
Text(reformatNumbers(video.numberOfViews.toInt()),
45+
Text(NumberFormat.compact().format(video.numberOfViews),
4746
style: const TextStyle(fontSize: 18)),
4847
const SizedBox(width: 15),
4948
getLikeIcon(),
5049
const SizedBox(width: 8),
51-
Text(reformatNumbers(video.numberOfLike.toInt()),
50+
Text(NumberFormat.compact().format(video.numberOfLike),
5251
style: const TextStyle(fontSize: 18)),
5352
];
5453
}

client/lib/widgets/detail/youtube.dart

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import 'package:flutter/material.dart';
2-
import 'package:youtube_player_flutter/youtube_player_flutter.dart';
2+
// import 'package:youtube_player_flutter/youtube_player_flutter.dart';
3+
import 'package:youtube_player_iframe/youtube_player_iframe.dart';
34

45
class YoutubeWidget extends StatefulWidget {
56
final String youtubeId;
@@ -22,15 +23,13 @@ class _DetailState extends State<YoutubeWidget> {
2223

2324
@override
2425
Widget build(BuildContext context) {
25-
return YoutubePlayerBuilder(
26-
player: YoutubePlayer(
27-
controller: _controller,
26+
return YoutubePlayerControllerProvider(
27+
// Provides controller to all the widget below it.
28+
controller: _controller,
29+
child: const YoutubePlayerIFrame(
30+
// ignore: avoid_redundant_argument_values
31+
aspectRatio: 16 / 9,
2832
),
29-
builder: (context, player) {
30-
return Column(
31-
children: [player],
32-
);
33-
},
3433
);
3534
}
3635
}

client/pubspec.lock

Lines changed: 62 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,11 @@ packages:
233233
description: flutter
234234
source: sdk
235235
version: "0.0.0"
236+
flutter_web_plugins:
237+
dependency: transitive
238+
description: flutter
239+
source: sdk
240+
version: "0.0.0"
236241
frontend_server_client:
237242
dependency: transitive
238243
description:
@@ -413,6 +418,13 @@ packages:
413418
url: "https://pub.dartlang.org"
414419
source: hosted
415420
version: "3.0.0"
421+
plugin_platform_interface:
422+
dependency: transitive
423+
description:
424+
name: plugin_platform_interface
425+
url: "https://pub.dartlang.org"
426+
source: hosted
427+
version: "2.0.0"
416428
pool:
417429
dependency: transitive
418430
description:
@@ -593,6 +605,48 @@ packages:
593605
url: "https://pub.dartlang.org"
594606
source: hosted
595607
version: "1.3.0"
608+
url_launcher:
609+
dependency: transitive
610+
description:
611+
name: url_launcher
612+
url: "https://pub.dartlang.org"
613+
source: hosted
614+
version: "6.0.6"
615+
url_launcher_linux:
616+
dependency: transitive
617+
description:
618+
name: url_launcher_linux
619+
url: "https://pub.dartlang.org"
620+
source: hosted
621+
version: "2.0.0"
622+
url_launcher_macos:
623+
dependency: transitive
624+
description:
625+
name: url_launcher_macos
626+
url: "https://pub.dartlang.org"
627+
source: hosted
628+
version: "2.0.0"
629+
url_launcher_platform_interface:
630+
dependency: transitive
631+
description:
632+
name: url_launcher_platform_interface
633+
url: "https://pub.dartlang.org"
634+
source: hosted
635+
version: "2.0.3"
636+
url_launcher_web:
637+
dependency: transitive
638+
description:
639+
name: url_launcher_web
640+
url: "https://pub.dartlang.org"
641+
source: hosted
642+
version: "2.0.1"
643+
url_launcher_windows:
644+
dependency: transitive
645+
description:
646+
name: url_launcher_windows
647+
url: "https://pub.dartlang.org"
648+
source: hosted
649+
version: "2.0.0"
596650
vector_math:
597651
dependency: transitive
598652
description:
@@ -649,6 +703,13 @@ packages:
649703
url: "https://pub.dartlang.org"
650704
source: hosted
651705
version: "8.0.0"
706+
youtube_player_iframe:
707+
dependency: "direct main"
708+
description:
709+
name: youtube_player_iframe
710+
url: "https://pub.dartlang.org"
711+
source: hosted
712+
version: "2.0.0"
652713
sdks:
653714
dart: ">=2.12.0 <3.0.0"
654-
flutter: ">=1.22.2"
715+
flutter: ">=2.0.0"

client/pubspec.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ dependencies:
3030
protobuf: ^2.0.0
3131
provider: ^5.0.0
3232
youtube_player_flutter: ^8.0.0
33+
youtube_player_iframe: ^2.0.0
3334

3435
dev_dependencies:
3536
build_runner: ^2.0.4

0 commit comments

Comments
 (0)