Listeners: failure to bind must propagate on fresh Promise.

Author: Robin Duda

core/main/java/com/codingchili/core/listener/transport/RestListener.java

@@ -67,19 +67,23 @@ public CoreListener handler(CoreHandler handler) {
 
     @Override
     public void start(Promise<Void> start) {
-        start.future().onSuccess((v) -> {
+        var handlerPromise = Promise.<Void>promise();
+
+        handlerPromise.future().onSuccess((v) -> {
             core.vertx().createHttpServer(settings.getHttpOptions())
                     .requestHandler(router)
                     .exceptionHandler(logger::onError)
                     .listen(settings.getPort(), getBindAddress(), listen -> {
                         if (listen.succeeded()) {
                             settings.addListenPort(listen.result().actualPort());
+                            start.complete();
                         } else {
                             start.fail(listen.cause());
                         }
                     });
-        });
-        handler.start(start);
+        }).onFailure(start::fail);
+
+        handler.start(handlerPromise);
     }
 
     @Override

core/main/java/com/codingchili/core/listener/transport/TcpListener.java

@@ -41,7 +41,9 @@ public CoreListener handler(CoreHandler handler) {
 
     @Override
     public void start(Promise<Void> start) {
-        start.future().onSuccess((v) -> {
+        var handlerPromise = Promise.<Void>promise();
+
+        handlerPromise.future().onSuccess((v) -> {
             core.vertx().createNetServer(settings.getHttpOptions())
                     .exceptionHandler(logger::onError)
                     .connectHandler(socket -> {
@@ -54,12 +56,14 @@ public void start(Promise<Void> start) {
                     }).listen(settings.getPort(), getBindAddress(), listen -> {
                         if (listen.succeeded()) {
                             settings.addListenPort(listen.result().actualPort());
+                            start.complete();
                         } else {
                             start.fail(listen.cause());
                         }
                     });
-        });
-        handler.start(start);
+        }).onFailure(start::fail);
+
+        handler.start(handlerPromise);
     }
 
     public Connection connected(NetSocket socket) {

core/main/java/com/codingchili/core/listener/transport/UdpListener.java

@@ -43,19 +43,23 @@ public CoreListener handler(CoreHandler handler) {
 
     @Override
     public void start(Promise<Void> start) {
+        var handlerPromise = Promise.<Void>promise();
+
         start.future().onSuccess((v) -> {
             core.vertx().createDatagramSocket().listen(settings.getPort(), getBindAddress(), listen -> {
                 if (listen.succeeded()) {
                     settings.addListenPort(listen.result().localAddress().port());
                     listen.result()
                             .handler(this::handle)
                             .exceptionHandler(logger::onError);
+                    start.complete();
                 } else {
                     start.fail(listen.cause());
                 }
             });
-        });
-        handler.start(start);
+        }).onFailure(start::fail);
+
+        handler.start(handlerPromise);
     }
 
     @Override

core/main/java/com/codingchili/core/listener/transport/WebsocketListener.java

@@ -70,7 +70,8 @@ private void listen(Promise<Void> start) {
                             .encodePrettily());
         });
 
-        start.future().onSuccess((v) -> {
+        var handlerPromise = Promise.<Void>promise();
+        handlerPromise.future().onSuccess((v) -> {
             core.vertx().createHttpServer(settings.getHttpOptions())
                     .exceptionHandler(logger::onError)
                     .webSocketHandler(socket -> {
@@ -88,8 +89,8 @@ private void listen(Promise<Void> start) {
                             start.fail(listen.cause());
                         }
                     });
-        });
-        handler.start(start);
+        }).onFailure(start::fail);
+        handler.start(handlerPromise);
     }
 
     private Connection connected(ServerWebSocket socket) {