refactor: remove unused code and simplify function parameters

- Remove unused `time` and `pflag` imports from `cli.go`.
- Comment out the unused `logFlushFreq` variable in `cli.go`.
- Simplify commit message generation by directly assigning `commitPromptVal.String()` in `commit.go`.
- Fix error handling in `ls.go` by ignoring the return value of `fmt.Fprintln`.
- Initialize `messages` slice with a fixed length in `chat_history_store.go`.
- Ignore the error returned by `db.Close()` in `loadcontext_store_test.go`.
- Remove unused `prepareCompletionMessages`, `preparePipePrompt`, and `prepareSystemPrompt` functions from `engine.go`.
- Remove unused `summaryMessagesPrompt` variable from `prompts.go`.
- Remove unused `defaultWidth` constant from `chat.go`.
- Simplify `writeWithSync` function by removing the `calldepth` parameter in `assert.go` and `log.go`.
- Use a constant `callDepth` value in `log.go` for logging.

Signed-off-by: codiing-hui <wecoding@yeah.net>

Author: coding-hui

internal/cli/cli.go

@@ -10,11 +10,10 @@ import (
 	"io"
 	"os"
 	"slices"
-	"time"
 
-	cliflag "github.com/coding-hui/common/cli/flag"
 	"github.com/spf13/cobra"
-	"github.com/spf13/pflag"
+
+	cliflag "github.com/coding-hui/common/cli/flag"
 
 	"github.com/coding-hui/ai-terminal/internal/cli/ask"
 	"github.com/coding-hui/ai-terminal/internal/cli/coder"
@@ -36,7 +35,7 @@ import (
 	_ "github.com/coding-hui/ai-terminal/internal/convo/sqlite3"
 )
 
-var logFlushFreq = pflag.Duration(options.FlagLogFlushFrequency, 5*time.Second, "Maximum number of seconds between log flushes")
+// var logFlushFreq = pflag.Duration(options.FlagLogFlushFrequency, 5*time.Second, "Maximum number of seconds between log flushes")
 
 // NewDefaultAICommand creates the `ai` command with default arguments.
 func NewDefaultAICommand() *cobra.Command {

internal/cli/commit/commit.go

@@ -320,7 +320,7 @@ func (o *Options) generateCommitMsg(engine *llm.Engine, vars map[string]any) (st
 		}
 	}
 
-	var commitMsg string
+	commitMsg := commitPromptVal.String()
 	if o.commitLang != prompt.DefaultLanguage {
 		console.RenderStep("Translating commit message to %s...", o.commitLang)
 		translationPrompt, err := prompt.GetPromptStringByTemplateName(prompt.TranslationTemplate, map[string]any{
@@ -339,8 +339,7 @@ func (o *Options) generateCommitMsg(engine *llm.Engine, vars map[string]any) (st
 	}
 
 	// unescape html entities in commit message
-	commitMsg = html.UnescapeString(commitPromptVal.String())
-	commitMsg = strings.TrimSpace(commitPromptVal.String())
+	commitMsg = strings.TrimSpace(html.UnescapeString(commitMsg))
 
 	// Output simplified commit summary
 	lines := strings.Split(commitPromptVal.String(), "\n")

internal/cli/convo/ls.go

@@ -49,7 +49,7 @@ func (o *ls) Run(ioStreams genericclioptions.IOStreams, cfg *options.Config) err
 	}
 
 	if len(conversations) == 0 {
-		fmt.Fprintln(ioStreams.ErrOut, "No conversations found.")
+		_, _ = fmt.Fprintln(ioStreams.ErrOut, "No conversations found.")
 		return nil
 	}
 

internal/convo/chat_history_store.go

@@ -82,7 +82,7 @@ func (h *SimpleChatHistoryStore) load(convoID string) error {
 		return fmt.Errorf("read: %w", err)
 	}
 
-	var messages []llms.ChatMessage
+	messages := make([]llms.ChatMessage, len(rawMessages))
 	for _, v := range rawMessages {
 		messages = append(messages, v.ToChatMessage())
 	}

internal/convo/sqlite3/loadcontext_store_test.go

@@ -151,7 +151,7 @@ func setupTestDB(t *testing.T) *sqlx.DB {
 	require.NoError(t, err)
 
 	t.Cleanup(func() {
-		db.Close()
+		_ = db.Close()
 	})
 
 	return db

internal/llm/engine.go

@@ -279,77 +279,6 @@ func (e *Engine) appendAssistantMessage(content string) {
 	}
 }
 
-func (e *Engine) prepareCompletionMessages() []llms.MessageContent {
-	var messages []llms.MessageContent
-
-	if e.config.Ai.SystemPrompt == "" {
-		messages = append(messages, llms.MessageContent{
-			Role:  llms.ChatMessageTypeSystem,
-			Parts: []llms.ContentPart{llms.TextPart(e.prepareSystemPrompt())},
-		})
-	}
-
-	if e.pipe != "" {
-		messages = append(
-			messages,
-			llms.MessageContent{
-				Role:  llms.ChatMessageTypeHuman,
-				Parts: []llms.ContentPart{llms.TextPart(e.preparePipePrompt())},
-			},
-		)
-	}
-
-	if e.convoStore != nil {
-		history, err := e.convoStore.Messages(context.Background(), e.config.ConversationID)
-		if err != nil {
-			errbook.HandleError(errbook.Wrap("failed to get chat convo", err))
-		}
-		messages = append(messages, slices.Map(history, convert)...)
-	}
-
-	return messages
-}
-
-func (e *Engine) preparePipePrompt() string {
-	return fmt.Sprintf("I will work on the following input: %s", e.pipe)
-}
-
-func (e *Engine) prepareSystemPrompt() string {
-	var bodyPart string
-	if e.mode == ExecEngineMode {
-		bodyPart = e.prepareSystemPromptExecPart()
-	} else {
-		bodyPart = e.prepareSystemPromptChatPart()
-	}
-
-	return bodyPart
-}
-
-func (e *Engine) prepareSystemPromptExecPart() string {
-	return "Your are a powerful terminal assistant generating a JSON containing a command line for my input.\n" +
-		"The language you are using is Chinese.\n" +
-		"You will always reply using the following json structure: {\"cmd\":\"the command\", \"exp\": \"some explanation\", \"exec\": true}.\n" +
-		"Your answer will always only contain the json structure, never add any advice or supplementary detail or information, even if I asked the same question before.\n" +
-		"The field cmd will contain a single line command (don't use new lines, use separators like && and ; instead).\n" +
-		"The field exp will contain an short explanation of the command if you managed to generate an executable command, otherwise it will contain the reason of your failure.\n" +
-		"The field exec will contain true if you managed to generate an executable command, false otherwise." +
-		"\n" +
-		"Examples:\n" +
-		"Me: list all files in my home dir\n" +
-		"You: {\"cmd\":\"ls ~\", \"exp\": \"list all files in your home dir\", \"exec\\: true}\n" +
-		"Me: list all pods of all namespaces\n" +
-		"You: {\"cmd\":\"kubectl get pods --all-namespaces\", \"exp\": \"list pods form all k8s namespaces\", \"exec\": true}\n" +
-		"Me: how are you ?\n" +
-		"You: {\"cmd\":\"\", \"exp\": \"I'm good thanks but I cannot generate a command for this. Use the chat mode to discuss.\", \"exec\": false}"
-}
-
-func (e *Engine) prepareSystemPromptChatPart() string {
-	if e.config.Ai.OutputFormat == options.RawOutputFormat {
-		return `You are a powerful terminal assistant. Your primary language is English and you are good at answering users' questions.`
-	}
-	return `You are a powerful terminal assistant. Your primary language is English and you are good at answering users' questions in markdown format.`
-}
-
 func ensureApiKey(api options.API) (string, error) {
 	key := api.APIKey
 	if key == "" && api.APIKeyEnv != "" && api.APIKeyCmd == "" {

internal/llm/prompts.go

@@ -1,3 +1 @@
 package llm
-
-var summaryMessagesPrompt = "将上面的对话内容，总结成一句简洁的标题"

internal/ui/chat/chat.go

@@ -25,10 +25,6 @@ import (
 	"github.com/coding-hui/ai-terminal/internal/util/term"
 )
 
-const (
-	defaultWidth = 120
-)
-
 type state int
 
 const (

internal/util/debug/assert.go

@@ -27,7 +27,7 @@ func Assert(cond bool, msg interface{}) {
 	if enableAssert {
 		panic(msg)
 	}
-	writeWithSync(2, "[ASSERT] "+toString(msg))
+	writeWithSync("[ASSERT] " + toString(msg))
 }
 
 func toString(v interface{}) string {
@@ -51,5 +51,5 @@ func AssertNoError(err error) {
 	if enableAssert {
 		panic(err)
 	}
-	writeWithSync(2, "[ASSERT] "+err.Error())
+	writeWithSync("[ASSERT] " + err.Error())
 }

internal/util/debug/log.go

@@ -8,6 +8,7 @@ import (
 )
 
 const (
+	callDepth    = 2
 	envEnableLog = "GO_PROMPT_ENABLE_LOG"
 	logFileName  = "ai-terminal.log"
 )
@@ -37,26 +38,24 @@ func Teardown() {
 	_ = logfile.Close()
 }
 
-func writeWithSync(calldepth int, msg string) {
-	calldepth++
+func writeWithSync(msg string) {
 	if logfile == nil {
 		return
 	}
-	_ = logger.Output(calldepth, msg)
+	_ = logger.Output(callDepth, msg)
 	_ = logfile.Sync() // immediately write msg
 }
 
 // Log to output message
 func Log(msg string) {
-	calldepth := 2
-	writeWithSync(calldepth, msg)
+	writeWithSync(msg)
 }
 
 func Trace(s string, args ...interface{}) string {
-	writeWithSync(2, fmt.Sprintln("\n\n------------entering:", s, args))
+	writeWithSync(fmt.Sprintln("\n\n------------entering:", s, args))
 	return s
 }
 
 func Un(s string) {
-	writeWithSync(2, fmt.Sprintln("------------ leaving:", s))
+	writeWithSync(fmt.Sprintln("------------ leaving:", s))
 }