From 8e41873e04727bf0edf75f411ce1c4e22118ee57 Mon Sep 17 00:00:00 2001
From: Jeff Schornick <jeff@schornick.org>
Date: Wed, 5 Mar 2025 00:36:08 -0500
Subject: [PATCH] Ignore spaces when verifying DKIM entry

A DKIM tag list can include arbitrary whitespace between entries[1].

Removing whitespace during the DKIM validity check should prevent at
least one class of false failure from being reported.

[1] https://datatracker.ietf.org/doc/html/rfc6376/#section-3.2
---
 mxroute_tools.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mxroute_tools.py b/mxroute_tools.py
index 555334d..a2e6e2b 100755
--- a/mxroute_tools.py
+++ b/mxroute_tools.py
@@ -150,8 +150,7 @@ def command_dkim(domains):
         dns_data = make_api_request(DNS_CMD, {'domain': domain })
         dkim_data = next((item for item in dns_data['records'] if item.get('name') == DKIM_SUB), None)
         if dkim_data:
-            dkim_data = dkim_data['value']
-            dkim_data = dkim_data[1:len(dkim_data)-1]
+            dkim_data = dkim_data['value'].strip('"').replace(' ','')
 
         # Now test if it matches by looking up the live value on DNS
         # pip3 install dnspython
@@ -160,7 +159,7 @@ def command_dkim(domains):
         try:
             dns_lookup = dns.resolver.resolve(f"{DKIM_SUB}.{domain}", 'TXT')[0]
             for txt_string in dns_lookup.strings:
-                dkim_in_dns = dkim_in_dns + txt_string.decode('utf-8')
+                dkim_in_dns = dkim_in_dns + txt_string.decode('utf-8').replace(' ','')
         except Exception:
             dkim_in_dns = 'NONE'