-
Notifications
You must be signed in to change notification settings - Fork 987
Encoding='utf 8' correction & resolve .gitignore & merge main #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoding='utf 8' correction & resolve .gitignore & merge main #72
Conversation
…proved .gitignore parsing
|
Hey there!
I’ve tried to fix the code with your changes, and I think it’s working now.
Let me know if you encounter any more issues or if there’s anything else I should adjust.
Best regards,
…-----------------------------------------------------------PHAM Dai Hung Mail: ***@***.******@***.***
Tél : (+33) 06.13.68.53.14--------------------------------------------------
Le lundi 30 décembre 2024 à 05:42:24 UTC+1, Romain Courtois ***@***.***> a écrit :
Hey there
I'm sorry I tried to merge main in here from the Github Interface and I might have messed up the code
I can't push fixes to your branch so you can either add me to contributors on your branch or fix it yourself
Here's why it probably broke:
There was a refactor on main where many internal functions are now prefixed with a _
And I forgot to adapt at least one occurence of this in your code:
image.png (view on web)
That being said:
I thing there's currently a bit too many changes at the same time on this branch making it a bit hard to review
.gitignore is auto-applied for local paths (run 'gitingest path' on local)
Correct encoding (utf-8) is used.
URLs are strictly validated and detected when (run 'gitingest url' on local)
It would be ideal if you could you open a separate PR for each of those fixes?
Thank you in advance! That will make the reviewing process much easier
I can help you if you want you can reach me on Discord
If that works with you I can let you close this PR
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@phamhung075 it seems like the tests are not passing You can run those yourself to debug by installing the dev dependencies Also I'm afraid there's still too many changes at once in this PR, it's not very clearly scoped Could you please split the changes in 3 different Pr for each distinct feature?
Thank you in advance |
|
Hi @cyclotruc,
I've successfully run the tests locally, and everything passed without issues:
```
PS D:\DaiHung\__temp\gitingest> pytestc:\Users\daihu\AppData\Local\Programs\Python\Python312\Lib\site-packages\pytest_asyncio\plugin.py:207: PytestDeprecationWarning: The configuration option "asyncio_default_fixture_loop_scope" is unset.The event loop scope for asynchronous fixtures will default to the fixture caching scope. Future versions of pytest-asyncio will default the loop scope for asynchronous fixtures to function scope. Set the default fixture loop scope explicitly in order to avoid unexpected behavior in the future. Valid fixture loop scopes are: "function", "class", "module", "package", "session" warnings.warn(PytestDeprecationWarning(_DEFAULT_FIXTURE_LOOP_SCOPE_UNSET))========================================================================================= test session starts ==========================================================================================platform win32 -- Python 3.12.6, pytest-8.3.4, pluggy-1.5.0rootdir: D:\DaiHung\__temp\gitingestconfigfile: pytest.initestpaths: src/gitingest/testsplugins: anyio-4.7.0, asyncio-0.25.0asyncio: mode=Mode.AUTO, asyncio_default_fixture_loop_scope=Nonecollected 11 itemssrc\gitingest\tests\test_clone.py .... [ 36%]src\gitingest\tests\test_ingest.py .. [ 54%]src\gitingest\tests\test_parse_query.py ..... [100%]========================================================================================== 11 passed in 0.06s ==========================================================================================
```
|
@phamhung075 Thank you again for your dedication but I would really like us to split the Pr in multiple smaller ones I'm going to close this branch but please don't hesitate to open a new one with only 1 type of change at a time as mentionned in my previous message |


Result:
gitingest https://github.com/cyclotruc/gitingest