feat: support days/weeks in Duration
#28
Merged
+157
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
ammario
approved these changes
Nov 23, 2025
Member
ammario
left a comment
ammario
left a comment
There was a problem hiding this comment.
rubber-stamping — I don't want to maintain this repo or review PRs. I gave you admin and the core team can figure out ownership.
ethanndickson
approved these changes
Nov 24, 2025
dannykopping
added a commit
to coder/coder
that referenced
this pull request
Nov 24, 2025
coder/serpent#28 added this capability. coder/serpent@v0.11.0...v0.12.0 --------- Signed-off-by: Danny Kopping <danny@coder.com>
david-fraley
pushed a commit
to coder/coder
that referenced
this pull request
Nov 25, 2025
coder/serpent#28 added this capability. coder/serpent@v0.11.0...v0.12.0 --------- Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
For longer time periods, expressing
Durations in days / weeks would be useful in coder/coder.