Skip to content

Conversation

@phorcys420
Copy link
Member

@phorcys420 phorcys420 commented Jul 31, 2025

Depends on #278

Part of WL-27

@phorcys420 phorcys420 marked this pull request as draft July 31, 2025 22:51
@phorcys420 phorcys420 changed the title phorcys420/update vscode desktop modules feat: update vscode-based desktop IDE modules to use vscode-desktop-core Aug 1, 2025
@phorcys420 phorcys420 marked this pull request as ready for review November 26, 2025 17:36
@phorcys420

This comment was marked as outdated.

@phorcys420
Copy link
Member Author

phorcys420 commented Nov 26, 2025

seems like the .tftest.hcl files also need some updating, which makes sense, but i'd like some input on what we actually want to do for these tests before i spend time on it

should i update .test.ts files or .tftest.hcl files?
and also, do we want to keep these tests if they're already being surfaced by vscode-desktop-core? if yes, do we have an idea on how to reduce duplicating code?

cc @DevelopmentCats @matifali

EDIT: after chatting with @DevelopmentCats, we chose to centralize tests in vscode-desktop-core

@phorcys420 phorcys420 enabled auto-merge (squash) November 26, 2025 20:29
@matifali
Copy link
Member

Does it cover all of them? We recently added positorn and antigravity modules.

@phorcys420
Copy link
Member Author

phorcys420 commented Nov 27, 2025

@matifali it doesn't cover positron actually, i will fix this soon, but antigravity is not merged yet

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But lets ensure we test them

@phorcys420 phorcys420 merged commit 0021a9f into main Nov 27, 2025
4 checks passed
@phorcys420 phorcys420 deleted the phorcys420/update-vscode-desktop-modules branch November 27, 2025 12:35
@phorcys420
Copy link
Member Author

@matifali i have already tested them a couple weeks ago and nothing changed seemingly, but i will test again to make sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants