From c32729685ab70f9939705efead5074a3cc914f35 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Wed, 2 Jul 2025 19:06:58 +0500 Subject: [PATCH 1/8] chore: update module display names --- registry/coder/modules/local-windows-rdp/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/registry/coder/modules/local-windows-rdp/README.md b/registry/coder/modules/local-windows-rdp/README.md index 4b447967f..02b7e6dca 100644 --- a/registry/coder/modules/local-windows-rdp/README.md +++ b/registry/coder/modules/local-windows-rdp/README.md @@ -1,11 +1,11 @@ --- -display_name: Windows RDP Desktop +display_name: RDP Web description: Enable RDP on Windows and add a one-click Coder Desktop button for seamless access icon: ../../../../.icons/desktop.svg maintainer_github: coder verified: true supported_os: [windows] -tags: [rdp, windows, desktop, remote] +tags: [rdp, windows, web] --- # Windows RDP Desktop From f8544d2ee3bb0abc38dcf586615e1b7256f74c37 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Wed, 2 Jul 2025 19:07:50 +0500 Subject: [PATCH 2/8] Update README.md --- registry/coder/modules/windows-rdp/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/registry/coder/modules/windows-rdp/README.md b/registry/coder/modules/windows-rdp/README.md index 0899a79ab..d1d7be744 100644 --- a/registry/coder/modules/windows-rdp/README.md +++ b/registry/coder/modules/windows-rdp/README.md @@ -1,5 +1,5 @@ --- -display_name: Windows RDP +display_name: RDP Web description: RDP Server and Web Client, powered by Devolutions Gateway icon: ../../../../.icons/desktop.svg maintainer_github: coder From 0392eef94fe3ccce791a94c9155d1cfe12bf00d1 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Wed, 2 Jul 2025 19:08:22 +0500 Subject: [PATCH 3/8] Update README.md --- registry/coder/modules/local-windows-rdp/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/registry/coder/modules/local-windows-rdp/README.md b/registry/coder/modules/local-windows-rdp/README.md index 02b7e6dca..4582d8d19 100644 --- a/registry/coder/modules/local-windows-rdp/README.md +++ b/registry/coder/modules/local-windows-rdp/README.md @@ -1,11 +1,11 @@ --- -display_name: RDP Web +display_name: RDP Desktop description: Enable RDP on Windows and add a one-click Coder Desktop button for seamless access icon: ../../../../.icons/desktop.svg maintainer_github: coder verified: true supported_os: [windows] -tags: [rdp, windows, web] +tags: [rdp, windows, desktop, local] --- # Windows RDP Desktop From e5c26db81aba4753ec49841af0dab3dde5fc4de0 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Wed, 2 Jul 2025 20:52:24 +0500 Subject: [PATCH 4/8] use GFM style alert --- registry/coder/modules/local-windows-rdp/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/registry/coder/modules/local-windows-rdp/README.md b/registry/coder/modules/local-windows-rdp/README.md index 4582d8d19..764c204b4 100644 --- a/registry/coder/modules/local-windows-rdp/README.md +++ b/registry/coder/modules/local-windows-rdp/README.md @@ -12,7 +12,8 @@ tags: [rdp, windows, desktop, local] This module enables Remote Desktop Protocol (RDP) on Windows workspaces and adds a one-click button to launch RDP sessions directly through [Coder Desktop](https://coder.com/docs/user-guides/desktop). It provides a complete, standalone solution for RDP access, eliminating the need for manual configuration or port forwarding through the Coder CLI. -> **Note**: [Coder Desktop](https://coder.com/docs/user-guides/desktop) is required on client devices to use the Local Windows RDP access feature. +> [!NOTE] +> [Coder Desktop](https://coder.com/docs/user-guides/desktop) is required on client devices to use the Local Windows RDP access feature. ```tf module "rdp_desktop" { From f3f00793e6bf3c281047ce2876af793875807019 Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Wed, 2 Jul 2025 20:53:10 +0500 Subject: [PATCH 5/8] remove Roadmap section This works on Azure. --- registry/coder/modules/windows-rdp/README.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/registry/coder/modules/windows-rdp/README.md b/registry/coder/modules/windows-rdp/README.md index d1d7be744..71d720e04 100644 --- a/registry/coder/modules/windows-rdp/README.md +++ b/registry/coder/modules/windows-rdp/README.md @@ -64,7 +64,3 @@ module "windows_rdp" { devolutions_gateway_version = "2025.1.6" # Specify a specific version } ``` - -## Roadmap - -- [ ] Test on Microsoft Azure. From b5bafee96472925d713562abd689c26aa2fce6ff Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Wed, 2 Jul 2025 20:55:54 +0500 Subject: [PATCH 6/8] update icon path --- registry/coder/modules/local-windows-rdp/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/registry/coder/modules/local-windows-rdp/README.md b/registry/coder/modules/local-windows-rdp/README.md index 764c204b4..a1585093a 100644 --- a/registry/coder/modules/local-windows-rdp/README.md +++ b/registry/coder/modules/local-windows-rdp/README.md @@ -1,7 +1,7 @@ --- display_name: RDP Desktop description: Enable RDP on Windows and add a one-click Coder Desktop button for seamless access -icon: ../../../../.icons/desktop.svg +icon: ../../../../.icons/rdp.svg maintainer_github: coder verified: true supported_os: [windows] From 37e1e346dd48ea32ba27eaa8426ac9d14455acef Mon Sep 17 00:00:00 2001 From: Atif Ali Date: Wed, 2 Jul 2025 21:00:08 +0500 Subject: [PATCH 7/8] Create rdp.svg --- .icons/rdp.svg | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 .icons/rdp.svg diff --git a/.icons/rdp.svg b/.icons/rdp.svg new file mode 100644 index 000000000..a47bfe7e4 --- /dev/null +++ b/.icons/rdp.svg @@ -0,0 +1,35 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From 2585ec6c287935d481a3d75b19840a93c7cd07ce Mon Sep 17 00:00:00 2001 From: Muhammad Atif Ali Date: Thu, 3 Jul 2025 09:11:16 +0500 Subject: [PATCH 8/8] chore: bump module versions (patch) --- MAINTAINER.md | 10 +++------- registry/coder/modules/local-windows-rdp/README.md | 9 ++++----- registry/coder/modules/windows-rdp/README.md | 8 ++++---- 3 files changed, 11 insertions(+), 16 deletions(-) diff --git a/MAINTAINER.md b/MAINTAINER.md index 69d1a6576..2011b5aa7 100644 --- a/MAINTAINER.md +++ b/MAINTAINER.md @@ -14,9 +14,7 @@ brew install go sudo apt install golang-go ``` -## Daily Tasks - -### Review PRs +## Reviewing a PR Check that PRs have: @@ -26,7 +24,7 @@ Check that PRs have: - [ ] Formatted code (`bun run fmt`) - [ ] Avatar image for new namespaces (`avatar.png` or `avatar.svg` in `.images/`) -#### Version Guidelines +### Version Guidelines When reviewing PRs, ensure the version change follows semantic versioning: @@ -42,7 +40,7 @@ PRs should clearly indicate the version change (e.g., `v1.2.3 → v1.2.4`). go build ./cmd/readmevalidation && ./readmevalidation ``` -## Releases +## Making a Release ### Create Release Tags @@ -99,5 +97,3 @@ status: "community" # or "partner", "official" - **Tests fail**: Ensure Docker with `--network=host`, check Terraform syntax - **Wrong file structure**: Use `./scripts/new_module.sh` for new modules - **Missing namespace avatar**: Must be `avatar.png` or `avatar.svg` in `.images/` directory - -That's it. Keep it simple. diff --git a/registry/coder/modules/local-windows-rdp/README.md b/registry/coder/modules/local-windows-rdp/README.md index a1585093a..ff93a4386 100644 --- a/registry/coder/modules/local-windows-rdp/README.md +++ b/registry/coder/modules/local-windows-rdp/README.md @@ -12,14 +12,13 @@ tags: [rdp, windows, desktop, local] This module enables Remote Desktop Protocol (RDP) on Windows workspaces and adds a one-click button to launch RDP sessions directly through [Coder Desktop](https://coder.com/docs/user-guides/desktop). It provides a complete, standalone solution for RDP access, eliminating the need for manual configuration or port forwarding through the Coder CLI. -> [!NOTE] -> [Coder Desktop](https://coder.com/docs/user-guides/desktop) is required on client devices to use the Local Windows RDP access feature. +> [!NOTE] > [Coder Desktop](https://coder.com/docs/user-guides/desktop) is required on client devices to use the Local Windows RDP access feature. ```tf module "rdp_desktop" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/local-windows-rdp/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.main.id agent_name = coder_agent.main.name } @@ -52,7 +51,7 @@ Uses default credentials (Username: `Administrator`, Password: `coderRDP!`): module "rdp_desktop" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/local-windows-rdp/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.main.id agent_name = coder_agent.main.name } @@ -66,7 +65,7 @@ Specify a custom display name for the `coder_app` button: module "rdp_desktop" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/local-windows-rdp/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.windows.id agent_name = "windows" display_name = "Windows Desktop" diff --git a/registry/coder/modules/windows-rdp/README.md b/registry/coder/modules/windows-rdp/README.md index 71d720e04..f2944f908 100644 --- a/registry/coder/modules/windows-rdp/README.md +++ b/registry/coder/modules/windows-rdp/README.md @@ -16,7 +16,7 @@ Enable Remote Desktop + a web based client on Windows workspaces, powered by [de module "windows_rdp" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.1" + version = "1.2.2" agent_id = resource.coder_agent.main.id resource_id = resource.aws_instance.dev.id } @@ -34,7 +34,7 @@ module "windows_rdp" { module "windows_rdp" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.1" + version = "1.2.2" agent_id = resource.coder_agent.main.id resource_id = resource.aws_instance.dev.id } @@ -46,7 +46,7 @@ module "windows_rdp" { module "windows_rdp" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.1" + version = "1.2.2" agent_id = resource.coder_agent.main.id resource_id = resource.google_compute_instance.dev[0].id } @@ -58,7 +58,7 @@ module "windows_rdp" { module "windows_rdp" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/windows-rdp/coder" - version = "1.2.1" + version = "1.2.2" agent_id = resource.coder_agent.main.id resource_id = resource.aws_instance.dev.id devolutions_gateway_version = "2025.1.6" # Specify a specific version