Skip to content

Commit d7d5c18

Browse files
authored
🤖 Fix: Ignore Codex 'all clear' comments in CI check (#81)
## Problem When Codex reviews a PR and doesn't find any issues, it leaves a regular comment: > Codex Review: Didn't find any major issues. Delightful! The current `check_codex_comments.sh` script treats **all** regular Codex comments as blocking, including these "all clear" messages. This caused PR #80 to be blocked even though Codex approved it. ## Solution Filter out Codex comments that contain "Didn't find any major issues" so they don't block the merge. ## Testing - ✅ PR #80 (has "Delightful" comment): Now passes - ✅ PR #74 (has actual review comment): Still blocks correctly ## Changes - Updated `scripts/check_codex_comments.sh` to use `jq` filter that excludes "all clear" comments - Only actionable Codex feedback will now block PRs _Generated with `cmux`_
1 parent 1c6f10a commit d7d5c18

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

scripts/check_codex_comments.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@ BOT_LOGIN_GRAPHQL="chatgpt-codex-connector" # GraphQL does not
1414
echo "Checking for unresolved Codex comments in PR #${PR_NUMBER}..."
1515

1616
# Get all regular issue comments from the Codex bot (these can't be resolved)
17+
# Filter out "all clear" comments that indicate no issues found
1718
REGULAR_COMMENTS=$(gh api "/repos/{owner}/{repo}/issues/${PR_NUMBER}/comments" \
18-
--jq "[.[] | select(.user.login == \"${BOT_LOGIN_REST}\")]")
19+
--jq "[.[] | select(.user.login == \"${BOT_LOGIN_REST}\") | select(.body | test(\"Didn't find any major issues\") | not)]")
1920

2021
REGULAR_COUNT=$(echo "$REGULAR_COMMENTS" | jq 'length')
2122

0 commit comments

Comments
 (0)