Skip to content

Commit c676e35

Browse files
authored
🤖 perf: skip code signing in merge queue to enable parallel builds (#876)
The macOS build workflow was taking 24+ minutes because code signing was enabled for `merge_group` events. This forced sequential x64+arm64 builds to avoid keychain race conditions. Since merge queue builds don't need signed artifacts (only releases do), we can safely skip signing and let both architectures build in parallel. This should cut the macOS build time roughly in half (~12 min). **Before:** [24m40s for macOS build](https://github.com/coder/mux/actions/runs/19892016638/job/57012954221) **After:** Expected ~12 min (parallel x64+arm64 builds) --- _Generated with `mux`_
1 parent 43c5f8a commit c676e35

File tree

1 file changed

+2
-24
lines changed

1 file changed

+2
-24
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -18,30 +18,8 @@ jobs:
1818

1919
- uses: ./.github/actions/setup-mux
2020

21-
# Skip signing setup for PRs - electron-builder skips signing anyway,
22-
# but setting CSC_LINK forces our Makefile to build sequentially.
23-
# Without CSC_LINK, x64 and arm64 build in parallel (~90s savings).
24-
- name: Setup code signing
25-
if: github.event_name != 'pull_request'
26-
run: ./scripts/setup-macos-signing.sh
27-
env:
28-
MACOS_CERTIFICATE: ${{ secrets.MACOS_CERTIFICATE }}
29-
MACOS_CERTIFICATE_PWD: ${{ secrets.MACOS_CERTIFICATE_PWD }}
30-
AC_APIKEY_P8_BASE64: ${{ secrets.AC_APIKEY_P8_BASE64 }}
31-
AC_APIKEY_ID: ${{ secrets.AC_APIKEY_ID }}
32-
AC_APIKEY_ISSUER_ID: ${{ secrets.AC_APIKEY_ISSUER_ID }}
33-
34-
- name: Verify signing setup
35-
if: github.event_name != 'pull_request'
36-
run: |
37-
if [ -n "${CSC_LINK:-}" ]; then
38-
echo "✅ Code signing enabled"
39-
security list-keychains -d user
40-
security find-identity -v -p codesigning
41-
else
42-
echo "⚠️ Code signing NOT enabled"
43-
fi
44-
21+
# No code signing - releases use release.yml (triggered by tag publish).
22+
# Without CSC_LINK, x64 and arm64 builds run in parallel (~12 min faster).
4523
- name: Package for macOS
4624
run: make dist-mac
4725

0 commit comments

Comments
 (0)