fix(bash): reject malformed timeout_secs

- codex would occasionally omit this parameter leading the script to
  hang indefinitely

Author: ammario

src/services/tools/bash.test.ts

@@ -597,4 +597,80 @@ describe("bash tool", () => {
       expect(result.wall_duration_ms).toBe(0);
     }
   });
+
+  it("should fail immediately when timeout_secs is undefined", async () => {
+    const tool = createBashTool({ cwd: process.cwd() });
+    const args = {
+      script: "echo hello",
+      timeout_secs: undefined,
+      max_lines: 100,
+    };
+
+    const result = (await tool.execute!(args, mockToolCallOptions)) as BashToolResult;
+
+    expect(result.success).toBe(false);
+    if (!result.success) {
+      expect(result.error).toContain("timeout_secs parameter is missing or invalid");
+      expect(result.error).toContain("malformed tool call");
+      expect(result.exitCode).toBe(-1);
+      expect(result.wall_duration_ms).toBe(0);
+    }
+  });
+
+  it("should fail immediately when timeout_secs is null", async () => {
+    const tool = createBashTool({ cwd: process.cwd() });
+    const args = {
+      script: "echo hello",
+      timeout_secs: null as unknown as number,
+      max_lines: 100,
+    };
+
+    const result = (await tool.execute!(args, mockToolCallOptions)) as BashToolResult;
+
+    expect(result.success).toBe(false);
+    if (!result.success) {
+      expect(result.error).toContain("timeout_secs parameter is missing or invalid");
+      expect(result.error).toContain("malformed tool call");
+      expect(result.exitCode).toBe(-1);
+      expect(result.wall_duration_ms).toBe(0);
+    }
+  });
+
+  it("should fail immediately when timeout_secs is zero", async () => {
+    const tool = createBashTool({ cwd: process.cwd() });
+    const args: BashToolArgs = {
+      script: "echo hello",
+      timeout_secs: 0,
+      max_lines: 100,
+    };
+
+    const result = (await tool.execute!(args, mockToolCallOptions)) as BashToolResult;
+
+    expect(result.success).toBe(false);
+    if (!result.success) {
+      expect(result.error).toContain("timeout_secs parameter is missing or invalid");
+      expect(result.error).toContain("malformed tool call");
+      expect(result.exitCode).toBe(-1);
+      expect(result.wall_duration_ms).toBe(0);
+    }
+  });
+
+  it("should fail immediately when timeout_secs is negative", async () => {
+    const tool = createBashTool({ cwd: process.cwd() });
+    const args: BashToolArgs = {
+      script: "echo hello",
+      timeout_secs: -5,
+      max_lines: 100,
+    };
+
+    const result = (await tool.execute!(args, mockToolCallOptions)) as BashToolResult;
+
+    expect(result.success).toBe(false);
+    if (!result.success) {
+      expect(result.error).toContain("timeout_secs parameter is missing or invalid");
+      expect(result.error).toContain("malformed tool call");
+      expect(result.exitCode).toBe(-1);
+      expect(result.wall_duration_ms).toBe(0);
+    }
+  });
 });

src/services/tools/bash.ts

@@ -56,6 +56,17 @@ export const createBashTool: ToolFactory = (config: ToolConfiguration) => {
         };
       }
 
+      // Validate timeout_secs is present and valid
+      if (timeout_secs === undefined || timeout_secs === null || timeout_secs <= 0) {
+        return {
+          success: false,
+          error:
+            "timeout_secs parameter is missing or invalid. This likely indicates a malformed tool call.",
+          exitCode: -1,
+          wall_duration_ms: 0,
+        };
+      }
+
       const startTime = performance.now();
       const normalizedMaxLines = Math.max(1, Math.floor(max_lines));
       const effectiveMaxLines = Math.min(normalizedMaxLines, BASH_HARD_MAX_LINES);