feat(pkg/commands): add support for build secrets #30
+379
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Oct 18, 2024
mafredri
reviewed
Oct 23, 2024
Member
mafredri
left a comment
mafredri
left a comment
There was a problem hiding this comment.
Congrats on diving into Kaniko and nice work implementing this!
mafredri
reviewed
Oct 24, 2024
Member
mafredri
left a comment
mafredri
left a comment
There was a problem hiding this comment.
A few remaining suggestions and I think testing could be improved a bit but otherwise it's looking good.
mafredri
approved these changes
Oct 25, 2024
Member
mafredri
left a comment
mafredri
left a comment
There was a problem hiding this comment.
Looks good, a few minor things still, but once those are fixed this is ready to go!
johnstcn
approved these changes
Oct 25, 2024
Member
johnstcn
left a comment
johnstcn
left a comment
There was a problem hiding this comment.
Nice work! I don't have anything that Mathias hasn't already pointed out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for build secrets to kaniko. Because the --secret flag is not available to
docker run, it sources them from environment variables prefixed with KANIKO_BUILD_SECRET.These build secrets are also accessible in the kaniko options struct. A PR is inbound to provide them and make this feature available from envbuilder.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.