Skip to content

Commit d5a3b19

Browse files
authored
fix(images/base): work around broken packagekit on armv7 (#293)
- Modifies git-core PPA installation method to avoid requirement for software-properties-common - Skips installing software-properties-common on armhf dpkg architecture due to dependency issues
1 parent 96893e5 commit d5a3b19

File tree

2 files changed

+51
-2
lines changed

2 files changed

+51
-2
lines changed
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
Types: deb
2+
URIs: https://ppa.launchpadcontent.net/git-core/ppa/ubuntu/
3+
Suites: noble
4+
Components: main
5+
Signed-By:
6+
-----BEGIN PGP PUBLIC KEY BLOCK-----
7+
.
8+
mQINBGYo2OYBEADVRjI+o29u9izslaVr0Xqj8hpmo/2su/Iey1PgoS6A3hMxR4R4
9+
eZ3u9dRh/gRHXNjxqRMfKj88G6ciqa/7ty8Vfc1eKl3z7yjL1pWOEzcGLKaSB8qd
10+
MmsxCw31nFNEbzlymgK0+KPubQ5OrIzeSikpfDVGT4HLgO42ppGY+cVy2/bbNv6O
11+
mmPXcw8gkxRCWFiGAO5jJYG1SyGbhr9Krbf6o+LDUJeDYPTQRMf702IYZ8Bp00ix
12+
HyK2YOUNM14rr7092o2dw9GKxnJszF4cET+LxRddrREuB3sBlAZav/I0hZtQsKZ3
13+
QTvpStf2MwIy8Ymj94+BsZaktP0d36wigGn8RWJHrhSVyjujS8YxWRWdjrLUI1ra
14+
42pyIYZi39IXtsTM71rihQVrsEHbMQ7a5HGRK6eYyHVPrtsXXykNqhVPekLNiFWm
15+
IekoSH1EwMsQv8y+k3nkCwTCkTHJaueB7awee0Zs5QBwbCm+qPyqCXoVDLEwdQOr
16+
CHKAfNADtsFQsk/yiTC/+Lmtur/okp38VpJWXg8DphHFjd1KwqQ5E9qZi+tXs/JD
17+
UXd93VBUdoGGaHK9fj/URxUBOVopGaOXGVYtGFWPn9q8MaNcrESZ48sXDfsVgUVD
18+
RJ4puKLHjIUtDlCnMQO6lekIhEo4sxtbDnwIUmQp7B9l+U99u+uzBI96cQARAQAB
19+
tChMYXVuY2hwYWQgUFBBIGZvciBVYnVudHUgR2l0IE1haW50YWluZXJziQJOBBMB
20+
CgA4FiEE+RGrGEMXYwxZlwlz42PJD48bYhcFAmYo2OYCGwMFCwkIBwIGFQoJCAsC
21+
BBYCAwECHgECF4AACgkQ42PJD48bYhdwUQ//UFR3i/6zpizJMTA9mpz7hGC9IJV8
22+
UDoWoaVgl+OR1Ldfz+jvr3K55LZyIMU1o6bbLqbEnoWa2VpRv2za/SCbPqo1igio
23+
p97EJ2irGytFOhCDd+o3s0djfsXpA7jygAK6COnMx3ejnPhaBA194HbYDhp7KA5b
24+
gZcqvYeRN1qk9QL99voFYeUWAPnqkLLrNuAcq9qTotmyYZQI61rdAH8P4odgMtU7
25+
UiS4yLirkAiNCqT+TK07EXvaWSXcqZhgt1HmP+BZhrx/vLT4FlH52CCjamQWeFA2
26+
mLKX/RSx/JTux1UDroX6L9JdUyMzOrLk22Zz9Tb3FK2ysHy72jRKmUv87ctIMcgD
27+
u8BY3Mfe/Rw8vPMuBEaAsVfvWl7uYSt81dzjkxtt6ZvIFF5PBR2IhFJVosDbpSnk
28+
g9/b22Ipjta3ULW8oOaNZjdcRNQ5StpApzZIUoZoP83ZWafwQoSrW7Rz3KvwYAdL
29+
d3OAfuiW9i7YdLCkvaujBt6KA4tn56fcsp14FzLZrgcj+7XUpW4/yEJFHCCu5f2l
30+
NWvN37suUTfzbMLZVS6rC1s3qrjOD+C3dvL/dCUlcTfrrsTcs/UnaVXFq0V6NLhA
31+
ZZxOIVUedn7nGKbaecwTt6taIjpxj0jCBxWy6RcysIkv2xluRcl2UY+HapB8x1Dx
32+
8giHUSvkXHr4c7I=
33+
=yxbG
34+
-----END PGP PUBLIC KEY BLOCK-----

images/base/ubuntu.Dockerfile

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,31 @@ RUN apt-get update && \
3030
pipx \
3131
python3 \
3232
python3-pip \
33-
software-properties-common \
33+
# software-properties-common \
3434
sudo \
3535
systemd \
3636
systemd-sysv \
3737
unzip \
3838
vim \
3939
wget \
4040
rsync && \
41+
rm -rf /var/lib/apt/lists/*
42+
43+
# Compat: on non-armv7 architectures, install `software-properties-common`
44+
RUN [[ "$(dpkg --print-architecture)" != "armhf" ]] && \
45+
( \
46+
apt-get update && \
47+
apt-get install --yes software-properties-common && \
48+
rm -rf /var/lib/apt/lists/* \
49+
) || echo "WARN: Skipping software-properties-common installation on armhf"
50+
4151
# Install latest Git using their official PPA
42-
add-apt-repository ppa:git-core/ppa && \
52+
# Note: due to a dependency issue with the armv7 `software-properties-common` package,
53+
# we can't use `add-apt-repository` here. Instead, we'll add the Git PPA
54+
# manually. TODO: remove this workaround when the issue is resolved.
55+
# Ref: https://bugs.launchpad.net/cloud-images/+bug/2091619
56+
COPY git-core-ubuntu-ppa-noble.sources /etc/apt/sources.list.d/git-core-ubuntu-ppa-noble.sources
57+
RUN apt-get update && \
4358
apt-get install --yes git \
4459
&& rm -rf /var/lib/apt/lists/*
4560

0 commit comments

Comments
 (0)