feat: make wasmPath optional with smart auto-detection #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sreya
commented
Nov 13, 2025
sreya
commented
- Make Ghostty.load() wasmPath parameter optional with intelligent fallback logic
- Try multiple default paths: import.meta.url, relative, and root paths
- Update Terminal class to remove hardcoded wasmPath default
- Simplify test code to use auto-detection
- Fix build-wasm.sh to reference coder/ghostty repository
- Improve error messages with helpful guidance
- Make Ghostty.load() wasmPath parameter optional with intelligent fallback logic - Try multiple default paths: import.meta.url, relative, and root paths - Update Terminal class to remove hardcoded wasmPath default - Simplify test code to use auto-detection - Fix build-wasm.sh to reference coder/ghostty repository - Improve error messages with helpful guidance Follows TensorFlow.js pattern for better developer experience.
sreya
force-pushed
the
feat/optional-wasm-path
branch
from
27b10a7 to
fcd774f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.