From 0163ecf66459f24e359834bc47ead37e75df9706 Mon Sep 17 00:00:00 2001
From: Yassine Doghri <yassine@doghri.fr>
Date: Sat, 22 Nov 2025 10:17:49 +0100
Subject: [PATCH 1/2] fix: extend Services class with CodeIgniter's BaseService

---
 src/Config/Services.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Config/Services.php b/src/Config/Services.php
index bc8fb68..13326dc 100644
--- a/src/Config/Services.php
+++ b/src/Config/Services.php
@@ -15,9 +15,9 @@
 
 use CodeIgniter\Tasks\CronExpression;
 use CodeIgniter\Tasks\Scheduler;
-use Config\Services as BaseServices;
+use CodeIgniter\Config\BaseService;
 
-class Services extends BaseServices
+class Services extends BaseService
 {
     /**
      * Returns the Task Scheduler

From ef9fc47471a8aaa495971d15b4e9e7b23a73b145 Mon Sep 17 00:00:00 2001
From: Yassine Doghri <yassine@doghri.fr>
Date: Sat, 22 Nov 2025 21:51:40 +0000
Subject: [PATCH 2/2] chore: remove BooleanInIfConditionRuleFixerRector rector
 rule + run cs-fix

---
 rector.php              | 2 --
 src/Config/Services.php | 2 +-
 src/RunResolver.php     | 2 +-
 src/Task.php            | 2 +-
 4 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/rector.php b/rector.php
index e824476..9736338 100644
--- a/rector.php
+++ b/rector.php
@@ -48,7 +48,6 @@
 use Rector\Set\ValueObject\LevelSetList;
 use Rector\Set\ValueObject\SetList;
 use Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector;
-use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
 use Rector\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;
 use Rector\ValueObject\PhpVersion;
@@ -161,7 +160,6 @@
     $rectorConfig->rule(StringClassNameToClassConstantRector::class);
     $rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
     $rectorConfig->rule(CompleteDynamicPropertiesRector::class);
-    $rectorConfig->rule(BooleanInIfConditionRuleFixerRector::class);
     $rectorConfig->rule(SingleInArrayToCompareRector::class);
     $rectorConfig->rule(VersionCompareFuncCallToConstantRector::class);
     $rectorConfig->rule(ExplicitBoolCompareRector::class);
diff --git a/src/Config/Services.php b/src/Config/Services.php
index 13326dc..60531a4 100644
--- a/src/Config/Services.php
+++ b/src/Config/Services.php
@@ -13,9 +13,9 @@
 
 namespace CodeIgniter\Tasks\Config;
 
+use CodeIgniter\Config\BaseService;
 use CodeIgniter\Tasks\CronExpression;
 use CodeIgniter\Tasks\Scheduler;
-use CodeIgniter\Config\BaseService;
 
 class Services extends BaseService
 {
diff --git a/src/RunResolver.php b/src/RunResolver.php
index e9d24f5..1eb22ac 100644
--- a/src/RunResolver.php
+++ b/src/RunResolver.php
@@ -151,7 +151,7 @@ protected function isInList($value, string $list): bool
     {
         $list = explode(',', $list);
 
-        return in_array(trim($value), $list, true);
+        return in_array(trim((string) $value), $list, true);
     }
 
     /**
diff --git a/src/Task.php b/src/Task.php
index b1b2cb6..9cd2bc1 100644
--- a/src/Task.php
+++ b/src/Task.php
@@ -365,7 +365,7 @@ protected function buildName()
      */
     public function __get(string $key)
     {
-        if ($key === 'name' && empty($this->name)) {
+        if ($key === 'name' && (! isset($this->name) || ($this->name === ''))) {
             return $this->buildName();
         }