-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: added async & persistent options to Cache Redis
#9792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ddevsr
wants to merge
7
commits into
codeigniter4:4.7
Choose a base branch
from
ddevsr:cache-redis-persistent
base: 4.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e0b000d
feat: added async & persistent options to cache predis
ddevsr edbca16
docs: update sample config
ddevsr d76a6a6
refactor: phpdocs on cache
ddevsr 0d161b5
feat: redis can used persistent
ddevsr 2c7767b
docs: added support persistent redis option
ddevsr c534e0a
run cs-fixer
ddevsr 99c71e0
docs: notes async option only used by Predis
ddevsr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -75,6 +75,8 @@ Libraries | |||||||||
|
|
||||||||||
| - **API Transformers:** This new feature provides a structured way to transform data for API responses. See :ref:`API Transformers <api_transformers>` for details. | ||||||||||
| - **CLI:** Added ``SignalTrait`` to provide unified handling of operating system signals in CLI commands. | ||||||||||
| - **Cache:** Added ``async`` and ``persistent`` config item to predis handler. | ||||||||||
| - **Cache:** Added ``persistent`` config item to redis handler. | ||||||||||
|
Comment on lines
+78
to
+79
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| - **CURLRequest:** Added ``shareConnection`` config item to change default share connection. | ||||||||||
| - **CURLRequest:** Added ``dns_cache_timeout`` option to change default DNS cache timeout. | ||||||||||
| - **CURLRequest:** Added ``fresh_connect`` options to enable/disable request fresh connection. | ||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -9,11 +9,13 @@ class Cache extends BaseConfig | |||||
| // ... | ||||||
|
|
||||||
| public $redis = [ | ||||||
| 'host' => '127.0.0.1', | ||||||
| 'password' => null, | ||||||
| 'port' => 6379, | ||||||
| 'timeout' => 0, | ||||||
| 'database' => 0, | ||||||
| 'host' => '127.0.0.1', | ||||||
| 'password' => null, | ||||||
| 'port' => 6379, | ||||||
| 'async' => false, | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| 'persistent' => false, | ||||||
| 'timeout' => 0, | ||||||
| 'database' => 0, | ||||||
| ]; | ||||||
|
|
||||||
| // ... | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.