fix: inaccurate logtime per week in piscine overview

weeks did not properly start at 0:00 of each date and API locations were not truncated and did not allow overflowing weekly boundaries

this implementation copies 42's Chronos system's behavior and is way more accurate.

Author: FreekBes

src/handlers/piscine.ts

@@ -143,7 +143,7 @@ export const getCPiscineData = async function(prisma: PrismaClient, year: number
 	// Get logtime for each week of the piscine for each user
 	let logtimes: { [login: string]: CPiscineLogTimes } = {}
 	for (const user of users) {
-		const piscineBegin = user.cursus_users[0]?.begin_at;
+		const piscineBegin = new Date(user.cursus_users[0]?.begin_at.setHours(0, 0, 0, 0));
 		const weekTwo = new Date(piscineBegin.getTime() + 60 * 60 * 24 * 7 * 1000);
 		const weekThree = new Date(piscineBegin.getTime() + 60 * 60 * 24 * 14 * 1000);
 		const weekFour = new Date(piscineBegin.getTime() + 60 * 60 * 24 * 21 * 1000);

src/utils.ts

@@ -304,7 +304,21 @@ export const getAllCohorts = async function(prisma: PrismaClient): Promise<Cohor
  * @returns The amount of seconds spent behind a computer as an integer
  */
 export const getTimeSpentBehindComputer = function(locations: Location[], lowerBound: Date, upperBound: Date): number {
-	return locations.filter((l) => l.begin_at >= lowerBound && l.begin_at <= upperBound).reduce((acc, l) => acc + ((l.end_at ? l.end_at.getTime() : Date.now()) - l.begin_at.getTime()) / 1000, 0);
+	// Filter locations based on their begin_at and end_at. Allow overflow of locations outside the bounds.
+	const filtered = locations.filter((l) => {
+		return (l.begin_at >= lowerBound && l.begin_at <= upperBound) ||
+			(l.end_at && l.end_at >= lowerBound && l.end_at <= upperBound);
+	});
+	// Truncate the begin_ats and end_ats based on the lowerBound and upperBound
+	filtered.forEach((l) => {
+		if (l.begin_at < lowerBound) {
+			l.begin_at = lowerBound;
+		}
+		if (l.end_at && l.end_at > upperBound) {
+			l.end_at = upperBound;
+		}
+	});
+	return filtered.reduce((acc, l) => acc + ((l.end_at ? l.end_at.getTime() : Date.now()) - l.begin_at.getTime()) / 1000, 0);
 };
 
 export const getPiscineProjects = async function(prisma: PrismaClient, piscineProjectIdsOrdered: number[]): Promise<Project[]> {