Skip to content

Commit b700bf6

Browse files
author
Wei
authored
Merge pull request #163 from cloudpilot-ai/cherry-pick-157-release-0.1
Cherry pick PR(157)/chore: use SecurityGroupIds instad of SecurityGroupId for ProvisionGroup
2 parents 2d30829 + 8c8f246 commit b700bf6

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

pkg/providers/instance/instance.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -533,14 +533,10 @@ func (p *DefaultProvider) getProvisioningGroup(ctx context.Context, nodeClass *v
533533
AutoProvisioningGroupType: tea.String("instant"),
534534
LaunchConfiguration: &ecsclient.CreateAutoProvisioningGroupRequestLaunchConfiguration{
535535
// TODO: we should set image id for each instance types after alibabacloud supports
536-
ImageId: tea.String(imageID),
537-
SecurityGroupIds: securityGroupIDs,
538-
UserData: tea.String(userData),
539-
540-
// TODO: AutoProvisioningGroup is not compatible with SecurityGroupIds, waiting for Aliyun developers to fix it,
541-
// so here we only take the first one.
536+
ImageId: tea.String(imageID),
537+
UserData: tea.String(userData),
542538
ResourceGroupId: tea.String(nodeClass.Spec.ResourceGroupID),
543-
SecurityGroupId: securityGroupIDs[0],
539+
SecurityGroupIds: securityGroupIDs,
544540
SystemDiskSize: systemDisk.Size,
545541
SystemDiskPerformanceLevel: systemDisk.PerformanceLevel,
546542
Tag: reqTags,

0 commit comments

Comments
 (0)