feat(firewall_rules): remove duplicated id query parameter (#2462)

Author: stainless-app[bot]

.stats.yml

@@ -1,2 +1,2 @@
 configured_endpoints: 1542
-openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/cloudflare%2Fcloudflare-098958c3d34c1f726db27a49f075f6e8e2c9204777a0a5d6aa49ca54fc803022.yml
+openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/cloudflare%2Fcloudflare-9dd75607c8f8757910cfc7d638e1f86926406f5ea76219c4c3f9afa00eee83bb.yml

api.md

@@ -1668,7 +1668,7 @@ Methods:
 - <code title="patch /zones/{zone_id}/firewall/rules">client.firewall.rules.<a href="./src/cloudflare/resources/firewall/rules.py">bulk_edit</a>(\*, zone_id, \*\*<a href="src/cloudflare/types/firewall/rule_bulk_edit_params.py">params</a>) -> <a href="./src/cloudflare/types/firewall/firewall_rule.py">SyncSinglePage[FirewallRule]</a></code>
 - <code title="put /zones/{zone_id}/firewall/rules">client.firewall.rules.<a href="./src/cloudflare/resources/firewall/rules.py">bulk_update</a>(\*, zone_id, \*\*<a href="src/cloudflare/types/firewall/rule_bulk_update_params.py">params</a>) -> <a href="./src/cloudflare/types/firewall/firewall_rule.py">SyncSinglePage[FirewallRule]</a></code>
 - <code title="patch /zones/{zone_id}/firewall/rules/{rule_id}">client.firewall.rules.<a href="./src/cloudflare/resources/firewall/rules.py">edit</a>(rule_id, \*, zone_id) -> <a href="./src/cloudflare/types/firewall/firewall_rule.py">SyncSinglePage[FirewallRule]</a></code>
-- <code title="get /zones/{zone_id}/firewall/rules/{rule_id}">client.firewall.rules.<a href="./src/cloudflare/resources/firewall/rules.py">get</a>(rule_id, \*, zone_id, \*\*<a href="src/cloudflare/types/firewall/rule_get_params.py">params</a>) -> <a href="./src/cloudflare/types/firewall/firewall_rule.py">FirewallRule</a></code>
+- <code title="get /zones/{zone_id}/firewall/rules/{rule_id}">client.firewall.rules.<a href="./src/cloudflare/resources/firewall/rules.py">get</a>(rule_id, \*, zone_id) -> <a href="./src/cloudflare/types/firewall/firewall_rule.py">FirewallRule</a></code>
 
 ## AccessRules
 

src/cloudflare/resources/firewall/rules.py

@@ -24,7 +24,6 @@
 from ...pagination import SyncSinglePage, AsyncSinglePage, SyncV4PagePaginationArray, AsyncV4PagePaginationArray
 from ..._base_client import AsyncPaginator, make_request_options
 from ...types.firewall import (
-    rule_get_params,
     rule_list_params,
     rule_create_params,
     rule_update_params,
@@ -465,7 +464,6 @@ def get(
         rule_id: str,
         *,
         zone_id: str,
-        id: str | NotGiven = NOT_GIVEN,
         # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
         # The extra values given here take precedence over values defined on the client or passed to this method.
         extra_headers: Headers | None = None,
@@ -481,8 +479,6 @@ def get(
 
           rule_id: The unique identifier of the firewall rule.
 
-          id: The unique identifier of the firewall rule.
-
           extra_headers: Send extra headers
 
           extra_query: Add additional query parameters to the request
@@ -502,7 +498,6 @@ def get(
                 extra_query=extra_query,
                 extra_body=extra_body,
                 timeout=timeout,
-                query=maybe_transform({"id": id}, rule_get_params.RuleGetParams),
                 post_parser=ResultWrapper[FirewallRule]._unwrapper,
             ),
             cast_to=cast(Type[FirewallRule], ResultWrapper[FirewallRule]),
@@ -937,7 +932,6 @@ async def get(
         rule_id: str,
         *,
         zone_id: str,
-        id: str | NotGiven = NOT_GIVEN,
         # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
         # The extra values given here take precedence over values defined on the client or passed to this method.
         extra_headers: Headers | None = None,
@@ -953,8 +947,6 @@ async def get(
 
           rule_id: The unique identifier of the firewall rule.
 
-          id: The unique identifier of the firewall rule.
-
           extra_headers: Send extra headers
 
           extra_query: Add additional query parameters to the request
@@ -974,7 +966,6 @@ async def get(
                 extra_query=extra_query,
                 extra_body=extra_body,
                 timeout=timeout,
-                query=await async_maybe_transform({"id": id}, rule_get_params.RuleGetParams),
                 post_parser=ResultWrapper[FirewallRule]._unwrapper,
             ),
             cast_to=cast(Type[FirewallRule], ResultWrapper[FirewallRule]),

src/cloudflare/types/firewall/__init__.py

@@ -8,7 +8,6 @@
 from .configuration import Configuration as Configuration
 from .firewall_rule import FirewallRule as FirewallRule
 from .deleted_filter import DeletedFilter as DeletedFilter
-from .rule_get_params import RuleGetParams as RuleGetParams
 from .rule_list_params import RuleListParams as RuleListParams
 from .asn_configuration import ASNConfiguration as ASNConfiguration
 from .ipv6_configuration import IPV6Configuration as IPV6Configuration

src/cloudflare/types/firewall/rule_get_params.py

@@ -520,17 +520,6 @@ def test_method_get(self, client: Cloudflare) -> None:
 
         assert_matches_type(FirewallRule, rule, path=["response"])
 
-    @parametrize
-    def test_method_get_with_all_params(self, client: Cloudflare) -> None:
-        with pytest.warns(DeprecationWarning):
-            rule = client.firewall.rules.get(
-                rule_id="372e67954025e0ba6aaa6d586b9e0b60",
-                zone_id="023e105f4ecef8ad9ca31a8372d0c353",
-                id="372e67954025e0ba6aaa6d586b9e0b60",
-            )
-
-        assert_matches_type(FirewallRule, rule, path=["response"])
-
     @parametrize
     def test_raw_response_get(self, client: Cloudflare) -> None:
         with pytest.warns(DeprecationWarning):
@@ -1076,17 +1065,6 @@ async def test_method_get(self, async_client: AsyncCloudflare) -> None:
 
         assert_matches_type(FirewallRule, rule, path=["response"])
 
-    @parametrize
-    async def test_method_get_with_all_params(self, async_client: AsyncCloudflare) -> None:
-        with pytest.warns(DeprecationWarning):
-            rule = await async_client.firewall.rules.get(
-                rule_id="372e67954025e0ba6aaa6d586b9e0b60",
-                zone_id="023e105f4ecef8ad9ca31a8372d0c353",
-                id="372e67954025e0ba6aaa6d586b9e0b60",
-            )
-
-        assert_matches_type(FirewallRule, rule, path=["response"])
-
     @parametrize
     async def test_raw_response_get(self, async_client: AsyncCloudflare) -> None:
         with pytest.warns(DeprecationWarning):