Skip to content

updated quote def to quote column_name and schema.table identifiers #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ksirmons wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated quote def to quote column_name and schema.table identifiers #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbt/adapters/impala/impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def convert_text_type(cls, agate_table: agate.Table, col_idx: int) -> str:
return "string"

def quote(self, identifier):
return identifier # no quote
return ".".join(f"`{part}`" for part in identifier.split('.'))

@classmethod
def convert_number_type(cls, agate_table: agate.Table, col_idx: int) -> str:
Expand Down