Remove multiple-value-foreign-call special operator

Fewer cleavir special operators means fewer bytecode
incompatibilities. And this operator has only been used in the
ERROR compiler macros for a while now, so it's no great loss.
If we really need to we can do something similar by defining
intrinsic primops and etc.

Author: Bike

src/lisp/kernel/cleavir/ast.lisp

@@ -42,22 +42,6 @@
 
 (ast:define-children base-foreign-call-ast argument-asts)
 
-;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
-;;;
-;;; Class MULTIPLE-VALUE-FOREIGN-CALL-AST
-;;;
-;;; This AST is used to represent a call to an intrinsic function inserted into the generated code.
-
-(defclass multiple-value-foreign-call-ast (base-foreign-call-ast)
-  ((%function-name :initarg :function-name  :accessor function-name)))
-
-(cleavir-io:define-save-info multiple-value-foreign-call-ast
-    (:function-name function-name))
-
-(defmethod cleavir-ast-graphviz::label ((ast multiple-value-foreign-call-ast))
-  (with-output-to-string (s)
-    (format s "multiple-value-foreign-call (~a)" (function-name ast))))
-
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;;;
 ;;; Class foreign-call-pointer-AST

src/lisp/kernel/cleavir/bir.lisp

@@ -1,18 +1,5 @@
 (in-package #:cc-bir)
 
-(defclass mv-foreign-call (bir:one-output bir:instruction)
-  ((%function-name :initarg :function-name :reader function-name)))
-
-(defmethod ast-to-bir:compile-ast
-    ((ast cc-ast:multiple-value-foreign-call-ast) inserter system)
-  (ast-to-bir:with-compiled-arguments (args (cc-ast:argument-asts ast)
-                                            inserter system)
-    (let ((output (make-instance 'bir:output)))
-      (build:insert inserter 'mv-foreign-call
-                    :function-name (cc-ast:function-name ast)
-                    :inputs args :outputs (list output))
-      (list output))))
-
 (defclass foreign-call-pointer (bir:one-output bir:instruction)
   ((%foreign-types :initarg :foreign-types :accessor foreign-types)))
 

src/lisp/kernel/cleavir/convert-special.lisp

@@ -238,22 +238,6 @@
                                     env system)
                                    :origin origin :policy policy))))))))
 
-;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
-;;;
-;;; Converting CORE:multiple-value-foreign-CALL
-;;;
-;;; This is converted into an intrinsic call
-;;;
-
-(defmethod cst-to-ast:convert-special
-    ((symbol (eql 'core:multiple-value-foreign-call)) cst environment
-     (system clasp-cleavir:clasp))
-  (assert (stringp (cst:raw (cst:second cst))))
-  (make-instance 'clasp-cleavir-ast:multiple-value-foreign-call-ast
-    :function-name (cst:raw (cst:second cst))
-    :argument-asts (cst-to-ast::convert-sequence (cst:rest (cst:rest cst)) environment system)
-    :origin cst))
-
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;;;
 ;;; Converting CORE:foreign-call-pointer

src/lisp/kernel/cleavir/ir.lisp

@@ -170,22 +170,6 @@ And convert everything to JIT constants."
                              cmp::*current-unwind-landing-pad-dest*
                              label)))
 
-(defun unsafe-multiple-value-foreign-call (intrinsic-name args abi
-                                           &key (label ""))
-  (declare (ignore abi))
-  (let* ((func (or (llvm-sys:get-function cmp:*the-module* intrinsic-name)
-                   (let ((arg-types (make-list (length args) :initial-element cmp:%t*%))
-                         (varargs nil))
-                     (cmp:irc-function-create
-                      (llvm-sys:function-type-get cmp:%return-type% arg-types varargs)
-                      'llvm-sys::external-linkage
-                      intrinsic-name
-                      cmp:*the-module*))))
-         (function-type (llvm-sys:get-function-type func)))
-    (cmp::irc-call-or-invoke function-type func args
-                             cmp::*current-unwind-landing-pad-dest*
-                             label)))
-
 (defun unsafe-foreign-call (call-or-invoke foreign-types foreign-name args abi &key (label ""))
   (declare (ignore call-or-invoke abi label))
   ;; Write excess arguments into the multiple-value array

src/lisp/kernel/cleavir/packages.lisp

@@ -24,7 +24,6 @@
    #:*debug-cleavir*
    #:*debug-cleavir-literals*
    #+stealth-gids :instruction-gid
-   #:unsafe-multiple-value-foreign-call
    #:unsafe-foreign-call
    #:unsafe-foreign-call-pointer
    #:datum-gid
@@ -46,11 +45,9 @@
   (:local-nicknames (#:ast #:cleavir-ast))
   (:use #:common-lisp)
   (:export
-   #:multiple-value-foreign-call-ast
    #:foreign-call-ast
    #:foreign-call-pointer-ast
    #:argument-asts
-   #:function-name
    #:foreign-types
    #:make-throw-ast
    #:throw-ast
@@ -67,7 +64,6 @@
                     (#:build #:cleavir-bir-builder))
   (:export #:header-stamp-case
            #:foreign-call-pointer #:foreign-types
-           #:mv-foreign-call #:function-name
            #:atomic #:order))
 
 (defpackage #:cc-bir-to-bmir

src/lisp/kernel/cleavir/representation-selection.lisp

@@ -112,8 +112,6 @@
   '(:vaslist))
 (defmethod %definition-rtype ((inst cc-vaslist:butlast) (datum bir:datum))
   '(:vaslist))
-(defmethod %definition-rtype ((inst cc-bir:mv-foreign-call) (datum bir:datum))
-  :multiple-values)
 (defmethod %definition-rtype ((inst bir:thei) (datum bir:datum))
   ;; THEI really throws a wrench in some stuff.
   (definition-rtype (bir:input inst)))
@@ -709,9 +707,6 @@
            (maybe-cast-before instruction args target))
           (t (insert-mtf-before instruction args target))))
   (cast-local-call-output instruction))
-(defmethod insert-casts ((instruction cc-bir:mv-foreign-call))
-  (object-inputs instruction)
-  (cast-output instruction :multiple-values))
 (defmethod insert-casts ((instruction bir:values-save))
   (let* ((input (bir:input instruction)) (output (bir:output instruction))
          (inputrt (cc-bmir:rtype input)) (outputrt (cc-bmir:rtype output)))

src/lisp/kernel/cleavir/sbcl-workbench.lisp

@@ -10,7 +10,6 @@
                        #:multiple-value-funcall
                        #:multiple-value-prog1-function
                        #:debug-message
-                       #:multiple-value-foreign-call
                        #:foreign-call
                        #:foreign-call-pointer
                        #:catch-function

src/lisp/kernel/cleavir/setup.lisp

@@ -185,7 +185,6 @@
     ;; with macros.
     ((member name '(catch throw progv)) nil)
     ((special-operator-p name) t)
-    ((eq name 'core:multiple-value-foreign-call) t) ;; Call intrinsic functions
     ((eq name 'core:foreign-call-pointer) t) ;; Call function pointers
     ((eq name 'core::primop) t)
     ((eq (symbol-package name) (find-package :cleavir-primop)) t)

src/lisp/kernel/cleavir/translate.lisp

@@ -1076,15 +1076,6 @@
      (closure-call-or-invoke fun rargs :label label)
      output)))
 
-(defmethod translate-simple-instruction ((instruction cc-bir:mv-foreign-call)
-                                         abi)
-  (let ((output (bir:output instruction)))
-    (out (unsafe-multiple-value-foreign-call
-          (cc-bir:function-name instruction)
-          (mapcar #'in (bir:inputs instruction)) abi
-          :label (datum-name-as-string output))
-         output)))
-
 (defmethod translate-simple-instruction
     ((instruction cc-bir:foreign-call-pointer) abi)
   (let ((inputs (bir:inputs instruction)))