Merge pull request #1644 from clasp-developers/smart-ptr-cleanup

Mostly deleting a lot of dead code. Also leverages fancy template stuff to make smart pointers a little smarter.

Notably you can now use operator[] on smart pointers if their underlying _O type has an operator[]. This also works with begin and end, so you can use smart pointers in e.g. range for statements.

Author: Bike

include/clasp/asttooling/otherPackageClasses.h

@@ -470,17 +470,15 @@ struct property_registration : registration {
     using VariadicGetterType = WRAPPER_Getter<reg::null_type, Class, Get>;
     core::SimpleFun_sp entryPoint = makeSimpleFunAndFunctionDescription<VariadicGetterType>(sym);
     maybe_register_symbol_using_dladdr((void*)VariadicGetterType::entry_point);
-    auto raw_getter = gc::GC<VariadicGetterType>::allocate(entryPoint, get);
-    core::BuiltinClosure_sp getter = gc::As<core::BuiltinClosure_sp>(raw_getter);
+    auto getter = gc::GC<VariadicGetterType>::allocate(entryPoint, get);
     lisp_defineSingleDispatchMethod(sym, classSymbol, getter, 0, true, m_arguments, m_declares,
                                     m_doc_string, true, 1);
     core::T_sp setf_name = core::Cons_O::createList(cl::_sym_setf, sym);
     using VariadicSetterType = WRAPPER_Setter<reg::null_type, Class, Set>;
     core::SimpleFun_sp setterEntryPoint =
         makeSimpleFunAndFunctionDescription<VariadicSetterType>(setf_name);
     maybe_register_symbol_using_dladdr((void*)VariadicSetterType::entry_point);
-    auto raw_setter = gc::GC<VariadicSetterType>::allocate(setterEntryPoint, set);
-    core::BuiltinClosure_sp setter = gc::As<core::BuiltinClosure_sp>(raw_setter);
+    auto setter = gc::GC<VariadicSetterType>::allocate(setterEntryPoint, set);
     lisp_defineSingleDispatchMethod(setf_name, classSymbol, setter, 1, true, m_arguments, m_declares,
                                     m_doc_string, true, 2);
     //                printf("%s:%d - allocated a getter@%p for %s\n", __FILE__, __LINE__, getter, name);

include/clasp/cffi-old/otherPackageClasses.h

@@ -58,6 +58,7 @@ THE SOFTWARE.
 #include <clasp/core/object.h>
 #include <clasp/core/instance.h>
 #include <clasp/core/numbers.h>
+#include <clasp/core/symbol.h>
 #include <clasp/clbind/class_registry.h>
 #include <clasp/clbind/primitives.h>
 #include <clasp/clbind/typeid.h>

include/clasp/clbind/class.h

@@ -38,4 +38,3 @@ THE SOFTWARE.
 #include <clasp/clbind/derivable.h>
 #include <clasp/clbind/derivable_class.h>
 #include <clasp/clbind/clbind_wrappers.h>
-#include <clasp/clbind/clbind_taggedCast.h>