Skip to content

Commit dc78bc1

Browse files
committed
refactor(ci): consolidate validation into test matrix for consistency
Reorganized the GitHub workflow to run documentation validation within the test job matrix instead of as a separate job. This ensures validation and tests run in identical environments. Changes: - Removed separate validate-docs job (was using mise-action@v2 with v2025.1.6) - Added validation step within test job (uses mise-action@v3 with v2025.11.2) - Validation now runs for all PostgreSQL versions (17, 16, 15, 14) This eliminates the environment mismatch that was causing validation to fail while tests passed. Both now use the same mise version, setup, and PostgreSQL configuration.
1 parent 034a780 commit dc78bc1

File tree

1 file changed

+5
-23
lines changed

1 file changed

+5
-23
lines changed

.github/workflows/test-eql.yml

Lines changed: 5 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -26,31 +26,9 @@ defaults:
2626
shell: bash -l {0}
2727

2828
jobs:
29-
validate-docs:
30-
name: "Validate SQL Documentation"
31-
runs-on: ubuntu-latest-m
32-
33-
steps:
34-
- uses: actions/checkout@v4
35-
36-
- uses: jdx/mise-action@v2
37-
with:
38-
version: 2025.1.6
39-
install: true
40-
cache: true
41-
42-
- name: Setup database
43-
run: |
44-
mise run postgres:up --extra-args "--detach --wait"
45-
46-
- name: Validate SQL documentation
47-
run: |
48-
mise run docs:validate
49-
5029
test:
51-
name: "Test EQL SQL components"
30+
name: "Test & Validate EQL (Postgres ${{ matrix.postgres-version }})"
5231
runs-on: ubuntu-latest-m
53-
needs: validate-docs
5432

5533
strategy:
5634
fail-fast: false
@@ -73,6 +51,10 @@ jobs:
7351
run: |
7452
mise run postgres:up postgres-${POSTGRES_VERSION} --extra-args "--detach --wait"
7553
54+
- name: Validate SQL documentation (Postgres ${{ matrix.postgres-version }})
55+
run: |
56+
mise run docs:validate
57+
7658
- name: Test EQL for Postgres ${{ matrix.postgres-version }}
7759
run: |
7860
export active_rust_toolchain=$(rustup show active-toolchain | cut -d' ' -f1)

0 commit comments

Comments
 (0)