fix: fixed request error with header (#7)

Author: chrisleekr

.gitlab-ci.yml

@@ -166,29 +166,29 @@ publish-dev-docker:
 #     - echo "//${CI_SERVER_HOST}/api/v4/projects/${CI_PROJECT_ID}/packages/npm/:_authToken=${CI_JOB_TOKEN}" >> .npmrc
 #     - semantic-release
 
-# publish-tag-docker:
-#   stage: release
-#   <<: *main_branch
-#   needs:
-#     - semantic-release
-#   image: docker:27-dind
-#   services:
-#     - name: docker:27-dind
-#       alias: docker
-#   variables:
-#     DOCKER_HOST: tcp://docker:2376
-#     DOCKER_TLS_CERTDIR: '/certs'
-#     DOCKER_TLS_VERIFY: 1
-#     DOCKER_CERT_PATH: '$DOCKER_TLS_CERTDIR/client'
-#   before_script: *before_script_docker
-#   script:
-#     - apk add --no-cache git
-#     - git pull origin main
-#     - PACKAGE_VERSION=$(grep -m1 version package.json | cut -c 15- | rev | cut
-#       -c 3- | rev)
-#     - GIT_HASH=$(git rev-parse --short HEAD)
-#     - docker buildx build --progress plain --platform linux/amd64,linux/arm64
-#       --allow network.host --provenance false
-#       --build-arg PACKAGE_VERSION=$PACKAGE_VERSION --build-arg GIT_HASH=$GIT_HASH
-#       --build-arg NODE_ENV=production --target production --pull --tag
-#       $CI_REGISTRY/chrisleekr/${CI_PROJECT_NAME}:${PACKAGE_VERSION} --push .
+publish-tag-docker:
+  stage: release
+  <<: *main_branch
+  # needs:
+  #   - semantic-release
+  image: docker:27-dind
+  services:
+    - name: docker:27-dind
+      alias: docker
+  variables:
+    DOCKER_HOST: tcp://docker:2376
+    DOCKER_TLS_CERTDIR: "/certs"
+    DOCKER_TLS_VERIFY: 1
+    DOCKER_CERT_PATH: "$DOCKER_TLS_CERTDIR/client"
+  before_script: *before_script_docker
+  script:
+    - apk add --no-cache git
+    - git pull origin main
+    - PACKAGE_VERSION=$(grep -m1 version package.json | cut -c 15- | rev | cut
+      -c 3- | rev)
+    - GIT_HASH=$(git rev-parse --short HEAD)
+    - docker buildx build --progress plain --platform linux/amd64,linux/arm64
+      --allow network.host --provenance false
+      --build-arg PACKAGE_VERSION=$PACKAGE_VERSION --build-arg GIT_HASH=$GIT_HASH
+      --build-arg NODE_ENV=production --target production --pull --tag
+      $CI_REGISTRY/chrisleekr/${CI_PROJECT_NAME}:${PACKAGE_VERSION} --push .

src/core/server/auth/handlers.ts

@@ -80,6 +80,7 @@ export function setupAuthHandlers(app: Application): void {
 
       res.setHeader('Content-Type', 'application/json');
       res.status(200).json(metadata);
+      return;
     }
   );
 
@@ -91,6 +92,7 @@ export function setupAuthHandlers(app: Application): void {
 
       res.setHeader('Content-Type', 'application/json');
       res.status(200).json(metadata);
+      return;
     }
   );
 
@@ -100,6 +102,7 @@ export function setupAuthHandlers(app: Application): void {
 
     res.setHeader('Content-Type', 'application/json');
     res.status(200).json(response);
+    return;
   });
 
   app.get('/oauth/authorize', async (req: Request, res: Response) => {
@@ -108,6 +111,7 @@ export function setupAuthHandlers(app: Application): void {
     const response = await oauthService.handleAuthorization(request);
 
     res.redirect(response.redirectUrl);
+    return;
   });
 
   app.post('/oauth/token', async (req: Request, res: Response) => {
@@ -116,6 +120,7 @@ export function setupAuthHandlers(app: Application): void {
 
     res.setHeader('Content-Type', 'application/json');
     res.status(200).json(response);
+    return;
   });
 
   app.post('/oauth/revoke', async (req: Request, res: Response) => {
@@ -124,12 +129,14 @@ export function setupAuthHandlers(app: Application): void {
 
     res.setHeader('Content-Type', 'application/json');
     res.status(200).json(response);
+    return;
   });
 
   app.get('/oauth/stats', async (_req: Request, res: Response) => {
     const response = await oauthService.getStats();
     res.setHeader('Content-Type', 'application/json');
     res.status(200).json(response);
+    return;
   });
 
   oauthService.setupHandlers(app);

src/core/server/auth/services/providers/auth0.ts

@@ -371,6 +371,7 @@ export class Auth0Provider {
         req.query as Record<string, string>
       );
       res.redirect(response.redirectUrl);
+      return;
     });
 
     loggingContext.log('info', 'Auth0 handlers setup complete');

src/core/server/http/handlers.ts

@@ -14,6 +14,7 @@ export function setupRequestHandlers(
 ): void {
   app.get('/', (_req, res) => {
     res.send('Hello MCP Server');
+    return;
   });
 
   setupPingHandler(app);

src/core/server/http/handlers/mcpDelete.ts

@@ -46,7 +46,6 @@ export function setupMCPDeleteHandler(
         loggingContext.log('info', 'Session terminated', {
           data: { sessionId },
         });
-        res.status(200).json({ message: 'Session terminated' }); // Return 200 to gracefully handle the request
       } catch (error: unknown) {
         loggingContext.log('error', 'Error handling DELETE request', {
           data: {
@@ -57,6 +56,7 @@ export function setupMCPDeleteHandler(
           },
         });
         res.status(500).json({ error: 'Internal server error' });
+        return;
       }
     })();
   });

src/core/server/http/handlers/mcpPost.ts

@@ -76,6 +76,7 @@ export function setupMCPPostHandler(
         }
 
         await transport.handleRequest(req, res, requestBody);
+        return;
       } catch (error) {
         loggingContext.log('error', 'Error handling HTTP request', {
           data: {
@@ -86,6 +87,7 @@ export function setupMCPPostHandler(
           },
         });
         res.status(500).json({ error: 'Internal server error' });
+        return;
       }
     })();
   });

src/core/server/http/handlers/ping.ts

@@ -3,5 +3,6 @@ import express from 'express';
 export function setupPingHandler(app: express.Application): void {
   app.get('/ping', (_req, res) => {
     res.send('pong');
+    return;
   });
 }