You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At this point the local clone of your fork only knows that it came from *your* repo, github.com/USERNAME/ccat-api-py.git, but doesn't know anything the *main* repo, [https://github.com/cheshire-cat-ai/ccat-api-py.git](https://github.com/cheshire-cat-ai/ccat-api-py). You can see this by running
50
+
At this point the local clone of your fork only knows that it came from *your* repo, github.com/USERNAME/cheshire-cat-api.git, but doesn't know anything the *main* repo, [https://github.com/cheshire-cat-ai/cheshire-cat-api.git](https://github.com/cheshire-cat-ai/cheshire-cat-api). You can see this by running
This means that your local clone can only track changes from your fork, but not from the main repo, and so you won't be able to keep your fork up-to-date with the main repo over time. Therefore you'll need to add another "remote" to your clone that points to [https://github.com/cheshire-cat-ai/ccat-api-py.git](https://github.com/cheshire-cat-ai/ccat-api-py). To do this, run the following:
59
+
This means that your local clone can only track changes from your fork, but not from the main repo, and so you won't be able to keep your fork up-to-date with the main repo over time. Therefore you'll need to add another "remote" to your clone that points to [https://github.com/cheshire-cat-ai/cheshire-cat-api.git](https://github.com/cheshire-cat-ai/cheshire-cat-api). To do this, run the following:
Finally, you'll need to create a Python 3 virtual environment suitable for working on this project. There a number of tools out there that making working with virtual environments easier.
71
71
The most direct way is with the [`venv` module](https://docs.python.org/3.7/library/venv.html) in the standard library, but if you're new to Python or you don't already have a recent Python 3 version installed on your machine,
@@ -77,7 +77,7 @@ When you're ready to contribute code to address an open issue, please follow the
77
77
78
78
Then you can create and activate a new Python environment by running:
79
79
80
-
conda create -n ccat-api python=3.9
80
+
conda create -n ccat-api python=3.10
81
81
conda activate ccat-api
82
82
83
83
Once your virtual environment is activated, you can install your local clone in "editable mode" with
@@ -93,7 +93,7 @@ When you're ready to contribute code to address an open issue, please follow the
93
93
94
94
<details><summary>Expand details 👇</summary><br/>
95
95
96
-
Once you've added an "upstream" remote pointing to [https://github.com/allenai/python-package-temlate.git](https://github.com/cheshire-cat-ai/ccat-api-py), keeping your fork up-to-date is easy:
96
+
Once you've added an "upstream" remote pointing to [this repo](https://github.com/cheshire-cat-ai/cheshire-cat-api), keeping your fork up-to-date is easy:
97
97
98
98
git checkout main # if not already on main
99
99
git pull --rebase upstream main
@@ -119,25 +119,25 @@ When you're ready to contribute code to address an open issue, please follow the
119
119
120
120
<details><summary>Expand details 👇</summary><br/>
121
121
122
-
Our continuous integration (CI) testing runs [a number of checks](https://github.com/cheshire-cat-ai/ccat-api-py/actions) for each pull request on [GitHub Actions](https://github.com/features/actions). You can run most of these tests locally, which is something you should do *before* opening a PR to help speed up the review process and make it easier for us.
122
+
Our continuous integration (CI) testing runs [a number of checks](https://github.com/cheshire-cat-ai/cheshire-cat-api/actions) for each pull request on [GitHub Actions](https://github.com/features/actions). You can run most of these tests locally, which is something you should do *before* opening a PR to help speed up the review process and make it easier for us.
123
123
124
-
Our CI also uses [`flake8`](https://github.com/cheshire-cat-ai/ccat-api-py/tree/main/tests) to lint the code base and [`mypy`](http://mypy-lang.org/) for type-checking. You should run both of these next with
124
+
Our CI also uses [`flake8`](https://github.com/cheshire-cat-ai/cheshire-cat-api/tree/main/tests) to lint the code base and [`mypy`](http://mypy-lang.org/) for type-checking. You should run both of these next with
125
125
126
126
flake8 .
127
127
128
128
and
129
129
130
130
mypy .
131
131
132
-
We also strive to maintain high test coverage, so most contributions should include additions to [the unit tests](https://github.com/cheshire-cat-ai/ccat-api-py/tree/main/tests). These tests are run with [`pytest`](https://docs.pytest.org/en/latest/), which you can use to locally run any test modules that you've added or changed.
132
+
We also strive to maintain high test coverage, so most contributions should include additions to [the unit tests](https://github.com/cheshire-cat-ai/cheshire-cat-api/tree/main/tests). These tests are run with [`pytest`](https://docs.pytest.org/en/latest/), which you can use to locally run any test modules that you've added or changed.
133
133
134
-
For example, if you've fixed a bug in `ccat_api/a/b.py`, you can run the tests specific to that module with
134
+
For example, if you've fixed a bug in `cheshire-cat-api/a/b.py`, you can run the tests specific to that module with
135
135
136
136
pytest -v tests/a/b_test.py
137
137
138
138
To check the code coverage locally in this example, you could run
If your contribution involves additions to any public part of the API, we require that you write docstrings
143
143
for each function, method, class, or module that you add.
@@ -148,9 +148,9 @@ When you're ready to contribute code to address an open issue, please follow the
148
148
149
149
If the build fails, it's most likely due to small formatting issues. If the error message isn't clear, feel free to comment on this in your pull request.
150
150
151
-
And finally, please update the [CHANGELOG](https://github.com/cheshire-cat-ai/ccat-api-py/blob/main/CHANGELOG.md) with notes on your contribution in the "Unreleased" section at the top.
151
+
And finally, please update the [CHANGELOG](https://github.com/cheshire-cat-ai/cheshire-cat-api/blob/main/CHANGELOG.md) with notes on your contribution in the "Unreleased" section at the top.
152
152
153
-
After all of the above checks have passed, you can now open [a new GitHub pull request](https://github.com/cheshire-cat-ai/ccat-api-py/pulls).
153
+
After all of the above checks have passed, you can now open [a new GitHub pull request](https://github.com/cheshire-cat-ai/cheshire-cat-api/pulls).
154
154
Make sure you have a clear description of the problem and the solution, and include a link to relevant issues.
155
155
156
156
We look forward to reviewing your PR!
@@ -159,6 +159,4 @@ When you're ready to contribute code to address an open issue, please follow the
159
159
160
160
### Writing docstrings
161
161
162
-
We use [Sphinx](https://www.sphinx-doc.org/en/master/index.html) to build our API docs, which automatically parses all docstrings
163
-
of public classes and methods using the [autodoc](https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html) extension.
164
-
Please refer to autodoc's documentation to learn about the docstring syntax.
Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/bug_report.yml
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -6,7 +6,7 @@ body:
6
6
- type: markdown
7
7
attributes:
8
8
value: >
9
-
#### Before submitting a bug, please make sure the issue hasn't been already addressed by searching through [the existing and past issues](https://github.com/cheshire-cat-ai/ccat-api-py/issues?q=is%3Aissue+sort%3Acreated-desc+).
9
+
#### Before submitting a bug, please make sure the issue hasn't been already addressed by searching through [the existing and past issues](https://github.com/cheshire-cat-ai/cheshire-cat-api/issues?q=is%3Aissue+sort%3Acreated-desc+).
10
10
- type: textarea
11
11
attributes:
12
12
label: 🐛 Describe the bug
@@ -17,7 +17,7 @@ body:
17
17
18
18
```python
19
19
# All necessary imports at the beginning
20
-
import ccat_api
20
+
import cheshire_cat_api
21
21
22
22
# A succinct reproducing example trimmed down to the essential parts:
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -10,9 +10,9 @@ Changes proposed in this pull request:
10
10
## Before submitting
11
11
12
12
<!-- Please complete this checklist BEFORE submitting your PR to speed along the review process. -->
13
-
-[ ] I've read and followed all steps in the [Making a pull request](https://github.com/cheshire-cat-ai/ccat-api-py/blob/main/.github/CONTRIBUTING.md#making-a-pull-request)
13
+
-[ ] I've read and followed all steps in the [Making a pull request](https://github.com/cheshire-cat-ai/cheshire-cat-api/blob/main/.github/CONTRIBUTING.md#making-a-pull-request)
14
14
section of the `CONTRIBUTING` docs.
15
15
-[ ] I've updated or added any relevant docstrings following the syntax described in the
16
-
[Writing docstrings](https://github.com/cheshire-cat-ai/ccat-api-py/blob/main/.github/CONTRIBUTING.md#writing-docstrings) section of the `CONTRIBUTING` docs.
16
+
[Writing docstrings](https://github.com/cheshire-cat-ai/cheshire-cat-api/blob/main/.github/CONTRIBUTING.md#writing-docstrings) section of the `CONTRIBUTING` docs.
17
17
-[ ] If this PR fixes a bug, I've added a test that will fail without my fix.
18
18
-[ ] If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.
0 commit comments