fix: change fuzzySearchTree to pure function

Author: chandq

package.json

@@ -1,7 +1,6 @@
 {
   "name": "sculp-js",
   "version": "1.11.1-alpha.3",
-  "packageManager": "npm@8.19.2",
   "description": "js utils library, includes function library、class library",
   "scripts": {
     "prepare": "husky install",
@@ -38,8 +37,8 @@
   ],
   "keywords": [
     "sculp-js",
-    "js-utils",
-    "typescript"
+    "es6",
+    "util"
   ],
   "engines": {
     "node": ">=16"

src/tree.ts

@@ -299,7 +299,8 @@ export function fuzzySearchTree<V>(
   }
   const result: V[] = [];
 
-  arrayEach(nodes, node => {
+  for (let i = 0, len = nodes.length; i < len; i++) {
+    const node = nodes[i];
     // 递归检查子节点是否匹配
     const matchedChildren =
       node[options.childField] && node[options.childField].length > 0
@@ -323,24 +324,20 @@ export function fuzzySearchTree<V>(
             [options.childField]: matchedChildren // 包含匹配的子节点
           });
         } else if (options.removeEmptyChild) {
-          node[options.childField] && delete node[options.childField];
-          result.push({
-            ...node
-          });
+          const { [options.childField]: _, ...other } = node as any;
+          result.push(other);
         } else {
           result.push({
             ...node,
-            ...{ [options.childField]: [] }
+            [options.childField]: []
           });
         }
       } else {
-        node[options.childField] && delete node[options.childField];
-
-        result.push({
-          ...node
-        });
+        const { [options.childField]: _, ...other } = node as any;
+        result.push(other);
       }
     }
-  });
+  }
+
   return result;
 }

test/tree.test.ts

@@ -532,7 +532,7 @@ test('mapDeep', () => {
   ]);
 });
 
-describe('fuzzySearchTree', () => {
+describe('fuzzySearchTree: keywords', () => {
   test('search by keyword', () => {
     // 定义树结构
     const tree = [
@@ -566,6 +566,7 @@ describe('fuzzySearchTree', () => {
         ]
       }
     ];
+    const clone = cloneDeep(tree);
 
     // 测试keyword 1
     const query = 'apr';
@@ -677,9 +678,10 @@ describe('fuzzySearchTree', () => {
         ]
       }
     ]);
+    expect(tree).toEqual(clone);
   });
 
-  test('search by filter function, include not ignore case', () => {
+  test('fuzzySearchTree: search by filter function, include not ignore case', () => {
     const res1 = [];
     const res2 = [];
     // 定义树结构
@@ -697,7 +699,7 @@ describe('fuzzySearchTree', () => {
               {
                 id: 3,
                 name: 'Anpricot',
-                children: [{ id: 5, name: 'butterfly' }]
+                children: [{ id: 35, name: 'butterfly' }]
               },
               {
                 id: 4,
@@ -731,6 +733,7 @@ describe('fuzzySearchTree', () => {
         ]
       }
     ];
+    const clone = cloneDeep(tree);
     const query = 'An';
     // keyword模式匹配，不忽略大小写
     const result1 = fuzzySearchTree(
@@ -821,5 +824,7 @@ describe('fuzzySearchTree', () => {
     // keyword匹配模式，且keyword为空串
     const result4 = fuzzySearchTree(tree, { keyword: '' });
     expect(result4).toBe(tree);
+
+    expect(tree).toEqual(clone);
   });
 });