Skip to content

Commit 53ea044

Browse files
curtisdelicatacurtisdelicata
authored
Merge pull request #12 from genealogiawebsite/analysis-7a31yb
Apply fixes from StyleCI
2 parents 7efd375 + dfe0ac1 commit 53ea044

File tree

9 files changed

+245
-272
lines changed

9 files changed

+245
-272
lines changed

‎src/Utils/FamilyData.php‎

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,6 @@
33
namespace GenealogiaWebsite\LaravelGedcom\Utils;
44

55
use GenealogiaWebsite\LaravelGedcom\Models\Family;
6-
use GenealogiaWebsite\LaravelGedcom\Models\Person;
7-
use GenealogiaWebsite\LaravelGedcom\Utils\Importer\Chan;
8-
use GenealogiaWebsite\LaravelGedcom\Utils\Importer\Fam\Even;
9-
use GenealogiaWebsite\LaravelGedcom\Utils\Importer\Fam\Slgs;
10-
use GenealogiaWebsite\LaravelGedcom\Utils\Importer\NoteRef;
11-
use GenealogiaWebsite\LaravelGedcom\Utils\Importer\ObjeRef;
12-
use GenealogiaWebsite\LaravelGedcom\Utils\Importer\Refn;
13-
use GenealogiaWebsite\LaravelGedcom\Utils\Importer\SourRef;
14-
use GenealogiaWebsite\LaravelGedcom\Utils\Importer\Subm;
156

167
class FamilyData
178
{
@@ -33,7 +24,7 @@ class FamilyData
3324
public static function getFamily($conn, $families, $obje_ids)
3425
{
3526
$familyData = [];
36-
foreach($families as $family){
27+
foreach ($families as $family) {
3728
$g_id = $family->getId();
3829
$resn = $family->getResn();
3930
$husb = $family->getHusb();
@@ -71,6 +62,6 @@ public static function getFamily($conn, $families, $obje_ids)
7162
// $familydata [] = $value;
7263
}
7364
// Family::insert($familyData);
74-
otherFamRecord::insertFamilyData($conn,$families,$obje_ids);
65+
otherFamRecord::insertFamilyData($conn, $families, $obje_ids);
7566
}
7667
}

‎src/Utils/GedcomParser.php‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,10 @@ public function parse($conn, string $filename, string $slug, bool $progressBar =
4949
error_log('PARSE LOG : +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++'.$conn);
5050
$parser = new Parser();
5151
$gedcom = @$parser->parse($filename);
52-
52+
5353
/**
5454
* work.
5555
*/
56-
5756
$head = $gedcom->getHead();
5857
$subn = $gedcom->getSubn();
5958
$subm = $gedcom->getSubm();
@@ -84,7 +83,7 @@ public function parse($conn, string $filename, string $slug, bool $progressBar =
8483
$complete = 0;
8584
if ($progressBar === true) {
8685
$bar = $this->getProgressBar($indCount + $famCount);
87-
event(new GedComProgressSent($slug, $total, $complete));
86+
event(new GedComProgressSent($slug, $total, $complete));
8887
}
8988
Log::info('Individual:'.$indCount);
9089
Log::info('Families:'.$famCount);
@@ -218,11 +217,11 @@ public function parse($conn, string $filename, string $slug, bool $progressBar =
218217
$item->delete();
219218
}
220219
}
221-
220+
222221
FamilyData::getFamily($this->conn, $families, $this->obje_ids);
223-
222+
224223
foreach ($families as $family) {
225-
// // $this->getFamily($family);
224+
// // $this->getFamily($family);
226225
// FamilyData::getFamily($this->conn, $family, $this->obje_ids);
227226
if ($progressBar === true) {
228227
$bar->advance();
@@ -250,5 +249,4 @@ private function getProgressBar(int $max)
250249
new StreamOutput(fopen('php://stdout', 'w'))
251250
))->createProgressBar($max);
252251
}
253-
254252
}

‎src/Utils/Importer/Indi/Alia.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ class Alia
1212
* Integer $group_id.
1313
*/
1414
public static function read($conn, $item, $group = '', $group_id = 0)
15-
{
15+
{
1616
$aliaData = [];
1717
foreach ($item as $alia) {
1818
if ($alia) {
1919
$data = ['group'=>$group, 'gid'=>$group_id, 'alia'=>$alia];
20-
$aliaData [] = $data;
20+
$aliaData[] = $data;
2121
}
2222
}
2323
PersonAlia::insert($aliaData);

‎src/Utils/Importer/Indi/Anci.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public static function read($conn, $item, $group = '', $group_id = 0, $subm_ids)
2121
$subm_id = $subm_ids[$anci];
2222
$key = ['group'=>$group, 'gid'=>$group_id, 'anci'=>$subm_id];
2323
$data = ['group'=>$group, 'gid'=>$group_id, 'anci'=>$subm_id];
24-
$record [] = $data;
24+
$record[] = $data;
2525
}
2626
}
2727
}

‎src/Utils/Importer/Indi/Even.php‎

Lines changed: 123 additions & 121 deletions
Original file line numberDiff line numberDiff line change
@@ -16,29 +16,29 @@ class Even
1616
public static function read($conn, $events, $person, $obje_ids = [])
1717
{
1818
$eventData = [];
19-
foreach($events as $event){
20-
if ($event && count($event) > 0) {
19+
foreach ($events as $event) {
20+
if ($event && count($event) > 0) {
2121
$even = $event[0];
22-
$class_name = get_class($even);
23-
$person_id = $person->id;
24-
$type = $even->getType();
25-
$attr = $even->getAttr();
26-
$_date = $even->getDate();
27-
$date = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Date::read($conn, $_date);
28-
$_plac = $even->getPlac();
29-
$plac = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Indi\Even\Plac::read($conn, $_plac);
30-
$_phon = $even->getPhon();
31-
$phon = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Phon::read($conn, $_phon);
32-
$_addr = $even->getAddr();
33-
$addr_id = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Addr::read($conn, $_addr);
22+
$class_name = get_class($even);
23+
$person_id = $person->id;
24+
$type = $even->getType();
25+
$attr = $even->getAttr();
26+
$_date = $even->getDate();
27+
$date = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Date::read($conn, $_date);
28+
$_plac = $even->getPlac();
29+
$plac = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Indi\Even\Plac::read($conn, $_plac);
30+
$_phon = $even->getPhon();
31+
$phon = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Phon::read($conn, $_phon);
32+
$_addr = $even->getAddr();
33+
$addr_id = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Addr::read($conn, $_addr);
3434

35-
$caus = $even->getCaus();
36-
$age = $even->getAge();
37-
$agnc = $even->getAgnc();
38-
$adop = '';
39-
$adop_famc = '';
40-
$birt_famc = '';
41-
switch ($class_name) {
35+
$caus = $even->getCaus();
36+
$age = $even->getAge();
37+
$agnc = $even->getAgnc();
38+
$adop = '';
39+
$adop_famc = '';
40+
$birt_famc = '';
41+
switch ($class_name) {
4242
case 'Adop':
4343
$adop = $even->getAdop();
4444
$adop_famc = $even->getFamc();
@@ -117,27 +117,27 @@ public static function read($conn, $events, $person, $obje_ids = [])
117117
break;
118118
default:
119119
}
120-
$adop = '';
121-
$adop_famc = '';
122-
$birt_famc = '';
123-
// store Even
124-
$key = [
125-
['person_id' , $person_id],
126-
['title' , $class_name],
127-
['type' , $type],
128-
['attr' , $attr],
129-
['date' , $date],
130-
['plac' , $plac],
131-
['phon' , $phon],
132-
['caus' , $caus],
133-
['age' , $age],
134-
['agnc' , $agnc],
135-
['adop' , $adop],
136-
['adop_famc' , $adop_famc],
137-
['birt_famc' , $birt_famc]
138-
];
120+
$adop = '';
121+
$adop_famc = '';
122+
$birt_famc = '';
123+
// store Even
124+
$key = [
125+
['person_id', $person_id],
126+
['title', $class_name],
127+
['type', $type],
128+
['attr', $attr],
129+
['date', $date],
130+
['plac', $plac],
131+
['phon', $phon],
132+
['caus', $caus],
133+
['age', $age],
134+
['agnc', $agnc],
135+
['adop', $adop],
136+
['adop_famc', $adop_famc],
137+
['birt_famc', $birt_famc],
138+
];
139139
$check = PersonEvent::where($key)->first();
140-
if(empty($check)){
140+
if (empty($check)) {
141141
$data = [
142142
'person_id' => $person_id,
143143
'title' => $class_name,
@@ -155,38 +155,40 @@ public static function read($conn, $events, $person, $obje_ids = [])
155155
'birt_famc' => $birt_famc, //
156156
];
157157

158-
$eventData [] = $data;
158+
$eventData[] = $data;
159159
}
160160
}
161161
}
162162
PersonEvent::insert($eventData);
163-
$new = new Even;
164-
$new->otherField($conn,$events,$person);
163+
$new = new Even();
164+
$new->otherField($conn, $events, $person);
165165
}
166-
public static function otherField($conn, $events, $person){
167-
foreach($events as $event){
168-
if ($event && count($event) > 0) {
166+
167+
public static function otherField($conn, $events, $person)
168+
{
169+
foreach ($events as $event) {
170+
if ($event && count($event) > 0) {
169171
$even = $event[0];
170-
$class_name = get_class($even);
171-
$person_id = $person->id;
172-
$type = $even->getType();
173-
$attr = $even->getAttr();
174-
$_date = $even->getDate();
175-
$date = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Date::read($conn, $_date);
176-
$_plac = $even->getPlac();
177-
$plac = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Indi\Even\Plac::read($conn, $_plac);
178-
$_phon = $even->getPhon();
179-
$phon = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Phon::read($conn, $_phon);
180-
$_addr = $even->getAddr();
181-
$addr_id = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Addr::read($conn, $_addr);
172+
$class_name = get_class($even);
173+
$person_id = $person->id;
174+
$type = $even->getType();
175+
$attr = $even->getAttr();
176+
$_date = $even->getDate();
177+
$date = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Date::read($conn, $_date);
178+
$_plac = $even->getPlac();
179+
$plac = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Indi\Even\Plac::read($conn, $_plac);
180+
$_phon = $even->getPhon();
181+
$phon = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Phon::read($conn, $_phon);
182+
$_addr = $even->getAddr();
183+
$addr_id = \GenealogiaWebsite\LaravelGedcom\Utils\Importer\Addr::read($conn, $_addr);
182184

183-
$caus = $even->getCaus();
184-
$age = $even->getAge();
185-
$agnc = $even->getAgnc();
186-
$adop = '';
187-
$adop_famc = '';
188-
$birt_famc = '';
189-
switch ($class_name) {
185+
$caus = $even->getCaus();
186+
$age = $even->getAge();
187+
$agnc = $even->getAgnc();
188+
$adop = '';
189+
$adop_famc = '';
190+
$birt_famc = '';
191+
switch ($class_name) {
190192
case 'Adop':
191193
$adop = $even->getAdop();
192194
$adop_famc = $even->getFamc();
@@ -265,71 +267,71 @@ public static function otherField($conn, $events, $person){
265267
break;
266268
default:
267269
}
268-
$adop = '';
269-
$adop_famc = '';
270-
$birt_famc = '';
271-
// store Even
272-
$key = [
273-
['person_id' , $person_id],
274-
['title' , $class_name],
275-
['type' , $type],
276-
['attr' , $attr],
277-
['date' , $date],
278-
['plac' , $plac],
279-
['phon' , $phon],
280-
['caus' , $caus],
281-
['age' , $age],
282-
['agnc' , $agnc],
283-
['adop' , $adop],
284-
['adop_famc' , $adop_famc],
285-
['birt_famc' , $birt_famc],
286-
];
270+
$adop = '';
271+
$adop_famc = '';
272+
$birt_famc = '';
273+
// store Even
274+
$key = [
275+
['person_id', $person_id],
276+
['title', $class_name],
277+
['type', $type],
278+
['attr', $attr],
279+
['date', $date],
280+
['plac', $plac],
281+
['phon', $phon],
282+
['caus', $caus],
283+
['age', $age],
284+
['agnc', $agnc],
285+
['adop', $adop],
286+
['adop_famc', $adop_famc],
287+
['birt_famc', $birt_famc],
288+
];
287289

288-
$record = PersonEvent::where($key)->first();
290+
$record = PersonEvent::where($key)->first();
289291

290-
$_group = 'indi_even';
291-
$_gid = $record->id;
292+
$_group = 'indi_even';
293+
$_gid = $record->id;
292294

293-
// update person's record
294-
if ($class_name == 'BIRT' && !empty($date)) {
295-
$person->birthday = date('Y-m-d', strtotime($date));
296-
}
297-
// add deathyear to person table ( for form builder )
298-
if ($class_name == 'DEAT' && !empty($date)) {
299-
$person->deathday = date('Y-m-d', strtotime($date));
300-
}
301-
$person->save();
295+
// update person's record
296+
if ($class_name == 'BIRT' && !empty($date)) {
297+
$person->birthday = date('Y-m-d', strtotime($date));
298+
}
299+
// add deathyear to person table ( for form builder )
300+
if ($class_name == 'DEAT' && !empty($date)) {
301+
$person->deathday = date('Y-m-d', strtotime($date));
302+
}
303+
$person->save();
302304

303-
// array
304-
$sour = $even->getSour();
305-
if ($sour && count($sour) > 0) {
306-
foreach ($sour as $item) {
307-
if ($item) {
308-
\GenealogiaWebsite\LaravelGedcom\Utils\Importer\SourRef::read($conn, $item, $_group, $_gid);
305+
// array
306+
$sour = $even->getSour();
307+
if ($sour && count($sour) > 0) {
308+
foreach ($sour as $item) {
309+
if ($item) {
310+
\GenealogiaWebsite\LaravelGedcom\Utils\Importer\SourRef::read($conn, $item, $_group, $_gid);
311+
}
309312
}
310313
}
311-
}
312-
$obje = $even->getObje();
313-
if ($obje && count($obje) > 0) {
314-
foreach ($obje as $item) {
315-
if ($item) {
316-
\GenealogiaWebsite\LaravelGedcom\Utils\Importer\ObjeRef::read($conn, $item, $_group, $_gid, $obje_ids);
314+
$obje = $even->getObje();
315+
if ($obje && count($obje) > 0) {
316+
foreach ($obje as $item) {
317+
if ($item) {
318+
\GenealogiaWebsite\LaravelGedcom\Utils\Importer\ObjeRef::read($conn, $item, $_group, $_gid, $obje_ids);
319+
}
317320
}
318321
}
319-
}
320-
$notes = $even->getNote();
321-
if ($notes && count($notes) > 0) {
322-
foreach ($notes as $item) {
323-
\GenealogiaWebsite\LaravelGedcom\Utils\Importer\NoteRef::read($conn, $item, $_group, $_gid);
322+
$notes = $even->getNote();
323+
if ($notes && count($notes) > 0) {
324+
foreach ($notes as $item) {
325+
\GenealogiaWebsite\LaravelGedcom\Utils\Importer\NoteRef::read($conn, $item, $_group, $_gid);
326+
}
327+
}
328+
// object
329+
$_chan = $even->getChan() ?? null;
330+
if ($_chan !== null) {
331+
\GenealogiaWebsite\LaravelGedcom\Utils\Importer\Chan::read($conn, $_chan, $_group, $_gid);
324332
}
325-
}
326-
// object
327-
$_chan = $even->getChan() ?? null;
328-
if ($_chan !== null) {
329-
\GenealogiaWebsite\LaravelGedcom\Utils\Importer\Chan::read($conn, $_chan, $_group, $_gid);
330-
}
331333

332-
// $_type = $even->getType();
334+
// $_type = $even->getType();
333335
// $person->addEvent($_type, $date, $plac);
334336
}
335337
}

0 commit comments

Comments
 (0)