Revert "feature: Error handling and circular dependency management. (#19)"

This reverts commit 3f7ff12.

Author: cesarParra

force-app/lwc/signals/core.js

@@ -6,10 +6,6 @@ const context = [];
 function _getCurrentObserver() {
   return context[context.length - 1];
 }
-const UNSET = Symbol("UNSET");
-const COMPUTING = Symbol("COMPUTING");
-const ERRORED = Symbol("ERRORED");
-const READY = Symbol("READY");
 /**
  * Creates a new effect that will be executed immediately and whenever
  * any of the signals it reads from change.
@@ -30,34 +26,16 @@ const READY = Symbol("READY");
  * @param fn The function to execute
  */
 function $effect(fn) {
-  const effectNode = {
-    error: null,
-    state: UNSET
-  };
   const execute = () => {
-    if (effectNode.state === COMPUTING) {
-      throw new Error("Circular dependency detected");
-    }
     context.push(execute);
     try {
-      effectNode.state = COMPUTING;
       fn();
-      effectNode.error = null;
-      effectNode.state = READY;
     } finally {
       context.pop();
     }
   };
   execute();
 }
-function computedGetter(node) {
-  if (node.state === ERRORED) {
-    console.log("throwing error", node.error);
-    throw node.error;
-  }
-  console.log("all good");
-  return node.signal.readOnly;
-}
 /**
  * Creates a new computed value that will be updated whenever the signals
  * it reads from change. Returns a read-only signal that contains the
@@ -74,26 +52,13 @@ function computedGetter(node) {
  * @param fn The function that returns the computed value.
  */
 function $computed(fn) {
-  const computedNode = {
-    signal: $signal(undefined),
-    error: null,
-    state: UNSET
-  };
+  // The initial value is undefined, as it will be computed
+  // when the effect runs for the first time
+  const computedSignal = $signal(undefined);
   $effect(() => {
-    if (computedNode.state === COMPUTING) {
-      throw new Error("Circular dependency detected");
-    }
-    try {
-      computedNode.state = COMPUTING;
-      computedNode.signal.value = fn();
-      computedNode.error = null;
-      computedNode.state = READY;
-    } catch (error) {
-      computedNode.state = ERRORED;
-      computedNode.error = error;
-    }
+    computedSignal.value = fn();
   });
-  return computedGetter(computedNode);
+  return computedSignal.readOnly;
 }
 class UntrackedState {
   constructor(value) {

src/lwc/signals/__tests__/effect.test.ts

@@ -14,13 +14,4 @@ describe("effects", () => {
     signal.value = 1;
     expect(effectTracker).toBe(1);
   });
-
-  test("throw an error when a circular dependency is detected", () => {
-    expect(() => {
-      const signal = $signal(0);
-      $effect(() => {
-        signal.value = signal.value++;
-      });
-    }).toThrow();
-  });
 });

src/lwc/signals/core.ts

@@ -19,16 +19,6 @@ function _getCurrentObserver(): VoidFunction | undefined {
   return context[context.length - 1];
 }
 
-const UNSET = Symbol("UNSET");
-const COMPUTING = Symbol("COMPUTING");
-const ERRORED = Symbol("ERRORED");
-const READY = Symbol("READY");
-
-interface EffectNode {
-  error: unknown;
-  state: symbol;
-}
-
 /**
  * Creates a new effect that will be executed immediately and whenever
  * any of the signals it reads from change.
@@ -49,22 +39,10 @@ interface EffectNode {
  * @param fn The function to execute
  */
 function $effect(fn: VoidFunction): void {
-  const effectNode: EffectNode = {
-    error: null,
-    state: UNSET
-  }
-
   const execute = () => {
-    if (effectNode.state === COMPUTING) {
-      throw new Error("Circular dependency detected");
-    }
-
     context.push(execute);
     try {
-      effectNode.state = COMPUTING;
       fn();
-      effectNode.error = null;
-      effectNode.state = READY;
     } finally {
       context.pop();
     }
@@ -73,22 +51,8 @@ function $effect(fn: VoidFunction): void {
   execute();
 }
 
-interface ComputedNode<T> {
-  signal: Signal<T | undefined>;
-  error: unknown;
-  state: symbol;
-}
-
 type ComputedFunction<T> = () => T;
 
-function computedGetter<T>(node: ComputedNode<T>) {
-  if (node.state === ERRORED) {
-    throw node.error;
-  }
-
-  return node.signal.readOnly as ReadOnlySignal<T>;
-}
-
 /**
  * Creates a new computed value that will be updated whenever the signals
  * it reads from change. Returns a read-only signal that contains the
@@ -105,29 +69,15 @@ function computedGetter<T>(node: ComputedNode<T>) {
  * @param fn The function that returns the computed value.
  */
 function $computed<T>(fn: ComputedFunction<T>): ReadOnlySignal<T> {
-  const computedNode: ComputedNode<T> = {
-    signal: $signal<T | undefined>(undefined),
-    error: null,
-    state: UNSET
-  };
+  // The initial value is undefined, as it will be computed
+  // when the effect runs for the first time
+  const computedSignal: Signal<T | undefined> = $signal(undefined);
 
   $effect(() => {
-    if (computedNode.state === COMPUTING) {
-      throw new Error("Circular dependency detected");
-    }
-
-    try {
-      computedNode.state = COMPUTING;
-      computedNode.signal.value = fn();
-      computedNode.error = null;
-      computedNode.state = READY;
-    } catch (error) {
-      computedNode.state = ERRORED;
-      computedNode.error = error;
-    }
+    computedSignal.value = fn();
   });
 
-  return computedGetter(computedNode);
+  return computedSignal.readOnly as ReadOnlySignal<T>;
 }
 
 type StorageFn<T> = (value: T) => State<T> & { [key: string]: unknown };