Add option to set default outFormat to json

Author: cemremengu

README.md

@@ -61,9 +61,8 @@ properties:
 takes precedence over the `pool` option.
 + `client`: an instance of an `oracledb` connection pool. This takes precedence
 over the `pool` and `poolAlias` options.
-
-A `name` option can be used in order to connect to multiple oracledb instances. 
-The first registered instance can be accessed via `fastify.oracle` or `fastify.oracle.<dbname>`. Note that once you register a *named* instance, you will *not* be able to register an unnamed instance.
++ `name`: can be used in order to connect to multiple oracledb instances. The first registered instance can be accessed via `fastify.oracle` or `fastify.oracle.<dbname>`. Note that once you register a *named* instance, you will *not* be able to register an unnamed instance.
++ `jsonOutput`: sets the `outFormat` of oracledb to `OBJECT` (default: `false` i.e: `ARRAY`)
 
 ```js
 const fastify = require('fastify')()

plugin.js

@@ -27,7 +27,7 @@ function decorateFastifyInstance (pool, fastify, options, next) {
     }
   }
 
-  fastify.addHook('onClose', (fastify, done) => pool.close(done))
+  fastify.addHook('onClose', (_, done) => pool.close(done))
 
   return next()
 }
@@ -54,6 +54,10 @@ function fastifyOracleDB (fastify, options, next) {
     return next(Error('fastify-oracle: must supply options.pool oracledb pool options'))
   }
 
+  if (options.jsonOutput) {
+    oracledb.outFormat = oracledb.OBJECT
+  }
+
   oracledb.createPool(options.pool, (err, pool) => {
     if (err) {
       return next(Error('fastify-oracle: failed to create pool' + '-' + err.message))

test.js

@@ -92,6 +92,35 @@ test('accepts singleton client', (t) => {
   })
 })
 
+test('sets json as default outFormat', (t) => {
+  t.plan(9)
+
+  const fastify = Fastify()
+  fastify.register(plugin, { pool: poolOptions, jsonOutput: true })
+
+  fastify.ready(err => {
+    t.error(err)
+    t.ok(fastify.oracle.pool)
+
+    fastify.oracle.getConnection((err, conn) => {
+      t.error(err)
+      conn.execute('SELECT 1 AS FOO FROM DUAL', (err, result) => {
+        t.error(err)
+        t.is(result.rows.length, 1)
+        t.is(result.rows[0].FOO, 1)
+        conn.close(err => {
+          t.error(err)
+
+          fastify.close(err => {
+            t.error(err)
+            t.is(fastify.oracle.pool.status, fastify.oracle.db.POOL_STATUS_CLOSED)
+          })
+        })
+      })
+    })
+  })
+})
+
 test('retrieves a cached pool', (t) => {
   t.plan(7)