Fix committing, update readme

Author: cemremengu

README.md

@@ -131,6 +131,52 @@ fastify.get('/db_data', async function (req, reply) {
 
 If needed `pool` instance can be accessed via `fastify.oracle[.dbname].pool`
 
+## Use of scoped executions
+
+```js
+const fastify = require('fastify')
+
+fastify.register(require('fastify-oracle'), {
+  pool: {
+    user: 'travis',
+    password: 'travis',
+    connectString: 'localhost/xe'
+  } 
+})
+
+fastify.post('/user/:username', (req, reply) => {
+  // will return a promise, fastify will send the result automatically
+  return fastify.oracle.scope(async conn => {
+    // will resolve to commit, or reject with an error
+    return conn.execute(`INSERT INTO USERS (NAME) VALUES('JIMMY')`)
+  })
+})
+
+/* or with a scope callback
+
+fastify.oracle.scope(conn => {
+    return conn.execute('SELECT * FROM DUAL')
+  },
+  function onResult (err, result) {
+    reply.send(err || result)
+  }
+})
+
+*/
+
+/* or with a commit callback
+
+fastify.oracle.scope((conn, commit) => {
+  conn.execute('SELECT * FROM DUAL', (err, res) => {
+    commit(err, res)
+  });
+})
+
+*/
+
+```
+
+
 ## License
 
 [MIT License](http://jsumners.mit-license.org/)

plugin.js

@@ -7,25 +7,33 @@ function executionScope (pool, fn, cb) {
   pool.getConnection(function (err, conn) {
     if (err) return cb(err)
 
-    const doRelease = (conn) => {
-      conn.close(function () { })
+    const release = (conn) => {
+      conn.close(function (_) {
+      })
     }
 
-    const done = (err, res) => {
-      doRelease(conn)
-
+    const commit = (err, res) => {
       if (err) {
+        release(conn)
         return cb(err)
       }
-      return cb(null, res)
+
+      conn.commit(function (err) {
+        if (err) {
+          release(conn)
+          return cb(err)
+        }
+        release(conn)
+        return cb(null, res)
+      })
     }
 
-    const promise = fn(conn, done)
+    const promise = fn(conn, commit)
 
     if (promise && typeof promise.then === 'function') {
       promise.then(
-        (res) => done(null, res),
-        (e) => done(e))
+        (res) => commit(null, res),
+        (e) => commit(e))
     }
   })
 }

test/lib.test.js

@@ -175,9 +175,9 @@ test('execution scope with execute callback', (t) => {
     t.error(err)
     t.ok(fastify.oracle.pool)
 
-    fastify.oracle.scope((conn, done) => {
+    fastify.oracle.scope((conn, commit) => {
       conn.execute('SELECT * FROM DUAL', function (err, result) {
-        done(err, result)
+        commit(err, result)
       })
     }, function (err, res) {
       t.error(err)
@@ -247,9 +247,9 @@ test('execution scope with execute callback (error)', (t) => {
     t.error(err)
     t.ok(fastify.oracle.pool)
 
-    fastify.oracle.scope((conn, done) => {
+    fastify.oracle.scope((conn, commit) => {
       conn.execute('SELECT * FROM ??', function (err, result) {
-        done(err, result)
+        commit(err, result)
       })
     }, function (err, res) {
       t.is(res, undefined)