Properly test psi reference contributor

Author: cedricziel

src/main/java/com/cedricziel/idea/typo3/index/IconIndex.java

@@ -32,6 +32,7 @@ public class IconIndex extends FileBasedIndexExtension<String, IconStub> {
 
     public static ID<String, IconStub> KEY = ID.create("com.cedricziel.idea.typo3.index.icon");
 
+    @NotNull
     public static Collection<String> getAllAvailableIcons(@NotNull Project project) {
 
         return FileBasedIndex.getInstance().getAllKeys(KEY, project);

src/main/java/com/cedricziel/idea/typo3/util/PhpLangUtil.java

@@ -4,6 +4,7 @@
 import com.intellij.psi.util.PsiTreeUtil;
 import com.jetbrains.php.PhpIndex;
 import com.jetbrains.php.lang.psi.elements.*;
+import com.jetbrains.php.lang.psi.resolve.types.PhpType;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
@@ -92,6 +93,12 @@ public static String getClassName(@NotNull PsiElement element) {
             return null;
         }
 
+        Variable variableBeingCalledOn = PsiTreeUtil.findChildOfType(methodReference, Variable.class);
+        if (variableBeingCalledOn != null && variableBeingCalledOn.getInferredType() != null) {
+            PhpType inferredType = variableBeingCalledOn.getInferredType();
+            return inferredType.toString();
+        }
+
         ClassReference classReference = PsiTreeUtil.getChildOfType(methodReference, ClassReference.class);
 
         return extractFqnFromClassReference(methodReference, classReference);

src/test/java/com/cedricziel/idea/typo3/icons/IconReferenceProviderTest.java

@@ -0,0 +1,55 @@
+package com.cedricziel.idea.typo3.icons;
+
+import com.cedricziel.idea.typo3.index.IconIndex;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiReference;
+import com.intellij.testFramework.fixtures.LightCodeInsightFixtureTestCase;
+
+
+public class IconReferenceProviderTest extends LightCodeInsightFixtureTestCase {
+    @Override
+    protected String getTestDataPath() {
+        return "testData/com/cedricziel/idea/typo3/icons";
+    }
+
+    public void testIconsAreDetectedForv7() {
+        myFixture.addFileToProject("foo/ext_emconf.php", "");
+        myFixture.configureByFile("IconRegistry7.php");
+
+        IconIndex.getAllAvailableIcons(myFixture.getProject()).contains("actions-edit-cut-release");
+        IconIndex.getAllAvailableIcons(myFixture.getProject()).contains("flags-pg");
+    }
+
+    public void testIconsAreDetectedForv8() {
+        myFixture.addFileToProject("foo/ext_emconf.php", "");
+        myFixture.configureByFile("IconRegistry8.php");
+
+        IconIndex.getAllAvailableIcons(myFixture.getProject()).contains("actions-edit-cut-release");
+        IconIndex.getAllAvailableIcons(myFixture.getProject()).contains("flags-pg");
+    }
+
+    public void testIconsAreDetectedForv9() {
+        myFixture.addFileToProject("foo/ext_emconf.php", "");
+        myFixture.configureByFile("IconRegistry9.php");
+
+        IconIndex.getAllAvailableIcons(myFixture.getProject()).contains("actions-wizard-link");
+        IconIndex.getAllAvailableIcons(myFixture.getProject()).contains("flags-pg");
+    }
+
+    public void testIconReferenceIsCreatedOnGetIcon() {
+        myFixture.addFileToProject("foo/ext_emconf.php", "");
+        myFixture.configureByFile("IconRegistry9.php");
+        myFixture.configureByFile("icon_provider_test.php");
+
+        PsiElement elementAtCaret = myFixture.getFile().findElementAt(myFixture.getCaretOffset()).getParent();
+
+        PsiReference[] references = elementAtCaret.getReferences();
+        for (PsiReference ref : references) {
+            if (ref instanceof IconReference) {
+                return;
+            }
+        }
+
+        fail("No icon reference found");
+    }
+}