Merge pull request #219 from cedricziel/globals-typo3-request

[T3CMS] Resolve value of $GLOBALS['TYPO3_REQUEST']

Author: cedricziel

typo3-cms/src/main/java/com/cedricziel/idea/typo3/provider/PhpGlobalsTypeProvider.java

@@ -4,7 +4,10 @@
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.util.PsiTreeUtil;
 import com.jetbrains.php.PhpIndex;
-import com.jetbrains.php.lang.psi.elements.*;
+import com.jetbrains.php.lang.psi.elements.ArrayAccessExpression;
+import com.jetbrains.php.lang.psi.elements.ArrayIndex;
+import com.jetbrains.php.lang.psi.elements.PhpNamedElement;
+import com.jetbrains.php.lang.psi.elements.StringLiteralExpression;
 import com.jetbrains.php.lang.psi.elements.impl.StringLiteralExpressionImpl;
 import com.jetbrains.php.lang.psi.elements.impl.VariableImpl;
 import com.jetbrains.php.lang.psi.resolve.types.PhpType;
@@ -56,6 +59,8 @@ public PhpType getType(PsiElement psiElement) {
                 return new PhpType().add("#C\\TYPO3\\CMS\\Core\\Authentication\\BackendUserAuthentication");
             case "LANG":
                 return new PhpType().add("#C\\TYPO3\\CMS\\Lang\\LanguageService");
+            case "TYPO3_REQUEST":
+                return new PhpType().add("#C\\Psr\\Http\\Message\\ServerRequestInterface");
             default:
                 return null;
         }

typo3-cms/src/test/java/com/cedricziel/idea/typo3/provider/PhpGlobalsTypeProviderTest.java

@@ -0,0 +1,55 @@
+package com.cedricziel.idea.typo3.provider;
+
+import com.cedricziel.idea.typo3.AbstractTestCase;
+import com.intellij.psi.PsiElement;
+import com.intellij.psi.PsiFile;
+import com.jetbrains.php.lang.PhpFileType;
+import com.jetbrains.php.lang.psi.elements.MethodReference;
+
+public class PhpGlobalsTypeProviderTest extends AbstractTestCase {
+    @Override
+    protected String getTestDataPath() {
+        return "testData/com/cedricziel/idea/typo3/provider";
+    }
+
+    public void testGlobalTypesAreResolved() {
+        assertCanResolveGlobalsValue(
+            "TYPO3_REQUEST",
+            "#M#C\\Psr\\Http\\Message\\ServerRequestInterface.getServerParams",
+            "getServer<caret>Params"
+        );
+        assertCanResolveGlobalsValue(
+            "LANG",
+            "#M#C\\TYPO3\\CMS\\Lang\\LanguageService.getLL",
+            "get<caret>LL"
+        );
+        assertCanResolveGlobalsValue(
+            "TYPO3_DB",
+            "#M#C\\TYPO3\\CMS\\Core\\Database\\DatabaseConnection.exec_SELECTgetRows",
+            "exec_<caret>SELECTgetRows"
+        );
+        assertCanResolveGlobalsValue(
+            "BE_USER",
+            "#M#C\\TYPO3\\CMS\\Core\\Authentication\\BackendUserAuthentication.getPagePermsClause",
+            "getPagePerms<caret>Clause"
+        );
+        assertCanResolveGlobalsValue(
+            "TSFE",
+            "#M#C\\TYPO3\\CMS\\Frontend\\Controller\\TypoScriptFrontendController.getPageAndRootlineWithDomain",
+            "getPageAndRootlineWith<caret>Domain"
+        );
+    }
+
+    private void assertCanResolveGlobalsValue(String index, String expectedType, String method) {
+        PsiFile psiFile = myFixture.configureByText(PhpFileType.INSTANCE, "<?php\n" +
+            "$foo = $GLOBALS['" + index + "'];\n" +
+            "$foo->" + method + "();");
+
+        PsiElement elementAtCaret = psiFile.findElementAt(myFixture.getCaretOffset());
+        assertNotNull(elementAtCaret);
+        assertInstanceOf(elementAtCaret.getParent(), MethodReference.class);
+
+        MethodReference methodReference = (MethodReference) elementAtCaret.getParent();
+        assertTrue(methodReference.getType().getTypes().contains(expectedType));
+    }
+}