Skip to content

Commit b433e2f

Browse files
committed
add more changes
1 parent ff310f3 commit b433e2f

File tree

3 files changed

+38
-40
lines changed

3 files changed

+38
-40
lines changed

index.html

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
<header>
3838
<nav>
3939
<ul class="menu">
40-
<li id="home"> <a href="#"><i class="fa fa-house fa-lg"></i></a></li>
40+
<li id="home"> <a href="#" class="icon-link"><i class="fa fa-house fa-lg"></i></a></li>
4141
<li>
4242
<a class="nav-link" href="#work">Work</a>
4343
<a class="nav-link" href="#contact">Contact</a>
@@ -48,10 +48,10 @@
4848
<section>
4949
<div class="presentation">
5050
<h1 id="presentation-title">Hi, I am <br class='br-show'>Carlos Jorge!</h1>
51-
<h2 id="presentation-main-skill">I'm an <br class='br-show'>full-stack engineer</h2>
51+
<h3 id="presentation-main-skill">I'm an <br class='br-show'>full-stack engineer</h3>
5252
<p id="presentation-description">
5353
I'm a cuban computer science from Havana University.
54-
Currently, I'm working as full-stack engineer focused in building .net application, and angular applications.
54+
Currently, I'm working as full-stack engineer focused in building .net application, and frontend applications in frameworks like angular, vue or react.
5555
</p>
5656
</div>
5757
</section>
@@ -91,7 +91,8 @@ <h2 class="subtitle reveal">These are my github repositories</h2>
9191
</article>
9292
</section>
9393
<footer>
94-
<article>
94+
<div class="footer">
95+
9596
<div id="contact" class="contacts reveal">
9697
<h1 class="subtitle contacts-item">Contact</h1>
9798
<div class="contacts-item">
@@ -101,18 +102,16 @@ <h1 class="subtitle contacts-item">Contact</h1>
101102
<a class="icon-link" href="https://twitter.com/CarlosJorgeRod3"><i class="fab fa-twitter fa-2xl"></i></a>
102103
</div>
103104
</div>
104-
</article>
105-
<article>
106-
<div class="footer reveal">
107-
<p class="footer-item">
105+
<div class="footer-info reveal">
106+
<p class="footer-info-item">
108107
© 2022 Carlos Jorge
109108
</br>
110109
<a class="work-link" href="https://github.com/CarlosJorgeR/carlosjorger.github.io">Published</a> in
111110
<a class="work-link" href="https://pages.github.com/">Github Page</a>
112111
</p>
113-
114112
</div>
115-
</article>
113+
</div>
114+
116115
</footer>
117116
</body>
118117

index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ function reveal() {
33
[...revealElements].forEach((element) => {
44
var windowHeight = window.innerHeight;
55
const elementTop = element.getBoundingClientRect().top;
6-
if (elementTop < windowHeight - (element.getBoundingClientRect().height)) {
6+
if ((elementTop < windowHeight - (element.getBoundingClientRect().height))) {
7+
// if(element.id=='open-ecommerce'){
8+
// console.log(windowHeight,element.getBoundingClientRect())
9+
// }
710
element.classList.add("active");
811
} else {
912
element.classList.remove("active");

styles.css

Lines changed: 25 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@ h3 {
2929
}
3030

3131
/* % always with the property width */
32-
32+
footer ,
3333
section {
3434
/* for guide */
3535
/* border: solid 3px aqua; */
3636
width: 60%;
3737
margin: 0 auto;
3838
margin-top: 5em;
3939
margin-bottom: 5em;
40-
height: 70vh;
40+
height: 25em;
4141
z-index: 2;
4242

4343
}
@@ -47,8 +47,8 @@ footer {
4747
/* border: solid 3px aqua; */
4848
width: 60%;
4949
margin: 0 auto;
50+
margin-top: 5em;
5051
margin-bottom: 5em;
51-
height: 25vh;
5252
}
5353

5454
article {
@@ -99,8 +99,11 @@ nav {
9999

100100

101101
/* || SITEWIDE */
102-
103-
.footer {
102+
.footer{
103+
display: grid;
104+
height: inherit;
105+
}
106+
.footer-info {
104107
color: var(--default-font-color);
105108
font-family: var(--default-font-family);
106109
display: flex;
@@ -109,7 +112,7 @@ nav {
109112

110113
}
111114

112-
.footer-item {
115+
.footer-info-item {
113116
margin: 0 auto;
114117
text-align: center;
115118
}
@@ -185,7 +188,7 @@ nav {
185188
}
186189

187190
#presentation-main-skill {
188-
font-size: 2.1rem;
191+
font-size: 1.8rem;
189192
opacity: 0;
190193
animation-name: show-presentation-main-skill;
191194
animation-timing-function: ease;
@@ -297,7 +300,7 @@ nav {
297300

298301
@media (max-width: 1100px) {
299302
:root {
300-
font-size: 23px;
303+
font-size: 25px;
301304

302305

303306
}
@@ -316,7 +319,7 @@ nav {
316319

317320
@media (max-width: 885px) {
318321
:root {
319-
font-size: 17px;
322+
font-size: 20px;
320323

321324
}
322325
.card-project{
@@ -329,12 +332,14 @@ nav {
329332
section,
330333
footer {
331334
width: 75%;
335+
height: 30em;
336+
332337
}
333338
}
334339

335340
@media (max-width: 665px) {
336341
:root {
337-
font-size: 13px;
342+
font-size: 15px;
338343
}
339344
.card-project{
340345
width: 80%;
@@ -346,38 +351,29 @@ nav {
346351
section,
347352
footer {
348353
width: 80%;
354+
height: 35em;
355+
349356
}
350357
}
351358

352-
@media (max-width: 450px) {
359+
@media (max-width: 510px) {
353360
:root {
354-
font-size: 13px;
361+
font-size: 17px;
362+
}
363+
.card-project{
364+
width: 85%;
355365
}
356-
357366
p {
358-
max-width: 80%;
367+
max-width: 85%;
359368
}
360369

361370
section,
362371
footer {
363-
width: 80%;
372+
width: 83%;
373+
height: 40em;
364374
}
365375

366376
.br-show {
367377
display: inline;
368378
}
369379
}
370-
371-
@media (min-height:700px) {
372-
373-
section {
374-
height: 80vh;
375-
}
376-
}
377-
378-
@media (min-height:800px) {
379-
380-
section {
381-
height: 90vh;
382-
}
383-
}

0 commit comments

Comments
 (0)