Skip to content

Commit 09fd666

Browse files
committed
✨ feat: remove space betwean section
1 parent 600361d commit 09fd666

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

src/components/AboutMe.astro

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import Subtitle from './shared/Subtitle.astro';
33
import CustomParagraph from './shared/CustomParagraph.astro';
44
---
55

6-
<section id="aboutMe" class="h-screen max-sm:h-[100dvh]">
6+
<section id="aboutMe" class="h-screen max-sm:mt-12 max-sm:h-full">
77
<div class="flex h-[90%] flex-col justify-center break-words p-2">
88
<header class="reveal pb-2">
99
<Subtitle left>About me</Subtitle>
@@ -18,11 +18,10 @@ import CustomParagraph from './shared/CustomParagraph.astro';
1818
vue, html, css.
1919
</CustomParagraph>
2020
<a
21-
class="reveal mt-2 rounded-md border-2 border-teal-300 px-8 py-4 text-center text-2xl text-teal-300 transition-colors duration-500 ease-in hover:bg-teal-300 hover:text-[--default-background-color]"
21+
class="reveal mt-2 rounded-md border-2 border-teal-300 px-8 py-4 text-center text-2xl text-teal-300 transition-colors duration-500 ease-in hover:bg-teal-300 hover:text-[--default-background-color] max-sm:mt-12"
2222
href="/pdfs/resume.pdf"
2323
target="_blank"
24-
aria-label="Download Curriculum Vitae pdf"
25-
download="resume.pdf">Curriculum Vitae</a
24+
aria-label="Download Curriculum Vitae pdf">Curriculum Vitae</a
2625
>
2726
</div>
2827
</section>

src/components/Footer/Footer.astro

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ import CustomParagraph from '../shared/CustomParagraph.astro';
66
---
77

88
<footer>
9-
<div class="m-1 grid h-screen max-sm:h-[100dvh]">
9+
<div class="m-1 grid h-screen max-sm:h-[70dvh]">
1010
<div id="contact" class="flex flex-col justify-center">
11-
<section class="z-0 mt-8 w-1/2 p-2 max-sm:w-[90%]">
11+
<section class="z-0 mt-8 w-1/2 p-2 max-sm:mt-0 max-sm:w-[90%]">
1212
<Subtitle center>Contact</Subtitle>
1313
<div class="reveal mx-0 my-3 text-center">
1414
<CustomParagraph>
@@ -44,7 +44,7 @@ import CustomParagraph from '../shared/CustomParagraph.astro';
4444
<div
4545
class="flex flex-col justify-center font-lato text-[var(--default-font-color)]"
4646
>
47-
<p class="reveal mx-auto my-0 mb-12 text-center text-3xl">
47+
<p class="last-reveal mx-auto my-0 mb-12 text-center text-3xl">
4848
<strong class="inline italic">© 2022 Carlos Jorge</strong>
4949
<br />
5050
<span>

src/pages/index.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import Presentation from '../components/Presentation.astro';
2020
}
2121
});
2222
</script>
23-
<!-- TODO: remove space betwean section --><!-- TODO: Add skills -->
23+
<!-- TODO: Add skills -->
2424
<Layout title="Carlos Jorge's personal portfolio website">
2525
<Header />
2626
<main>

src/styles/styles.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ a {
4949
animation-timeline: view();
5050
animation-range: entry 20% cover 30%;
5151
}
52+
.last-reveal {
53+
animation: reveal-animation linear both;
54+
animation-timeline: view();
55+
animation-range: entry 10% cover 20%;
56+
}
5257
@keyframes reveal-animation {
5358
from {
5459
opacity: 0;

0 commit comments

Comments
 (0)