Make the shorthand detection more restrictive

In order to allow people to use scripts like `captainhook.sh`
or `captainhook.php` the regex and the test examples got improved.

Author: sebastianfeldmann

src/Runner/Shorthand.php

@@ -12,6 +12,7 @@
 namespace CaptainHook\App\Runner;
 
 use CaptainHook\App\Hook;
+use PHPUnit\Framework\MockObject\MockObject;
 use RuntimeException;
 
 /**
@@ -84,14 +85,14 @@ class Shorthand
     ];
 
     /**
-     * Check if a configured action value is actually shorthand for an internal action
+     * Check if a configured action or condition value is actually a shorthand for an internal action
      *
-     * @param  string $action
+     * @param  string $shorthand
      * @return bool
      */
-    public static function isShorthand(string $action): bool
+    public static function isShorthand(string $shorthand): bool
     {
-        return (bool) preg_match('#^captainhook\.[a-z]+#i', $action);
+        return preg_match('#^captainhook\.[a-z]+\.[a-z]+$#i', $shorthand);
     }
 
     /**

tests/unit/Runner/ShorthandTest.php

@@ -25,11 +25,12 @@ public function testCanIdentifyShorthand()
         $this->assertFalse(Shorthand::isShorthand('foo'));
         $this->assertFalse(Shorthand::isShorthand('\\CaptainHook\\App'));
         $this->assertFalse(Shorthand::isShorthand('CaptainHook.'));
+        $this->assertFalse(Shorthand::isShorthand('captainhook.sh'));
 
         // positive
-        $this->assertTrue(Shorthand::isShorthand('CaptainHook.foo'));
-        $this->assertTrue(Shorthand::isShorthand('captainhook.bar'));
-        $this->assertTrue(Shorthand::isShorthand('CAPTAINHOOK.baz'));
+        $this->assertTrue(Shorthand::isShorthand('CaptainHook.foo.fiz'));
+        $this->assertTrue(Shorthand::isShorthand('captainhook.Bar.Baz'));
+        $this->assertTrue(Shorthand::isShorthand('CAPTAINHOOK.FOO.BAR'));
     }
 
     /**