partial fix and test for #276

Author: justinbmeyer

can-component.js

@@ -206,7 +206,7 @@ function getSetupFunctionForComponentVM(componentInitVM) {
 				onCompleteBindings.push(canBinding.start.bind(canBinding));
 
 				// We’ll want to turn off the bindings when the component is destroyed
-				onTeardowns.push(canBinding.stop);
+				onTeardowns.push(canBinding.stop.bind(canBinding));
 
 			} else {
 				// Can’t get or set the value, so assume it’s not an observable
@@ -590,7 +590,7 @@ var Component = Construct.extend(
 
 // This adds support for components being rendered as values in stache templates
 Component.prototype[viewInsertSymbol] = function(viewData) {
-	viewData.nodeList.newDeepChildren.push(this.nodeList);
+	viewData.nodeList.deepChildren.push(this.nodeList);
 	return this.element;
 };
 

test/component-instantiation-test.js

@@ -4,6 +4,8 @@ var QUnit = require("steal-qunit");
 var SimpleMap = require("can-simple-map");
 var stache = require("can-stache");
 var value = require("can-value");
+var SimpleObservable = require("can-simple-observable");
+var stache = require("can-stache");
 
 QUnit.module("can-component instantiation");
 
@@ -286,3 +288,33 @@ QUnit.test("Component binding instantiation works as documented", function() {
 	QUnit.equal(family.get("first"), "Milo", "map “from” prop is correct");
 	QUnit.equal(family.get("full"), "Milo Flanders", "map “to” prop is correct");
 });
+
+QUnit.test("Component can be removed from the page", function(){
+	var ToBeRemoved = Component.extend({
+		tag: "to-be-removed",
+		view: "{{prop}}",
+		ViewModel: {
+			prop: "string"
+		}
+	});
+
+	var prop = new SimpleObservable(3);
+
+	var toBeRemoved = new ToBeRemoved({
+		viewModel: {
+			prop: prop
+		}
+	});
+
+	var show = new SimpleObservable(true);
+
+	var template = stache("<div>{{# if(show) }} {{{toBeRemoved}}} {{/ if}}</div>");
+
+	template({
+		show: show,
+		toBeRemoved: toBeRemoved
+	});
+
+	show.set(false);
+	QUnit.ok(true, "got here without an error");
+});