Fix tests

Author: kraenhansen

packages/react-native-node-api-modules/src/node/babel-plugin/plugin.test.ts

@@ -12,9 +12,9 @@ describe("plugin", () => {
   it("transforms require calls, regardless", (context) => {
     const tempDirectoryPath = setupTempDirectory(context, {
       "package.json": `{ "name": "my-package" }`,
-      "addon-1.xcframework/addon-1.node":
+      "addon-1.apple.node/addon-1.node":
         "// This is supposed to be a binary file",
-      "addon-2.xcframework/addon-2.node":
+      "addon-2.apple.node/addon-2.node":
         "// This is supposed to be a binary file",
       "addon-1.js": `
         const addon = require('./addon-1.node');

packages/react-native-node-api-modules/src/node/path-utils.test.ts

@@ -16,8 +16,7 @@ import { setupTempDirectory } from "./test-utils.js";
 describe("isNodeApiModule", () => {
   it("returns true for .node", (context) => {
     const tempDirectoryPath = setupTempDirectory(context, {
-      "addon.xcframework/addon.node":
-        "// This is supposted to be a binary file",
+      "addon.apple.node/addon.node": "// This is supposted to be a binary file",
     });
 
     assert(isNodeApiModule(path.join(tempDirectoryPath, "addon")));
@@ -63,9 +62,9 @@ describe("isNodeApiModule", () => {
     assert.equal(isNodeApiModule(fakePath), false);
   });
 
-  it("recognize .xcframeworks", (context) => {
+  it("recognize .apple.node directories", (context) => {
     const tempDirectoryPath = setupTempDirectory(context, {
-      "addon.xcframework/addon.node": "// This is supposed to be a binary file",
+      "addon.apple.node/addon.node": "// This is supposed to be a binary file",
     });
     assert.equal(isNodeApiModule(path.join(tempDirectoryPath, "addon")), true);
     assert.equal(
@@ -78,7 +77,7 @@ describe("isNodeApiModule", () => {
   it("throws when one module unreadable but another readable", (context) => {
     const tempDirectoryPath = setupTempDirectory(context, {
       "addon.android.node": "",
-      "addon.xcframework": "",
+      "addon.apple.node": "",
     });
     const unreadable = path.join(tempDirectoryPath, "addon.android.node");
     // only android module is unreadable
@@ -160,8 +159,8 @@ describe("getLibraryName", () => {
   it("works when including relative path", (context) => {
     const tempDirectoryPath = setupTempDirectory(context, {
       "package.json": `{ "name": "my-package" }`,
-      "addon.xcframework/addon.node": "// This is supposed to be a binary file",
-      "sub-directory/addon.xcframework/addon.node":
+      "addon.apple.node/addon.node": "// This is supposed to be a binary file",
+      "sub-directory/addon.apple.node/addon.node":
         "// This is supposed to be a binary file",
     });
     assert.equal(
@@ -182,8 +181,8 @@ describe("getLibraryName", () => {
   it("works when stripping relative path", (context) => {
     const tempDirectoryPath = setupTempDirectory(context, {
       "package.json": `{ "name": "my-package" }`,
-      "addon.xcframework/addon.node": "// This is supposed to be a binary file",
-      "sub-directory/addon.xcframework/addon.node":
+      "addon.apple.node/addon.node": "// This is supposed to be a binary file",
+      "sub-directory/addon.apple.node/addon.node":
         "// This is supposed to be a binary file",
     });
     assert.equal(
@@ -237,45 +236,45 @@ describe("findPackageDependencyPaths", () => {
 });
 
 describe("findNodeApiModulePaths", () => {
-  it("should find xcframework paths", (context) => {
+  it("should find .apple.node paths", (context) => {
     const tempDir = setupTempDirectory(context, {
-      "root.xcframework/react-native-node-api-module": "",
-      "sub-directory/lib-a.xcframework/react-native-node-api-module": "",
-      "sub-directory/lib-b.xcframework/react-native-node-api-module": "",
+      "root.apple.node/react-native-node-api-module": "",
+      "sub-directory/lib-a.apple.node/react-native-node-api-module": "",
+      "sub-directory/lib-b.apple.node/react-native-node-api-module": "",
     });
     const result = findNodeApiModulePaths({
       fromPath: tempDir,
       platform: "apple",
     });
     assert.deepEqual(result.sort(), [
-      path.join(tempDir, "root.xcframework"),
-      path.join(tempDir, "sub-directory/lib-a.xcframework"),
-      path.join(tempDir, "sub-directory/lib-b.xcframework"),
+      path.join(tempDir, "root.apple.node"),
+      path.join(tempDir, "sub-directory/lib-a.apple.node"),
+      path.join(tempDir, "sub-directory/lib-b.apple.node"),
     ]);
   });
 
   it("respects default exclude patterns", (context) => {
     const tempDir = setupTempDirectory(context, {
-      "root.xcframework/react-native-node-api-module": "",
-      "child-dir/dependency/lib.xcframework/react-native-node-api-module": "",
-      "child-dir/node_modules/dependency/lib.xcframework/react-native-node-api-module":
+      "root.apple.node/react-native-node-api-module": "",
+      "child-dir/dependency/lib.apple.node/react-native-node-api-module": "",
+      "child-dir/node_modules/dependency/lib.apple.node/react-native-node-api-module":
         "",
     });
     const result = findNodeApiModulePaths({
       fromPath: tempDir,
       platform: "apple",
     });
     assert.deepEqual(result.sort(), [
-      path.join(tempDir, "child-dir/dependency/lib.xcframework"),
-      path.join(tempDir, "root.xcframework"),
+      path.join(tempDir, "child-dir/dependency/lib.apple.node"),
+      path.join(tempDir, "root.apple.node"),
     ]);
   });
 
   it("respects explicit exclude patterns", (context) => {
     const tempDir = setupTempDirectory(context, {
-      "root.xcframework/react-native-node-api-module": "",
-      "child-dir/dependency/lib.xcframework/react-native-node-api-module": "",
-      "child-dir/node_modules/dependency/lib.xcframework/react-native-node-api-module":
+      "root.apple.node/react-native-node-api-module": "",
+      "child-dir/dependency/lib.apple.node/react-native-node-api-module": "",
+      "child-dir/node_modules/dependency/lib.apple.node/react-native-node-api-module":
         "",
     });
     const result = findNodeApiModulePaths({
@@ -284,23 +283,23 @@ describe("findNodeApiModulePaths", () => {
       excludePatterns: [/root/],
     });
     assert.deepEqual(result.sort(), [
-      path.join(tempDir, "child-dir/dependency/lib.xcframework"),
-      path.join(tempDir, "child-dir/node_modules/dependency/lib.xcframework"),
+      path.join(tempDir, "child-dir/dependency/lib.apple.node"),
+      path.join(tempDir, "child-dir/node_modules/dependency/lib.apple.node"),
     ]);
   });
 
   it("disregards parts futher up in filesystem when excluding", (context) => {
     const tempDir = setupTempDirectory(context, {
-      "node_modules/root.xcframework/react-native-node-api-module": "",
-      "node_modules/child-dir/node_modules/dependency/lib.xcframework/react-native-node-api-module":
+      "node_modules/root.apple.node/react-native-node-api-module": "",
+      "node_modules/child-dir/node_modules/dependency/lib.apple.node/react-native-node-api-module":
         "",
     });
     const result = findNodeApiModulePaths({
       fromPath: path.join(tempDir, "node_modules"),
       platform: "apple",
     });
     assert.deepEqual(result, [
-      path.join(tempDir, "node_modules/root.xcframework"),
+      path.join(tempDir, "node_modules/root.apple.node"),
     ]);
   });
 });
@@ -311,7 +310,7 @@ describe("determineModuleContext", () => {
       "package.json": `{ "name": "cached-pkg" }`,
       "subdir1/file1.node": "",
       "subdir2/file2.node": "",
-      "subdir1/file1.xcframework": "",
+      "subdir1/file1.apple.node": "",
     });
     let readCount = 0;
     const orig = fs.readFileSync;