Rename inject_host to inject_weak_node_api_host, mark it extern "C" and move it out of namespace

Author: kraenhansen

packages/react-native-node-api-modules/scripts/generate-weak-node-api-injector.ts

@@ -25,26 +25,23 @@ export function generateSource(functions: FunctionDecl[]) {
     #endif
 
     namespace callstack::nodeapihost {
-    
-    using node_api::internal::InjectHostFunction;
-    using node_api::internal::NodeApiHost;
 
     void injectIntoWeakNodeApi() {
     void *module = dlopen(WEAK_NODE_API_LIBRARY_NAME, RTLD_NOW | RTLD_LOCAL);
-    if (NULL == module) {
+    if (nullptr == module) {
       log_debug("NapiHost: Failed to load weak-node-api: %s", dlerror());
       abort();
     }
 
-    auto inject_host = (InjectHostFunction)dlsym(
-        module, "_ZN8node_api8internal11inject_hostERKNS0_11NodeApiHostE");
-    if (NULL == inject_host) {
-      log_debug("NapiHost: Failed to find 'inject_host' function: %s", dlerror());
+    auto inject_weak_node_api_host = (InjectHostFunction)dlsym(
+    module, "inject_weak_node_api_host");
+    if (nullptr == inject_weak_node_api_host) {
+      log_debug("NapiHost: Failed to find 'inject_weak_node_api_host' function: %s", dlerror());
       abort();
     }
 
     log_debug("Injecting WeakNodeApiHost");
-    inject_host(NodeApiHost {
+    inject_weak_node_api_host(WeakNodeApiHost {
       ${functions
         .filter(({ kind }) => kind === "engine")
         .flatMap(({ name }) => `.${name} = ${name},`)

packages/react-native-node-api-modules/scripts/generate-weak-node-api.ts

@@ -15,15 +15,15 @@ export function generateHeader(functions: FunctionDecl[]) {
     "#include <node_api.h>", // Node-API
     "#include <stdio.h>", // fprintf()
     "#include <stdlib.h>", // abort()
-    "namespace node_api::internal {",
     // Generate the struct of function pointers
-    "struct NodeApiHost {",
+    "struct WeakNodeApiHost {",
     ...functions.map(
       ({ returnType, name, argumentTypes }) =>
         `${returnType} (*${name})(${argumentTypes.join(", ")});`
     ),
     "};",
-    "typedef void(*InjectHostFunction)(const NodeApiHost&);",
+    "typedef void(*InjectHostFunction)(const WeakNodeApiHost&);",
+    `extern "C" void inject_weak_node_api_host(const WeakNodeApiHost& host);`,
   ].join("\n");
 }
 
@@ -34,14 +34,11 @@ export function generateSource(functions: FunctionDecl[]) {
   return [
     "// This file is generated by react-native-node-api-modules",
     `#include "weak_node_api.hpp"`, // Generated header
-    "namespace node_api::internal {",
     // Generate the struct of function pointers
-    "NodeApiHost g_host;",
-    "void inject_host(const NodeApiHost& host) {",
+    "WeakNodeApiHost g_host;",
+    "void inject_weak_node_api_host(const WeakNodeApiHost& host) {",
     "  g_host = host;",
     "};",
-    "} // namespace node_api::internal",
-    "using node_api::internal::g_host;",
     ``,
     // Generate function calling into the host
     ...functions.flatMap(({ returnType, name, argumentTypes }) => {