Modified construction of std::atomic types to not use assignment.

Author: calebtt

XMapLib/CPPRunnerGeneric.h

@@ -31,7 +31,7 @@ namespace sds
 	protected:
 		const LambdaType m_lambda;
 		InternalData m_local_state{}; // default constructed type InternalData
-		std::atomic<bool> m_is_stop_requested = false;
+		std::atomic<bool> m_is_stop_requested{ false };
 		std::unique_ptr<std::thread> m_local_thread;
 		std::mutex m_state_mutex;
 	public:

XMapLib/KeyboardPlayerInfo.h

@@ -10,7 +10,7 @@ namespace sds
 	{
 		using PidType = int;
 		//ISO CPP guidelines C.45 followed here: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-default
-		std::atomic<PidType> player_id = 0;
+		std::atomic<PidType> player_id{ 0 };
 		//default ctor
 		KeyboardPlayerInfo() = default;
 		//copy constructor

XMapLib/MouseMapper.h

@@ -17,10 +17,10 @@ namespace sds
 		using InternalType = int;
 		using LambdaRunnerType = sds::CPPRunnerGeneric<InternalType>;
 		using lock = LambdaRunnerType::ScopedLockType;
-		std::atomic<StickMap> m_stickmap_info = StickMap::NEITHER_STICK;
-		std::atomic<SHORT> m_thread_x = 0;
-		std::atomic<SHORT> m_thread_y = 0;
-		std::atomic<int> m_mouse_sensitivity = MouseSettings::SENSITIVITY_DEFAULT;
+		std::atomic<StickMap> m_stickmap_info{ StickMap::NEITHER_STICK };
+		std::atomic<SHORT> m_thread_x{ 0 };
+		std::atomic<SHORT> m_thread_y{0};
+		std::atomic<int> m_mouse_sensitivity{ MouseSettings::SENSITIVITY_DEFAULT };
 		sds::MousePlayerInfo m_local_player;
 		sds::MouseInputPoller m_poller;
 		std::unique_ptr<LambdaRunnerType> m_workThread;

XMapLib/MouseMoveThread.h

@@ -13,12 +13,12 @@ namespace sds
 		using InternalType = int;
 		using LambdaRunnerType = sds::CPPRunnerGeneric<InternalType>;
 		using lock = LambdaRunnerType::ScopedLockType;
-		std::atomic<size_t> m_x_axis_delay = 1;
-		std::atomic<size_t> m_y_axis_delay = 1;
-		std::atomic<bool> m_is_x_moving = false;
-		std::atomic<bool> m_is_y_moving = false;
-		std::atomic<bool> m_is_x_positive = false;
-		std::atomic<bool> m_is_y_positive = false;
+		std::atomic<size_t> m_x_axis_delay{ 1 };
+		std::atomic<size_t> m_y_axis_delay{ 1 };
+		std::atomic<bool> m_is_x_moving{ false };
+		std::atomic<bool> m_is_y_moving{ false };
+		std::atomic<bool> m_is_x_positive{ false };
+		std::atomic<bool> m_is_y_positive{ false };
 		std::unique_ptr<LambdaRunnerType> m_workThread;
 		void InitWorkThread() noexcept
 		{

XMapLib/MousePlayerInfo.h

@@ -10,11 +10,11 @@ namespace sds
 		using PidType = int;
 		using DzType = int;
 		//ISO CPP guidelines C.45 followed here: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-default
-		std::atomic<DzType> left_x_dz = XINPUT_GAMEPAD_LEFT_THUMB_DEADZONE; // left stick X axis dz
-		std::atomic<DzType> left_y_dz = XINPUT_GAMEPAD_LEFT_THUMB_DEADZONE; // left stick Y axis dz
-		std::atomic<DzType> right_x_dz = XINPUT_GAMEPAD_RIGHT_THUMB_DEADZONE; // right stick X axis dz
-		std::atomic<DzType> right_y_dz = XINPUT_GAMEPAD_RIGHT_THUMB_DEADZONE; // right stick Y axis dz
-		std::atomic<PidType> player_id = 0;
+		std::atomic<DzType> left_x_dz{ XINPUT_GAMEPAD_LEFT_THUMB_DEADZONE }; // left stick X axis dz
+		std::atomic<DzType> left_y_dz{ XINPUT_GAMEPAD_LEFT_THUMB_DEADZONE }; // left stick Y axis dz
+		std::atomic<DzType> right_x_dz{ XINPUT_GAMEPAD_RIGHT_THUMB_DEADZONE }; // right stick X axis dz
+		std::atomic<DzType> right_y_dz{ XINPUT_GAMEPAD_RIGHT_THUMB_DEADZONE }; // right stick Y axis dz
+		std::atomic<PidType> player_id{ 0 };
 		//default ctor
 		MousePlayerInfo() = default;
 		//copy constructor

XMapLib/ThumbstickToDelay.h

@@ -13,7 +13,7 @@ namespace sds
 	class ThumbstickToDelay
 	{
 		const std::string BAD_DELAY_MSG = "Bad timer delay value, exception.";
-		inline static std::atomic<bool> m_is_deadzone_activated = false; //shared between instances
+		inline static std::atomic<bool> m_is_deadzone_activated{ false }; //shared between instances
 		float m_alt_deadzone_multiplier = MouseSettings::ALT_DEADZONE_MULT_DEFAULT;
 		int m_axis_sensitivity = MouseSettings::SENSITIVITY_DEFAULT;
 		int m_x_axis_deadzone = MouseSettings::DEADZONE_DEFAULT;

XMapLib/XMapLib.cpp

@@ -12,7 +12,7 @@ void AddTestKeyMappings(sds::KeyboardMapper& mapper, std::osyncstream &ss);
 class GetterExit
 {
 	std::unique_ptr<std::thread> workerThread;
-	std::atomic<bool> m_exitState = false;
+	std::atomic<bool> m_exitState{ false };
 	const sds::KeyboardMapper& m_mp;
 public:
 	GetterExit(const sds::KeyboardMapper& m) : m_mp(m) { startThread(); }

XMapLibSharp/KeymapPresetOperations.cs

@@ -30,7 +30,7 @@ public static void ChangeButtonTextForSelected(Button prButton, bool makeSelecte
                 if (IsButtonTextSelected(prButton))
                 {
                     string temp = prButton.Text;
-                    int index = temp.IndexOf(MSG_PRESET_SELECTED);
+                    int index = temp.IndexOf(MSG_PRESET_SELECTED, StringComparison.Ordinal);
                     prButton.Text = temp[..index];
                 }
             }
@@ -39,7 +39,7 @@ public static void ChangeButtonTextForSelected(Button prButton, bool makeSelecte
         public static bool IsButtonTextSelected(Button prButton)
         {
             string temp = prButton.Text;
-            int index = temp.IndexOf(MSG_PRESET_SELECTED);
+            int index = temp.IndexOf(MSG_PRESET_SELECTED, StringComparison.Ordinal);
             return (index != -1);
         }