Skip to content

Commit d615f5c

Browse files
authored
Fix/last failure details ellipsis (#119)
* updating pending activities to not wrap items. * Changing name back to executions because of breaking style change. * 3.13.2-beta.0 * fixing class name * fixing tests * 3.13.2
1 parent bfccddd commit d615f5c

File tree

4 files changed

+19
-11
lines changed

4 files changed

+19
-11
lines changed

client/routes/workflow/index.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<section class="workflow" :class="{ loading: wfLoading }">
2+
<section class="execution" :class="{ loading: wfLoading }">
33
<navigation-bar>
44
<navigation-link
55
id="nav-link-summary"

client/routes/workflow/summary.vue

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,14 @@ section.workflow-summary
199199
overflow auto
200200
padding layout-spacing-small
201201
202+
.pending-activities {
203+
dl.details {
204+
dd {
205+
white-space: normal;
206+
}
207+
}
208+
}
209+
202210
dl:not(.details)
203211
& > div
204212
margin-bottom 1em

client/test/workflow.test.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ describe('Workflow', () => {
3838
scenario.withFullHistory(opts.events);
3939
const summaryEl = await scenario
4040
.render(opts.attach)
41-
.waitUntilExists('section.workflow section.workflow-summary dl');
41+
.waitUntilExists('section.execution section.workflow-summary dl');
4242

4343
return [summaryEl.parentElement, scenario];
4444
}
@@ -1056,18 +1056,18 @@ describe('Workflow', () => {
10561056
const [, scenario] = await summaryTest(this.test);
10571057

10581058
scenario.vm.$el
1059-
.attrValues('section.workflow > nav a', 'href')
1059+
.attrValues('section.execution > nav a', 'href')
10601060
.should.deep.equal([
10611061
'/domains/ci-test/workflows/email-daily-summaries/emailRun1/summary',
10621062
'/domains/ci-test/workflows/email-daily-summaries/emailRun1/history',
10631063
'/domains/ci-test/workflows/email-daily-summaries/emailRun1/stack-trace',
10641064
'/domains/ci-test/workflows/email-daily-summaries/emailRun1/query',
10651065
]);
10661066
scenario.vm.$el
1067-
.querySelector('section.workflow > nav a#nav-link-stack-trace')
1067+
.querySelector('section.execution > nav a#nav-link-stack-trace')
10681068
.should.not.have.property('display', 'none');
10691069
scenario.vm.$el
1070-
.querySelector('section.workflow > nav a#nav-link-query')
1070+
.querySelector('section.execution > nav a#nav-link-query')
10711071
.should.not.have.property('display', 'none');
10721072
});
10731073

@@ -1151,7 +1151,7 @@ describe('Workflow', () => {
11511151

11521152
const queryEl = await scenario
11531153
.render()
1154-
.waitUntilExists('section.workflow section.query');
1154+
.waitUntilExists('section.execution section.query');
11551155

11561156
return [queryEl, scenario];
11571157
}
@@ -1230,21 +1230,21 @@ describe('Workflow', () => {
12301230
});
12311231

12321232
scenario.vm.$el
1233-
.attrValues('section.workflow > nav a', 'href')
1233+
.attrValues('section.execution > nav a', 'href')
12341234
.should.deep.equal([
12351235
'/domains/ci-test/workflows/email-daily-summaries/emailRun1/summary',
12361236
'/domains/ci-test/workflows/email-daily-summaries/emailRun1/history',
12371237
'/domains/ci-test/workflows/email-daily-summaries/emailRun1/stack-trace',
12381238
'/domains/ci-test/workflows/email-daily-summaries/emailRun1/query',
12391239
]);
12401240
scenario.vm.$el
1241-
.querySelector('section.workflow > nav a#nav-link-summary')
1241+
.querySelector('section.execution > nav a#nav-link-summary')
12421242
.should.have.class('router-link-active');
12431243
await retry(() => {
12441244
scenario.vm.$el.querySelector(
1245-
'section.workflow > nav a#nav-link-stack-trace'
1245+
'section.execution > nav a#nav-link-stack-trace'
12461246
).should.not.be.displayed;
1247-
scenario.vm.$el.querySelector('section.workflow > nav a#nav-link-query')
1247+
scenario.vm.$el.querySelector('section.execution > nav a#nav-link-query')
12481248
.should.not.be.displayed;
12491249
});
12501250
});

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "cadence-web",
3-
"version": "3.14.0-beta.0",
3+
"version": "3.13.2",
44
"description": "Cadence Web UI",
55
"main": "server/index.js",
66
"licence": "MIT",

0 commit comments

Comments
 (0)