Skip to content

Commit 014aeb8

Browse files
authored
changed feature flag service to a singleton (#407)
1 parent 6ff560d commit 014aeb8

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

client/components/feature-flag.vue

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2121
// THE SOFTWARE.
2222
23-
import { FeatureFlagService } from '~services';
23+
import { featureFlagService } from '~services';
2424
2525
export default {
2626
name: 'feature-flag',
@@ -58,7 +58,6 @@ export default {
5858
},
5959
async mounted() {
6060
const { name, params } = this;
61-
const featureFlagService = new FeatureFlagService();
6261
6362
this.isFeatureFlagEnabled = await featureFlagService.isFeatureFlagEnabled({
6463
name,

client/routes/workflow/summary.vue

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import { TERMINATE_DEFAULT_ERROR_MESSAGE } from './constants';
2424
import { NOTIFICATION_TYPE_ERROR, NOTIFICATION_TYPE_SUCCESS } from '~constants';
2525
import { getErrorMessage, getDatetimeFormattedString } from '~helpers';
2626
import { BarLoader, ButtonFill, DataViewer, DetailList } from '~components';
27-
import { FeatureFlagService, httpService } from '~services';
27+
import { featureFlagService, httpService } from '~services';
2828
2929
export default {
3030
data() {
@@ -56,8 +56,7 @@ export default {
5656
'detail-list': DetailList,
5757
},
5858
async mounted() {
59-
this.featureFlagService = new FeatureFlagService();
60-
this.isWorkflowTerminateFeatureFlagEnabled = await this.featureFlagService.isFeatureFlagEnabled(
59+
this.isWorkflowTerminateFeatureFlagEnabled = await featureFlagService.isFeatureFlagEnabled(
6160
{ name: 'workflowTerminate' }
6261
);
6362
this.initAuthorization();
@@ -117,7 +116,7 @@ export default {
117116
}
118117
},
119118
async initAuthorization() {
120-
const isDomainAuthorizationFeatureFlagEnabled = await this.featureFlagService.isFeatureFlagEnabled(
119+
const isDomainAuthorizationFeatureFlagEnabled = await featureFlagService.isFeatureFlagEnabled(
121120
{ name: 'domainAuthorization' }
122121
);
123122

client/services/feature-flag-service.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,12 @@ class FeatureFlagService {
3131

3232
return (await httpService.get(url)).value;
3333
}
34+
35+
getConfiguration(args) {
36+
return this.isFeatureFlagEnabled(args);
37+
}
3438
}
3539

36-
export default FeatureFlagService;
40+
const featureFlagService = new FeatureFlagService();
41+
42+
export default featureFlagService;

client/services/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@
1919
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2020
// THE SOFTWARE.
2121

22-
export { default as FeatureFlagService } from './feature-flag-service';
22+
export { default as featureFlagService } from './feature-flag-service';
2323
export { default as httpService } from './http-service';

0 commit comments

Comments
 (0)