From a4bd0775eae67c1f0ab31dfe1826ae64efb97bd4 Mon Sep 17 00:00:00 2001 From: Mandy Chen Date: Thu, 31 Jul 2025 13:28:49 -0700 Subject: [PATCH 1/4] Always upload artifacts --- .github/workflows/ci-checks.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci-checks.yml b/.github/workflows/ci-checks.yml index 10c0f7caf..0c5cfc798 100644 --- a/.github/workflows/ci-checks.yml +++ b/.github/workflows/ci-checks.yml @@ -35,9 +35,10 @@ jobs: max_attempts: 3 timeout_minutes: 30 command: | - docker compose -f docker/github_actions/docker-compose.yml run unit-test-test-service bash -c "./gradlew --no-daemon test jacocoTestReport && .github/scripts/coverage_metadata.sh build/reports/metadata.txt" + docker compose -f docker/github_actions/docker-compose.yml run unit-test-test-service bash -c "./gradlew --no-daemon test jacocoTestReport && .github/scripts/coverage_metadata.sh build/reports/metadata.txt && exit 1" - name: Upload coverage artifacts + if: always() uses: actions/upload-artifact@v4 with: name: unit-test-with-test-service-coverage @@ -67,6 +68,7 @@ jobs: docker compose -f docker/github_actions/docker-compose.yml run unit-test-docker-sticky-on bash -c "./gradlew --no-daemon test" - name: Upload coverage artifacts + if: always() uses: actions/upload-artifact@v4 with: name: unit-test-with-docker-service-sticky-on-coverage @@ -94,6 +96,7 @@ jobs: docker compose -f docker/github_actions/docker-compose.yml run unit-test-docker-sticky-off bash -c "./gradlew --no-daemon test" - name: Upload coverage artifacts + if: always() uses: actions/upload-artifact@v4 with: name: unit-test-with-docker-service-sticky-off-coverage From ea955e102704ae885a7adc5131c026c376a612b9 Mon Sep 17 00:00:00 2001 From: Mandy Chen Date: Thu, 31 Jul 2025 13:35:01 -0700 Subject: [PATCH 2/4] Test upload after fail --- .github/workflows/ci-checks.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-checks.yml b/.github/workflows/ci-checks.yml index 0c5cfc798..d7864bef1 100644 --- a/.github/workflows/ci-checks.yml +++ b/.github/workflows/ci-checks.yml @@ -32,10 +32,10 @@ jobs: - name: Run unit test with test service uses: nick-fields/retry@v3 with: - max_attempts: 3 + max_attempts: 1 timeout_minutes: 30 command: | - docker compose -f docker/github_actions/docker-compose.yml run unit-test-test-service bash -c "./gradlew --no-daemon test jacocoTestReport && .github/scripts/coverage_metadata.sh build/reports/metadata.txt && exit 1" + docker compose -f docker/github_actions/docker-compose.yml run unit-test-test-service bash -c "exit 1" - name: Upload coverage artifacts if: always() From b221da44a8b9e1bb90a91d4643209debc2842c40 Mon Sep 17 00:00:00 2001 From: Mandy Chen Date: Thu, 31 Jul 2025 13:42:56 -0700 Subject: [PATCH 3/4] Try with running test --- .github/workflows/ci-checks.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-checks.yml b/.github/workflows/ci-checks.yml index d7864bef1..0c5cfc798 100644 --- a/.github/workflows/ci-checks.yml +++ b/.github/workflows/ci-checks.yml @@ -32,10 +32,10 @@ jobs: - name: Run unit test with test service uses: nick-fields/retry@v3 with: - max_attempts: 1 + max_attempts: 3 timeout_minutes: 30 command: | - docker compose -f docker/github_actions/docker-compose.yml run unit-test-test-service bash -c "exit 1" + docker compose -f docker/github_actions/docker-compose.yml run unit-test-test-service bash -c "./gradlew --no-daemon test jacocoTestReport && .github/scripts/coverage_metadata.sh build/reports/metadata.txt && exit 1" - name: Upload coverage artifacts if: always() From dda78d40a4946b070114fbfd31327efbd01f1d38 Mon Sep 17 00:00:00 2001 From: Mandy Chen Date: Thu, 31 Jul 2025 13:48:44 -0700 Subject: [PATCH 4/4] Remove forced fail --- .github/workflows/ci-checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-checks.yml b/.github/workflows/ci-checks.yml index 0c5cfc798..fd10d2995 100644 --- a/.github/workflows/ci-checks.yml +++ b/.github/workflows/ci-checks.yml @@ -35,7 +35,7 @@ jobs: max_attempts: 3 timeout_minutes: 30 command: | - docker compose -f docker/github_actions/docker-compose.yml run unit-test-test-service bash -c "./gradlew --no-daemon test jacocoTestReport && .github/scripts/coverage_metadata.sh build/reports/metadata.txt && exit 1" + docker compose -f docker/github_actions/docker-compose.yml run unit-test-test-service bash -c "./gradlew --no-daemon test jacocoTestReport && .github/scripts/coverage_metadata.sh build/reports/metadata.txt" - name: Upload coverage artifacts if: always()