Remove coveralls integration and generate metadata for Sonarqube (#952)

Author: natemort

.buildkite/pipeline.yml

@@ -52,7 +52,8 @@ steps:
 
   - label: ":java: Unit test with test services"
     artifact_paths:
-      - "build/reports/jacoco/test/*.xml"
+      - "build/reports/jacoco/test/jacocoTestReport.xml"
+      - "build/reports/metadata.txt"
     timeout_in_minutes: 30
     retry:
       automatic:
@@ -68,6 +69,7 @@ steps:
                 command:
                 - |-
                   ./gradlew --no-daemon test jacocoTestReport
+                  .buildkite/scripts/coverage_metadata.sh build/reports/metadata.txt
       - docker-compose#v3.0.0:
           run: unit-test-test-service
           config: docker/buildkite/docker-compose.yaml
@@ -111,24 +113,3 @@ steps:
       - docker-compose#v3.0.0:
           run: unit-test-docker-sticky-off
           config: docker/buildkite/docker-compose.yaml
-
-  - wait
-
-  - label: ":java: Report test coverage"
-    retry:
-      automatic:
-        - exit_status: "*"
-          limit: 3
-    plugins:
-      - kubernetes:
-          <<: *kubernetes
-          podSpec:
-            <<: *podSpec
-            containers:
-              - <<: *commandContainer
-                command:
-                - |-
-                  .buildkite/scripts/coverage.sh
-      - docker-compose#v3.0.0:
-          run: test-coverage-report
-          config: docker/buildkite/docker-compose.yaml

.buildkite/scripts/coverage.sh

@@ -0,0 +1,11 @@
+#!/bin/sh
+set -ex
+# This script generates coverage metadata for the coverage report.
+# Output is used by SonarQube integration in Uber and not used by OS repo coverage tool itself.
+# Example output:
+#   commit-sha: 6953daa563e8e44512bc349c9608484cfd4ec4ff
+#   timestamp: 2024-03-04T19:29:16Z
+output_path="$1"
+echo "commit-sha: $(git rev-parse HEAD)" > "$output_path"
+echo "timestamp: $(date -u +%Y-%m-%dT%H:%M:%SZ)" >> "$output_path"
+echo "Coverage metadata written to $output_path"

.buildkite/scripts/coverage_metadata.sh

@@ -1,4 +1,4 @@
-# Java framework for Cadence [![Build Status](https://badge.buildkite.com/0c96b8b74c0921208e898c10a602e2fe9ecb7641c2befee0e7.svg?theme=github&branch=master)](https://buildkite.com/uberopensource/cadence-java-client) [![Javadocs](https://www.javadoc.io/badge/com.uber.cadence/cadence-client.svg)](https://www.javadoc.io/doc/com.uber.cadence/cadence-client) [![Coverage Status](https://coveralls.io/repos/github/uber/cadence-java-client/badge.svg)](https://coveralls.io/github/uber/cadence-java-client)
+# Java framework for Cadence [![Build Status](https://badge.buildkite.com/0c96b8b74c0921208e898c10a602e2fe9ecb7641c2befee0e7.svg?theme=github&branch=master)](https://buildkite.com/uberopensource/cadence-java-client) [![Javadocs](https://www.javadoc.io/badge/com.uber.cadence/cadence-client.svg)](https://www.javadoc.io/doc/com.uber.cadence/cadence-client) [![codecov](https://codecov.io/gh/uber/cadence-java-client/graph/badge.svg?token=eVBGf4EmXr)](https://codecov.io/gh/uber/cadence-java-client)
 
 
 [Cadence](https://github.com/uber/cadence) is a distributed, scalable, durable, and highly available orchestration engine we developed at Uber Engineering to execute asynchronous long-running business logic in a scalable and resilient way.

README.md

@@ -7,7 +7,6 @@ buildscript {
 
 plugins {
     id "com.github.hierynomus.license" version"0.15.0"
-    id 'com.github.nbaztec.coveralls-jacoco' version '1.2.15'
     id 'com.github.sherter.google-java-format' version '0.9'
     id 'net.ltgt.errorprone' version  '1.1.1'
     id 'java-library'
@@ -362,7 +361,7 @@ jacoco {
 jacocoTestReport {
     dependsOn test
     reports {
-        xml.enabled = true // coveralls plugin depends on xml format report
+        xml.enabled = true
         html.enabled = true
     }
 

build.gradle

@@ -93,32 +93,3 @@ services:
       - "USE_DOCKER_SERVICE=false"
     volumes:
       - "../../:/cadence-java-client"
-
-  test-coverage-report:
-    build:
-      context: ../../
-      dockerfile: ./docker/buildkite/Dockerfile
-    command: "./gradlew --no-daemon test"
-    environment:
-      - "USER=unittest"
-      - "USE_DOCKER_SERVICE=false"
-      - CI
-      - BUILDKITE
-      - BUILDKITE_AGENT_ACCESS_TOKEN
-      - BUILDKITE_JOB_ID
-      - BUILDKITE_BUILD_ID
-      - BUILDKITE_BUILD_NUMBER
-      - BUILDKITE_BRANCH
-      - BUILDKITE_BUILD_URL
-      - BUILDKITE_PROJECT_SLUG
-      - BUILDKITE_COMMIT
-      - BUILDKITE_PULL_REQUEST
-      - BUILDKITE_TAG
-      - BUILDKITE_REPO
-      - BUILDKITE_BUILD_CREATOR
-      - BUILDKITE_BUILD_CREATOR_EMAIL
-      - BUILDKITE_BUILD_CREATOR_TEAMS
-      - BUILDKITE_PULL_REQUEST_REPO
-      - COVERALLS_REPO_TOKEN
-    volumes:
-      - "../../:/cadence-java-client"