Simplify code and minor changes

Ernesto Rivera · Ernesto Rivera · commit 165847450e21 · 2014-09-03T18:42:39.000+09:00
diff --git a/Source/AMBTableViewController.m b/Source/AMBTableViewController.m
@@ -183,17 +183,11 @@ - (void)updateAllSections
 
 - (void)combineChanges:(void (^)(void))changes
 {
-    if (self.tableView)
-    {
-        [self.tableView beginUpdates];
-    }
+    [self.tableView beginUpdates];
     
     changes();
     
-    if (self.tableView)
-    {
-        [self.tableView endUpdates];
-    }
+    [self.tableView endUpdates];
 }
 
 - (NSIndexPath *)indexPathForRowWithSubview:(UIView *)subview
@@ -413,7 +407,7 @@ - (void)setObjects:(NSArray *)objects
     _hiddenObjectsMutableIndexSet = [NSMutableIndexSet indexSet];
     [self updateVisibleObjects];
     
-    // Update table view
+    // Reload section
     [self reload];
 }
 
@@ -682,7 +676,8 @@ - (void)insertRowsWithIndexes:(NSIndexSet *)rowIndexSet
 {
     if (self.controller.tableView)
     {
-        [self.controller.tableView insertRowsAtIndexPaths:[self indexPathsForRowIndexes:rowIndexSet]
+        NSArray * indexPaths = [self indexPathsForRowIndexes:rowIndexSet];
+        [self.controller.tableView insertRowsAtIndexPaths:indexPaths
                                          withRowAnimation:self.controller.insertAnimation];
     }
 }
@@ -691,7 +686,8 @@ - (void)deleteRowsWithIndexes:(NSIndexSet *)rowIndexSet
 {
     if (self.controller.tableView)
     {
-        [self.controller.tableView deleteRowsAtIndexPaths:[self indexPathsForRowIndexes:rowIndexSet]
+        NSArray * indexPaths = [self indexPathsForRowIndexes:rowIndexSet];
+        [self.controller.tableView deleteRowsAtIndexPaths:indexPaths
                                          withRowAnimation:self.controller.removeAnimation];
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -183,17 +183,11 @@ - (void)updateAllSections`
`183`	`183`
`184`	`184`	`- (void)combineChanges:(void (^)(void))changes`
`185`	`185`	`{`
`186`		`- if (self.tableView)`
`187`		`- {`
`188`		`- [self.tableView beginUpdates];`
`189`		`- }`
	`186`	`+ [self.tableView beginUpdates];`
`190`	`187`
`191`	`188`	`changes();`
`192`	`189`
`193`		`- if (self.tableView)`
`194`		`- {`
`195`		`- [self.tableView endUpdates];`
`196`		`- }`
	`190`	`+ [self.tableView endUpdates];`
`197`	`191`	`}`
`198`	`192`
`199`	`193`	`- (NSIndexPath )indexPathForRowWithSubview:(UIView )subview`
`@@ -413,7 +407,7 @@ - (void)setObjects:(NSArray *)objects`
`413`	`407`	`_hiddenObjectsMutableIndexSet = [NSMutableIndexSet indexSet];`
`414`	`408`	`[self updateVisibleObjects];`
`415`	`409`
`416`		`- // Update table view`
	`410`	`+ // Reload section`
`417`	`411`	`[self reload];`
`418`	`412`	`}`
`419`	`413`
`@@ -682,7 +676,8 @@ - (void)insertRowsWithIndexes:(NSIndexSet *)rowIndexSet`
`682`	`676`	`{`
`683`	`677`	`if (self.controller.tableView)`
`684`	`678`	`{`
`685`		`- [self.controller.tableView insertRowsAtIndexPaths:[self indexPathsForRowIndexes:rowIndexSet]`
	`679`	`+ NSArray * indexPaths = [self indexPathsForRowIndexes:rowIndexSet];`
	`680`	`+ [self.controller.tableView insertRowsAtIndexPaths:indexPaths`
`686`	`681`	`withRowAnimation:self.controller.insertAnimation];`
`687`	`682`	`}`
`688`	`683`	`}`
`@@ -691,7 +686,8 @@ - (void)deleteRowsWithIndexes:(NSIndexSet *)rowIndexSet`
`691`	`686`	`{`
`692`	`687`	`if (self.controller.tableView)`
`693`	`688`	`{`
`694`		`- [self.controller.tableView deleteRowsAtIndexPaths:[self indexPathsForRowIndexes:rowIndexSet]`
	`689`	`+ NSArray * indexPaths = [self indexPathsForRowIndexes:rowIndexSet];`
	`690`	`+ [self.controller.tableView deleteRowsAtIndexPaths:indexPaths`
`695`	`691`	`withRowAnimation:self.controller.removeAnimation];`
`696`	`692`	`}`
`697`	`693`	`}`