This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Switch back to stable, make local make test target cheaper
#383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benchmark and fuzz targets in particular take quite a long time to run, and are usually not the focus of development. They're still worth running in CI, though, to catch bitrot.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need a nightly compiler until #254 lands (unless wg-ffi-unwind succeeds before then). This reverts us to a stable compiler for now, and adds a note to the
Vmctxinterface warning folks about the safety issues with guest callbacks.While I was at it, I also split off some of the bitrot avoidance bits of the tests into a separate make target, making local development a bit less painful. It still hurts a bit due to all the
lucetccompiles that have to happen under the hood when running various tests, but improving that will have to come later.